Enable a number of lints

Author: kevmoo

analysis_options.yaml

@@ -9,48 +9,65 @@ analyzer:
     override_on_non_overriding_method: error
 linter:
   rules:
-    # Errors
-    - avoid_empty_else
-    - await_only_futures
-    - comment_references
-    - control_flow_in_finally
-    - empty_statements
-    - hash_and_equals
-    - iterable_contains_unrelated_type
-    - no_duplicate_case_values
-    - test_types_in_equals
-    - throw_in_finally
-    - unawaited_futures
-    - unnecessary_statements
-    - unrelated_type_equality_checks
-    - valid_regexps
-
-    # Style
     - annotate_overrides
+    - avoid_empty_else
     - avoid_function_literals_in_foreach_calls
     - avoid_init_to_null
+    - avoid_null_checks_in_equality_operators
     - avoid_return_types_on_setters
     - avoid_returning_null
     - avoid_unused_constructor_parameters
+    - await_only_futures
     - camel_case_types
+    - cancel_subscriptions
+    #- cascade_invocations
+    - comment_references
+    - constant_identifier_names
+    - control_flow_in_finally
     - directives_ordering
     - empty_catches
     - empty_constructor_bodies
+    - empty_statements
+    - hash_and_equals
     - implementation_imports
+    - invariant_booleans
+    - iterable_contains_unrelated_type
     - library_names
     - library_prefixes
+    - list_remove_unrelated_type
+    - no_adjacent_strings_in_list
+    - no_duplicate_case_values
     - non_constant_identifier_names
+    - omit_local_variable_types
     - only_throw_errors
+    - overridden_fields
+    #- package_api_docs
+    - package_names
+    - package_prefixed_library_names
+    - prefer_adjacent_string_concatenation
+    - prefer_collection_literals
     - prefer_conditional_assignment
+    #- prefer_const_constructors
+    - prefer_contains
     - prefer_final_fields
+    - prefer_initializing_formals
+    - prefer_interpolation_to_compose_strings
     - prefer_is_empty
     - prefer_is_not_empty
     - prefer_single_quotes
     - prefer_typing_uninitialized_variables
     - recursive_getters
     - slash_for_doc_comments
+    - super_goes_last
+    - test_types_in_equals
+    - throw_in_finally
     - type_init_formals
+    - unawaited_futures
     - unnecessary_brace_in_string_interps
     - unnecessary_getters_setters
     - unnecessary_lambdas
     - unnecessary_null_aware_assignments
+    - unnecessary_statements
+    - unnecessary_this
+    - unrelated_type_equality_checks
+    - valid_regexps

lib/src/builder.dart

@@ -64,7 +64,7 @@ class _Builder extends Builder {
       throw new ArgumentError.value(_generatedExtension, 'generatedExtension',
           'Extension must be in the format of .*');
     }
-    if (this._isStandalone && this._generators.length > 1) {
+    if (_isStandalone && _generators.length > 1) {
       throw new ArgumentError(
           'A standalone file can only be generated from a single Generator.');
     }
@@ -125,14 +125,13 @@ class _Builder extends Builder {
       contentBuffer.writeln();
     }
 
-    for (GeneratedOutput output in generatedOutputs) {
-      contentBuffer.writeln('');
-      contentBuffer.writeln(_headerLine);
-      contentBuffer.writeln('// Generator: ${output.generator}');
-      contentBuffer.writeln(_headerLine);
-      contentBuffer.writeln('');
-
-      contentBuffer.writeln(output.output);
+    for (var output in generatedOutputs) {
+      contentBuffer..writeln('')
+      ..writeln(_headerLine)
+      ..writeln('// Generator: ${output.generator}')
+      ..writeln(_headerLine)
+      ..writeln('')
+      ..writeln(output.output);
     }
 
     var genPartContent = contentBuffer.toString();

lib/src/constants/utils.dart

@@ -17,8 +17,8 @@ void assertHasField(ClassElement root, String name) {
     }
     element = element.supertype?.element;
   }
-  final allFields = root.fields.toSet();
-  allFields.addAll(root.allSupertypes.expand((t) => t.element.fields));
+  final allFields = root.fields.toSet()
+    ..addAll(root.allSupertypes.expand((t) => t.element.fields));
   throw new FormatException(
     'Class ${root.name} does not have field "$name".',
     'Fields: \n  - ${allFields.map((e) => e.name).join('\n  - ')}',

lib/src/generated_output.dart

@@ -18,9 +18,8 @@ class GeneratedOutput {
       : error = null,
         stackTrace = null;
 
-  GeneratedOutput.fromError(this.generator, Object error, [this.stackTrace])
-      : this.output = _outputFromError(error),
-        this.error = error;
+  GeneratedOutput.fromError(this.generator, this.error, [this.stackTrace])
+      : this.output = _outputFromError(error);
 }
 
 String _outputFromError(Object error) {

lib/src/generator.dart

@@ -23,7 +23,7 @@ abstract class Generator {
   FutureOr<String> generate(LibraryReader library, BuildStep buildStep) => null;
 
   @override
-  String toString() => this.runtimeType.toString();
+  String toString() => runtimeType.toString();
 }
 
 /// May be thrown by generators during [Generator.generate].

pubspec.yaml

@@ -1,5 +1,5 @@
 name: source_gen
-version: 0.7.6
+version: 0.8.0-dev
 author: Dart Team <[email protected]>
 description: Automated source code generation for Dart.
 homepage: https://github.com/dart-lang/source_gen

test/builder_test.dart

@@ -49,7 +49,7 @@ void main() {
         generateFor: new Set.from(['$pkgName|lib/test_lib.dart']),
         outputs: {
           '$pkgName|lib/test_lib.g.dart':
-              decodedMatches(startsWith(_customHeader + '\n\n// ***'))
+              decodedMatches(startsWith('$_customHeader\n\n// ***'))
         });
   });
 
@@ -94,7 +94,7 @@ void main() {
 
   test('Does not fail when there is no output', () async {
     var sources = _createPackageStub(pkgName, testLibContent: 'class A {}');
-    var builder = new PartBuilder([new CommentGenerator(forClasses: false)]);
+    var builder = new PartBuilder([const CommentGenerator(forClasses: false)]);
     await testBuilder(builder, sources, outputs: {});
   });
 
@@ -151,7 +151,7 @@ void main() {
 
   test('defaults to formatting generated code with the DartFormatter',
       () async {
-    await testBuilder(new PartBuilder([new UnformattedCodeGenerator()]),
+    await testBuilder(new PartBuilder([const UnformattedCodeGenerator()]),
         {'$pkgName|lib/a.dart': 'library a; part "a.part.dart";'},
         generateFor: new Set.from(['$pkgName|lib/a.dart']),
         outputs: {
@@ -162,19 +162,19 @@ void main() {
 
   test('PartBuilder uses a custom header when provided', () async {
     await testBuilder(
-        new PartBuilder([new UnformattedCodeGenerator()],
+        new PartBuilder([const UnformattedCodeGenerator()],
             header: _customHeader),
         {'$pkgName|lib/a.dart': 'library a; part "a.part.dart";'},
         generateFor: new Set.from(['$pkgName|lib/a.dart']),
         outputs: {
           '$pkgName|lib/a.g.dart':
-              decodedMatches(startsWith(_customHeader + '\npart of')),
+              decodedMatches(startsWith('$_customHeader\npart of')),
         });
   });
 
   test('PartBuilder includes no header when `header` is empty', () async {
     await testBuilder(
-        new PartBuilder([new UnformattedCodeGenerator()], header: ''),
+        new PartBuilder([const UnformattedCodeGenerator()], header: ''),
         {'$pkgName|lib/a.dart': 'library a; part "a.part.dart";'},
         generateFor: new Set.from(['$pkgName|lib/a.dart']),
         outputs: {
@@ -184,7 +184,7 @@ void main() {
 
   test('can skip formatting with a trivial lambda', () async {
     await testBuilder(
-        new PartBuilder([new UnformattedCodeGenerator()],
+        new PartBuilder([const UnformattedCodeGenerator()],
             formatOutput: (s) => s),
         {'$pkgName|lib/a.dart': 'library a; part "a.part.dart";'},
         generateFor: new Set.from(['$pkgName|lib/a.dart']),
@@ -197,7 +197,7 @@ void main() {
   test('can pass a custom formatter with formatOutput', () async {
     var customOutput = 'final String hello = "hello";';
     await testBuilder(
-        new PartBuilder([new UnformattedCodeGenerator()],
+        new PartBuilder([const UnformattedCodeGenerator()],
             formatOutput: (_) => customOutput),
         {'$pkgName|lib/a.dart': 'library a; part "a.part.dart";'},
         generateFor: new Set.from(['$pkgName|lib/a.dart']),
@@ -217,12 +217,12 @@ void main() {
   });
 
   test('Should have a readable toString() message for builders', () {
-    final builder = new LibraryBuilder(new _NoOpGenerator());
+    final builder = new LibraryBuilder(const _NoOpGenerator());
     expect(builder.toString(), 'Generating .g.dart: NOOP');
 
     final builders = new PartBuilder([
-      new _NoOpGenerator(),
-      new _NoOpGenerator(),
+      const _NoOpGenerator(),
+      const _NoOpGenerator(),
     ]);
     expect(builders.toString(), 'Generating .g.dart: NOOP, NOOP');
   });

test/constants_test.dart

@@ -176,7 +176,7 @@ void main() {
 
     test('should compare using TypeChecker', () {
       final $deprecated = constants[8];
-      final check = new TypeChecker.fromRuntime(Deprecated);
+      final check = const TypeChecker.fromRuntime(Deprecated);
       expect($deprecated.instanceOf(check), isTrue, reason: '$deprecated');
     });
   });

test/test_files/annotation_part.dart

@@ -2,7 +2,7 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
-part of source_gen.test.annotation_test.defs;
+part of 'annotations.dart';
 
 class PublicAnnotationClassInPart {
   const PublicAnnotationClassInPart();

test/test_files/annotations.dart

@@ -2,8 +2,7 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
-library source_gen.test.annotation_test.defs;
-
+// ignore_for_file: prefer_initializing_formals
 import 'dart:collection' as collection;
 
 part 'annotation_part.dart';