Clean up logging pkg:build_runner already logs the input asset ID (#325)

Effectively undoes
83ddeb78f8
#252

Also, only log at the generator. Only print the number if there is more than 1

Author: kevmoo

CHANGELOG.md

@@ -1,5 +1,8 @@
 ## 0.8.1
 
+* Cleanup logging output that duplicates headers provided by 
+  `package:build_runner`.
+
 * `InvalidGenerationSourceError` added an optional `element`
   parameter to support more helpful error messages.
 

lib/src/builder.dart

@@ -72,7 +72,6 @@ class _Builder extends Builder {
 
   Future _generateForLibrary(
       LibraryElement library, BuildStep buildStep) async {
-    log.fine('Running $_generators for ${buildStep.inputId}');
     var generatedOutputs =
         await _generate(library, _generators, buildStep).toList();
 
@@ -204,16 +203,21 @@ class LibraryBuilder extends _Builder {
 Stream<GeneratedOutput> _generate(LibraryElement library,
     List<Generator> generators, BuildStep buildStep) async* {
   var libraryReader = new LibraryReader(library);
-  for (var gen in generators) {
+  for (var i = 0; i < generators.length; i++) {
+    var gen = generators[i];
     try {
-      log.finer('Running $gen for ${buildStep.inputId}');
+      var msg = 'Running $gen';
+      if (generators.length > 1) {
+        msg = '$msg - ${i+1} of ${generators.length}';
+      }
+      log.fine(msg);
       var createdUnit = await gen.generate(libraryReader, buildStep);
 
       if (createdUnit != null && createdUnit.isNotEmpty) {
         yield new GeneratedOutput(gen, createdUnit);
       }
     } catch (e, stack) {
-      log.severe('Error running $gen for ${buildStep.inputId}.', e, stack);
+      log.severe('Error running $gen', e, stack);
       yield new GeneratedOutput.fromError(gen, e, stack);
     }
   }

pubspec.yaml

@@ -16,7 +16,6 @@ dev_dependencies:
   build_test: ">0.9.0 <0.11.0"
   collection: ^1.1.2
   cli_util: '>=0.1.0 <0.2.0'
-  logging: ^0.11.3
   test: ^0.12.3
   _test_annotations:
     path: ./_test_annotations

test/builder_test.dart

@@ -6,7 +6,6 @@
 import 'dart:async';
 
 import 'package:build_test/build_test.dart';
-import 'package:logging/logging.dart';
 import 'package:source_gen/source_gen.dart';
 import 'package:test/test.dart';
 
@@ -191,16 +190,6 @@ void main() {
         });
   });
 
-  test('Error logs contain original input ids', () async {
-    var logs = <LogRecord>[];
-    await testBuilder(new LibraryBuilder(new _ThrowingGenerator()),
-        {'$_pkgName|lib/a.dart': 'void hello() {}'},
-        onLog: logs.add);
-    await new Future(() {});
-    expect(
-        logs.map((l) => l.message), contains(contains('$_pkgName|lib/a.dart')));
-  });
-
   test('Should have a readable toString() message for builders', () {
     final builder = new LibraryBuilder(const _NoOpGenerator());
     expect(builder.toString(), 'Generating .g.dart: NOOP');
@@ -251,11 +240,6 @@ class _BadOutputGenerator extends Generator {
   Future<String> generate(LibraryReader library, _) async => 'not valid code!';
 }
 
-class _ThrowingGenerator extends Generator {
-  @override
-  Future<String> generate(_, __) async => throw new UnimplementedError();
-}
-
 final _customHeader = '// Copyright 1979';
 
 const _pkgName = 'pkg';