Fix analysis errors.

Author: davidmorgan

analysis_options.yaml

@@ -5,6 +5,8 @@ analyzer:
     strict-casts: true
     strict-inference: true
     strict-raw-types: true
+  errors:
+    deprecated_member_use_from_same_package: ignore
 
 linter:
   rules:

source_gen/lib/src/builder.dart

@@ -425,7 +425,7 @@ const partIdRegExpLiteral = r'[A-Za-z_\d-]+';
 
 final _partIdRegExp = RegExp('^$partIdRegExpLiteral\$');
 
-@deprecated
+@Deprecated('Use languageOverrideForLibrary2 instead')
 String languageOverrideForLibrary(LibraryElement library) {
   final override = library.languageVersion.override;
   return override == null

source_gen/lib/src/constants/revive.dart

@@ -22,7 +22,7 @@ import '../utils.dart';
 /// **NOTE**: Some returned [Revivable] instances are not representable as valid
 /// Dart source code (such as referencing private constructors). It is up to the
 /// build tool(s) using this library to surface error messages to the user.
-@deprecated
+@Deprecated('use reviveInstance2 instead')
 Revivable reviveInstance(DartObject object, [LibraryElement? origin]) {
   final objectType = object.type;
   Element? element = objectType!.alias?.element;

source_gen/lib/src/generator.dart

@@ -60,7 +60,7 @@ class InvalidGenerationSource implements Exception {
   /// code, or if the location was passed with [element].
   final AstNode? node;
 
-  @deprecated
+  @Deprecated('use v2 instead')
   InvalidGenerationSource(
     this.message, {
     this.todo = '',
@@ -75,7 +75,7 @@ class InvalidGenerationSource implements Exception {
     this.node,
   }) : element2 = element;
 
-  @deprecated
+  @Deprecated('use element2 instead')
   Element? get element => element2?.asElement;
 
   @override

source_gen/lib/src/generator_for_annotation.dart

@@ -112,7 +112,7 @@ abstract class GeneratorForAnnotation<T> extends Generator {
   ///
   /// Implementations should return `null` when no content is generated. Empty
   /// or whitespace-only [String] instances are also ignored.
-  @deprecated
+  @Deprecated('use generateForAnnotatedElement2 instead')
   dynamic generateForAnnotatedElement(
     Element element,
     ConstantReader annotation,

source_gen/lib/src/library.dart

@@ -30,7 +30,7 @@ class AnnotatedElement {
 
   const AnnotatedElement(this.annotation, this.element2);
 
-  @deprecated
+  @Deprecated('use element2 instead')
   Element get element => element2.asElement!;
 
   Metadata? get metadata2 {
@@ -45,16 +45,16 @@ class AnnotatedElement {
 class LibraryReader {
   final LibraryElement2 element2;
 
-  @deprecated
+  @Deprecated('use v2 instead')
   LibraryReader(LibraryElement element) : this.v2(element.asElement2);
 
   LibraryReader.v2(this.element2);
 
-  @deprecated
+  @Deprecated('use element2 instead')
   LibraryElement get element => element2.asElement;
 
   /// All of the declarations in this library.
-  @deprecated
+  @Deprecated('use allElements2 instead')
   Iterable<Element> get allElements => [
         element,
         ...element.topLevelElements,
@@ -67,15 +67,15 @@ class LibraryReader {
   Iterable<Element2> get allElements2 => [element2, ...element2.children2];
 
   /// All of the elements representing classes in this library.
-  @deprecated
+  @Deprecated('use classes2 instead')
   Iterable<ClassElement> get classes =>
       element.units.expand((cu) => cu.classes);
 
   /// All of the elements representing classes in this library.
   Iterable<ClassElement2> get classes2 => element2.classes;
 
   /// All of the elements representing enums in this library.
-  @deprecated
+  @Deprecated('use enums2 instead')
   Iterable<EnumElement> get enums => element.units.expand((cu) => cu.enums);
 
   /// All of the elements representing enums in this library.
@@ -150,7 +150,7 @@ class LibraryReader {
 
   /// Returns a top-level [ClassElement2] publicly visible in by [name].
   ///
-  /// Unlike [LibraryElement2.getClass], this also correctly traverses
+  /// Unlike `LibraryElement2.getClass`, this also correctly traverses
   /// identifiers that are accessible via one or more `export` directives.
   ClassElement2? findType2(String name) {
     final type = element2.exportNamespace.get2(name);
@@ -167,7 +167,7 @@ class LibraryReader {
   ///
   /// This is a typed convenience function for using [pathToUrl], and the same
   /// API restrictions hold around supported schemes and relative paths.
-  @deprecated
+  @Deprecated('use pathToElement2 instead')
   Uri pathToElement(Element element) => pathToUrl(element.source!.uri);
 
   /// Returns a [Uri] from the current library to the target [element].

source_gen/lib/src/span_for_element.dart

@@ -20,7 +20,7 @@ import 'utils.dart';
 ///
 /// Not all results from the analyzer API may return source information as part
 /// of the element, so [file] may need to be manually provided in those cases.
-@deprecated
+@Deprecated('use spanForElement2 instead')
 SourceSpan spanForElement(Element element, [SourceFile? file]) {
   final url = assetToPackageUrl(element.source!.uri);
   if (file == null) {

source_gen/lib/src/type_checker.dart

@@ -64,7 +64,7 @@ abstract class TypeChecker {
   /// Otherwise returns `null`.
   ///
   /// Throws on unresolved annotations unless [throwOnUnresolved] is `false`.
-  @deprecated
+  @Deprecated('use firstAnnotationOf2 instead')
   DartObject? firstAnnotationOf(
     Element element, {
     bool throwOnUnresolved = true,
@@ -104,7 +104,7 @@ abstract class TypeChecker {
   /// Returns if a constant annotating [element] is assignable to this type.
   ///
   /// Throws on unresolved annotations unless [throwOnUnresolved] is `false`.
-  @deprecated
+  @Deprecated('use hasAnnotationOf2 instead')
   bool hasAnnotationOf(Element element, {bool throwOnUnresolved = true}) =>
       firstAnnotationOf(element, throwOnUnresolved: throwOnUnresolved) != null;
 
@@ -118,7 +118,7 @@ abstract class TypeChecker {
   ///
   /// Throws [UnresolvedAnnotationException] on unresolved annotations unless
   /// [throwOnUnresolved] is explicitly set to `false` (default is `true`).
-  @deprecated
+  @Deprecated('use firstAnnotationOfExact2 instead')
   DartObject? firstAnnotationOfExact(
     Element element, {
     bool throwOnUnresolved = true,
@@ -159,7 +159,7 @@ abstract class TypeChecker {
   ///
   /// Throws [UnresolvedAnnotationException] on unresolved annotations unless
   /// [throwOnUnresolved] is explicitly set to `false` (default is `true`).
-  @deprecated
+  @Deprecated('use hasAnnotationOfExact2 instead')
   bool hasAnnotationOfExact(Element element, {bool throwOnUnresolved = true}) =>
       firstAnnotationOfExact(element, throwOnUnresolved: throwOnUnresolved) !=
       null;
@@ -175,7 +175,7 @@ abstract class TypeChecker {
       firstAnnotationOfExact2(element, throwOnUnresolved: throwOnUnresolved) !=
       null;
 
-  @deprecated
+  @Deprecated('use _computeConstantValue2 instead')
   DartObject? _computeConstantValue(
     Element element,
     int annotationIndex, {
@@ -209,7 +209,7 @@ abstract class TypeChecker {
   ///
   /// Throws [UnresolvedAnnotationException] on unresolved annotations unless
   /// [throwOnUnresolved] is explicitly set to `false` (default is `true`).
-  @deprecated
+  @Deprecated('use annotationsOf2 instead')
   Iterable<DartObject> annotationsOf(
     Element element, {
     bool throwOnUnresolved = true,
@@ -234,7 +234,7 @@ abstract class TypeChecker {
         throwOnUnresolved: throwOnUnresolved,
       );
 
-  @deprecated
+  @Deprecated('use _annotationsWhere2 instead')
   Iterable<DartObject> _annotationsWhere(
     Element element,
     bool Function(DartType) predicate, {
@@ -277,7 +277,7 @@ abstract class TypeChecker {
   ///
   /// Throws [UnresolvedAnnotationException] on unresolved annotations unless
   /// [throwOnUnresolved] is explicitly set to `false` (default is `true`).
-  @deprecated
+  @Deprecated('use annotationsOfExact2 instead')
   Iterable<DartObject> annotationsOfExact(
     Element element, {
     bool throwOnUnresolved = true,
@@ -303,7 +303,7 @@ abstract class TypeChecker {
       );
 
   /// Returns `true` if the type of [element] can be assigned to this type.
-  @deprecated
+  @Deprecated('use isAssignableFrom2 instead')
   bool isAssignableFrom(Element element) =>
       isExactly(element) ||
       (element is InterfaceElement && element.allSupertypes.any(isExactlyType));
@@ -321,7 +321,7 @@ abstract class TypeChecker {
   }
 
   /// Returns `true` if representing the exact same class as [element].
-  @deprecated
+  @Deprecated('use isExactly2 instead')
   bool isExactly(Element element);
 
   /// Returns `true` if representing the exact same class as [element].
@@ -344,7 +344,7 @@ abstract class TypeChecker {
   ///
   /// This check only takes into account the *extends* hierarchy. If you wish
   /// to check mixins and interfaces, use [isAssignableFrom].
-  @deprecated
+  @Deprecated('use isSuperOf2 instead')
   bool isSuperOf(Element element) {
     if (element is InterfaceElement) {
       var theSuper = element.supertype;
@@ -423,7 +423,7 @@ class _MirrorTypeChecker extends TypeChecker {
   TypeChecker get _computed =>
       _cache[this] ??= TypeChecker.fromUrl(_uriOf(reflectClass(_type)));
 
-  @deprecated
+  @Deprecated('use isExactly2 instead')
   @override
   bool isExactly(Element element) => _computed.isExactly(element);
 
@@ -459,7 +459,7 @@ class _UriTypeChecker extends TypeChecker {
       uri.toString() ==
       (url is String ? url : normalizeUrl(url as Uri).toString());
 
-  @deprecated
+  @Deprecated('use isExactly2 instead')
   @override
   bool isExactly(Element element) => hasSameUrl(urlOfElement(element));
 
@@ -475,7 +475,7 @@ class _AnyChecker extends TypeChecker {
 
   const _AnyChecker(this._checkers) : super._();
 
-  @deprecated
+  @Deprecated('use isExactly2 instead')
   @override
   bool isExactly(Element element) => _checkers.any((c) => c.isExactly(element));
 
@@ -499,7 +499,7 @@ class UnresolvedAnnotationException implements Exception {
   /// May be `null` if the import library was not found.
   final SourceSpan? annotationSource;
 
-  @deprecated
+  @Deprecated('use annotatedElement2 instead')
   Element get annotatedElement => annotatedElement2.asElement!;
 
   static SourceSpan? _findSpan(Element2 annotatedElement, int annotationIndex) {
@@ -552,7 +552,7 @@ the version of `package:source_gen`, `package:analyzer` from `pubspec.lock`.
   }
 
   /// Creates an exception from an annotation ([annotationIndex]) that was not
-  /// resolvable while traversing [Element2.metadata] on [annotatedElement].
+  /// resolvable while traversing `Element2.metadata` on [annotatedElement].
   factory UnresolvedAnnotationException._from(
     Element2 annotatedElement,
     int annotationIndex,

source_gen/lib/src/utils.dart

@@ -45,7 +45,7 @@ bool hasExpectedPartDirective(CompilationUnit unit, String part) =>
         .any((e) => e.uri.stringValue == part);
 
 /// Returns a uri suitable for `part of "..."` when pointing to [element].
-@deprecated
+@Deprecated('use uriOfPartial2 instead')
 String uriOfPartial(LibraryElement element, AssetId source, AssetId output) {
   assert(source.package == output.package);
   return p.url.relative(source.path, from: p.url.dirname(output.path));
@@ -65,7 +65,7 @@ String computePartUrl(AssetId input, AssetId output) => p.url.joinAll(
     );
 
 /// Returns a URL representing [element].
-@deprecated
+@Deprecated('use urlOfElement2 instead')
 String urlOfElement(Element element) => element.kind == ElementKind.DYNAMIC
     ? 'dart:core#dynamic'
     // using librarySource.uri – in case the element is in a part

source_gen/test/type_checker_test.dart

@@ -200,10 +200,14 @@ void main() {
     group(
       '(MapMixin',
       () {
-        test('should equal MapMixin class', () {
-          expect(checkMapMixin().isExactlyType(staticMapMixin), isTrue);
-          expect(checkMapMixin().isExactly2(staticMapMixin.element3), isTrue);
-        }, skip: 'Google3 test gives google3:// URI for the test mirror');
+        test(
+          'should equal MapMixin class',
+          () {
+            expect(checkMapMixin().isExactlyType(staticMapMixin), isTrue);
+            expect(checkMapMixin().isExactly2(staticMapMixin.element3), isTrue);
+          },
+          skip: 'Google3 test gives google3:// URI for the test mirror',
+        );
       },
       onPlatform: const {
         'windows': Skip('https://github.com/dart-lang/source_gen/issues/573'),