add test for enum assignability (#639)

Related to #638

Author: jakemac53

source_gen/CHANGELOG.md

@@ -1,3 +1,5 @@
+## 1.2.8-dev
+
 ## 1.2.7
 
 * Update the value of the pubspec `repository` field.

source_gen/lib/src/type_checker.dart

@@ -332,7 +332,7 @@ class UnresolvedAnnotationException implements Exception {
       // Trying to get more information on https://github.com/dart-lang/sdk/issues/45127
       log.warning(
         '''
-An unexpected error was thrown trying to get location information on `$annotatedElement` (${annotatedElement.runtimeType}). 
+An unexpected error was thrown trying to get location information on `$annotatedElement` (${annotatedElement.runtimeType}).
 
 Please file an issue at https://github.com/dart-lang/source_gen/issues/new
 Include the contents of this warning and the stack trace along with

source_gen/pubspec.yaml

@@ -1,5 +1,5 @@
 name: source_gen
-version: 1.2.7
+version: 1.2.8-dev
 description: >-
   Source code generation builders and utilities for the Dart build system
 repository: https://github.com/dart-lang/source_gen/tree/master/source_gen

source_gen/test/type_checker_test.dart

@@ -22,6 +22,7 @@ void main() {
   late InterfaceType staticUnmodifiableListView;
   late InterfaceType staticEnum;
   late TypeChecker staticIterableChecker;
+  late TypeChecker staticEnumMixinChecker;
   late TypeChecker staticMapChecker;
   late TypeChecker staticMapMixinChecker;
   late TypeChecker staticHashMapChecker;
@@ -34,8 +35,10 @@ void main() {
   late TypeChecker staticGeneratorForAnnotationChecker;
 
   // Resolved top-level types from this file
+  late InterfaceType staticEnumMixin;
   late InterfaceType staticMapMixin;
   late InterfaceType staticMyEnum;
+  late InterfaceType staticMyEnumWithMixin;
 
   setUpAll(() async {
     late LibraryElement core;
@@ -82,6 +85,13 @@ void main() {
       nullabilitySuffix: NullabilitySuffix.none,
     );
     staticEnumChecker = TypeChecker.fromStatic(staticEnum);
+    staticEnumMixin =
+        (testSource.exportNamespace.get('MyEnumMixin')! as InterfaceElement)
+            .instantiate(
+      typeArguments: [],
+      nullabilitySuffix: NullabilitySuffix.none,
+    );
+    staticEnumMixinChecker = TypeChecker.fromStatic(staticEnumMixin);
     staticMapMixin =
         (testSource.exportNamespace.get('MyMapMixin')! as InterfaceElement)
             .instantiate(
@@ -95,6 +105,12 @@ void main() {
       typeArguments: [],
       nullabilitySuffix: NullabilitySuffix.none,
     );
+    staticMyEnumWithMixin =
+        (testSource.exportNamespace.get('MyEnumWithMixin')! as InterfaceElement)
+            .instantiate(
+      typeArguments: [],
+      nullabilitySuffix: NullabilitySuffix.none,
+    );
 
     staticHashMap = collection.getClass('HashMap')!.instantiate(
       typeArguments: [
@@ -130,6 +146,7 @@ void main() {
     required TypeChecker Function() checkEnum,
     required TypeChecker Function() checkMap,
     required TypeChecker Function() checkMapMixin,
+    required TypeChecker Function() checkEnumMixin,
     required TypeChecker Function() checkHashMap,
     required TypeChecker Function() checkGenerator,
     required TypeChecker Function() checkGeneratorForAnnotation,
@@ -148,6 +165,19 @@ void main() {
       test('should be supertype of enum classes', () {
         expect(checkEnum().isSuperTypeOf(staticMyEnum), isTrue);
       });
+
+      test(
+        'with mixins should be assignable to mixin class',
+        () {
+          expect(
+            checkEnumMixin().isAssignableFromType(staticMyEnumWithMixin),
+            isTrue,
+          );
+        },
+        onPlatform: const {
+          'windows': Skip('https://github.com/dart-lang/source_gen/issues/573'),
+        },
+      );
     });
 
     group(
@@ -267,6 +297,7 @@ void main() {
     commonTests(
       checkIterable: () => const TypeChecker.fromRuntime(Iterable),
       checkEnum: () => const TypeChecker.fromRuntime(Enum),
+      checkEnumMixin: () => const TypeChecker.fromRuntime(MyEnumMixin),
       checkMap: () => const TypeChecker.fromRuntime(Map),
       checkMapMixin: () => const TypeChecker.fromRuntime(MyMapMixin),
       checkHashMap: () => const TypeChecker.fromRuntime(HashMap),
@@ -280,6 +311,7 @@ void main() {
     commonTests(
       checkIterable: () => staticIterableChecker,
       checkEnum: () => staticEnumChecker,
+      checkEnumMixin: () => staticEnumMixinChecker,
       checkMap: () => staticMapChecker,
       checkMapMixin: () => staticMapMixinChecker,
       checkHashMap: () => staticHashMapChecker,
@@ -292,6 +324,9 @@ void main() {
     commonTests(
       checkIterable: () => const TypeChecker.fromUrl('dart:core#Iterable'),
       checkEnum: () => const TypeChecker.fromUrl('dart:core#Enum'),
+      checkEnumMixin: () => const TypeChecker.fromUrl(
+        'asset:source_gen/test/type_checker_test.dart#MyEnumMixin',
+      ),
       checkMap: () => const TypeChecker.fromUrl('dart:core#Map'),
       checkMapMixin: () => const TypeChecker.fromUrl(
         'asset:source_gen/test/type_checker_test.dart#MyMapMixin',
@@ -560,3 +595,9 @@ final throwsUnresolvedAnnotationException = throwsA(
 mixin MyMapMixin on Map<dynamic, dynamic> {}
 
 enum MyEnum { foo, bar }
+
+mixin MyEnumMixin on Enum {
+  int get value => 1;
+}
+
+enum MyEnumWithMixin with MyEnumMixin { foo, bar }