Skip to content

Commit a8b2a2d

Browse files
committed
Bring up to dart 8.1.1, get rid of deprecated classes and methods in the code.
1 parent e69abb4 commit a8b2a2d

16 files changed

+132
-177
lines changed

example/lib/src/multiplier_generator.dart

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,7 @@
22
// for details. All rights reserved. Use of this source code is governed by a
33
// BSD-style license that can be found in the LICENSE file.
44

5-
// ignore_for_file: deprecated_member_use until analyzer 7 support is dropped.
6-
7-
import 'package:analyzer/dart/element/element2.dart';
5+
import 'package:analyzer/dart/element/element.dart';
86
import 'package:build/build.dart';
97
import 'package:source_gen/source_gen.dart';
108

@@ -13,13 +11,13 @@ import '../annotations.dart';
1311
class MultiplierGenerator extends GeneratorForAnnotation<Multiplier> {
1412
@override
1513
String generateForAnnotatedElement(
16-
Element2 element,
14+
Element element,
1715
ConstantReader annotation,
1816
BuildStep buildStep,
1917
) {
2018
final numValue = annotation.read('value').literalValue as num;
2119

22-
return 'num ${element.name3}Multiplied() => ${element.name3} * $numValue;';
20+
return 'num ${element.name}Multiplied() => ${element.name} * $numValue;';
2321
}
2422

2523
// Override this method to respond to annotations on directives: `import`,

example/lib/src/property_product_generator.dart

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,7 @@ class PropertyProductGenerator extends Generator {
1212
String generate(LibraryReader library, BuildStep buildStep) {
1313
final productNames = topLevelNumVariables(
1414
library,
15-
// ignore: deprecated_member_use until analyzer 7 support is dropped.
16-
).map((element) => element.name3).join(' * ');
15+
).map((element) => element.name).join(' * ');
1716

1817
return '''
1918
num allProduct() => $productNames;

example/lib/src/property_sum_generator.dart

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,7 @@ class PropertySumGenerator extends Generator {
1212
String generate(LibraryReader library, BuildStep buildStep) {
1313
final sumNames = topLevelNumVariables(
1414
library,
15-
// ignore: deprecated_member_use until analyzer 7 support is dropped.
16-
).map((element) => element.name3).join(' + ');
15+
).map((element) => element.name).join(' + ');
1716

1817
return '''
1918
num allSum() => $sumNames;

example/lib/src/utils.dart

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -2,15 +2,13 @@
22
// for details. All rights reserved. Use of this source code is governed by a
33
// BSD-style license that can be found in the LICENSE file.
44

5-
// ignore_for_file: deprecated_member_use until analyzer 7 support is dropped.
6-
7-
import 'package:analyzer/dart/element/element2.dart';
5+
import 'package:analyzer/dart/element/element.dart';
86
import 'package:source_gen/source_gen.dart';
97

10-
/// Returns all [TopLevelVariableElement2] members in [reader]'s library that
8+
/// Returns all [TopLevelVariableElement] members in [reader]'s library that
119
/// have a type of [num].
12-
Iterable<TopLevelVariableElement2> topLevelNumVariables(LibraryReader reader) =>
13-
reader.allElements.whereType<TopLevelVariableElement2>().where(
10+
Iterable<TopLevelVariableElement> topLevelNumVariables(LibraryReader reader) =>
11+
reader.allElements.whereType<TopLevelVariableElement>().where(
1412
(element) =>
1513
element.type.isDartCoreNum ||
1614
element.type.isDartCoreInt ||

source_gen/lib/src/builder.dart

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,7 @@
55
import 'dart:convert';
66

77
import 'package:analyzer/dart/ast/ast.dart';
8-
// ignore: deprecated_member_use until analyzer 7 support is dropped.
9-
import 'package:analyzer/dart/element/element2.dart';
8+
import 'package:analyzer/dart/element/element.dart';
109
import 'package:build/build.dart';
1110
import 'package:dart_style/dart_style.dart';
1211
import 'package:pub_semver/pub_semver.dart';
@@ -110,8 +109,7 @@ class _Builder extends Builder {
110109
}
111110

112111
Future<void> _generateForLibrary(
113-
// ignore: deprecated_member_use until analyzer 7 support is dropped.
114-
LibraryElement2 library,
112+
LibraryElement library,
115113
BuildStep buildStep,
116114
) async {
117115
final generatedOutputs =
@@ -357,8 +355,7 @@ class LibraryBuilder extends _Builder {
357355
}
358356

359357
Stream<GeneratedOutput> _generate(
360-
// ignore: deprecated_member_use until analyzer 7 support is dropped.
361-
LibraryElement2 library,
358+
LibraryElement library,
362359
List<Generator> generators,
363360
BuildStep buildStep,
364361
) async* {
@@ -443,8 +440,7 @@ const partIdRegExpLiteral = r'[A-Za-z_\d-]+';
443440

444441
final _partIdRegExp = RegExp('^$partIdRegExpLiteral\$');
445442

446-
// ignore: deprecated_member_use until analyzer 7 support is dropped.
447-
String languageOverrideForLibrary(LibraryElement2 library) {
443+
String languageOverrideForLibrary(LibraryElement library) {
448444
final override = library.languageVersion.override;
449445
return override == null
450446
? ''

source_gen/lib/src/constants/reader.dart

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,7 @@
33
// BSD-style license that can be found in the LICENSE file.
44

55
import 'package:analyzer/dart/constant/value.dart';
6-
// ignore: deprecated_member_use until analyzer 7 support is dropped.
7-
import 'package:analyzer/dart/element/element2.dart';
6+
import 'package:analyzer/dart/element/element.dart';
87
import 'package:analyzer/dart/element/type.dart';
98

109
import '../type_checker.dart';
@@ -269,8 +268,7 @@ class _DartObjectConstant extends ConstantReader {
269268
ConstantReader read(String field) {
270269
final reader = peek(field);
271270
if (reader == null) {
272-
// ignore: deprecated_member_use until analyzer 7 support is dropped.
273-
assertHasField(objectValue.type!.element3 as InterfaceElement2, field);
271+
assertHasField(objectValue.type!.element as InterfaceElement, field);
274272
return const _NullConstant();
275273
}
276274
return reader;

source_gen/lib/src/constants/revive.dart

Lines changed: 19 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -3,11 +3,11 @@
33
// BSD-style license that can be found in the LICENSE file.
44

55
// TODO(kevmoo): migrate analyzer APIs when we can get latest with a stable SDK
6-
// ignore_for_file: deprecated_member_use
76

87
import 'package:analyzer/dart/constant/value.dart';
9-
import 'package:analyzer/dart/element/element2.dart';
8+
import 'package:analyzer/dart/element/element.dart';
109
import 'package:analyzer/dart/element/type.dart';
10+
1111
// ignore: implementation_imports
1212
import 'package:analyzer/src/dart/constant/value.dart' show DartObjectImpl;
1313

@@ -22,37 +22,37 @@ import '../utils.dart';
2222
/// **NOTE**: Some returned [Revivable] instances are not representable as valid
2323
/// Dart source code (such as referencing private constructors). It is up to the
2424
/// build tool(s) using this library to surface error messages to the user.
25-
Revivable reviveInstance(DartObject object, [LibraryElement2? origin]) {
25+
Revivable reviveInstance(DartObject object, [LibraryElement? origin]) {
2626
final objectType = object.type;
27-
Element2? element = objectType!.alias?.element2;
27+
Element? element = objectType!.alias?.element;
2828
if (element == null) {
2929
if (objectType is InterfaceType) {
30-
element = objectType.element3;
30+
element = objectType.element;
3131
} else {
32-
element = object.toFunctionValue2();
32+
element = object.toFunctionValue();
3333
}
3434
}
35-
origin ??= element!.library2;
35+
origin ??= element!.library;
3636
var url = Uri.parse(urlOfElement(element!));
3737
if (element is TopLevelFunctionElement || element is LocalFunctionElement) {
38-
return Revivable._(source: url.removeFragment(), accessor: element.name3!);
38+
return Revivable._(source: url.removeFragment(), accessor: element.name!);
3939
}
4040

41-
if (element is MethodElement2 && element.isStatic) {
41+
if (element is MethodElement && element.isStatic) {
4242
return Revivable._(
4343
source: url.removeFragment(),
4444
accessor:
45-
'${element.firstFragment.enclosingFragment!.name2}.${element.name3}',
45+
'${element.firstFragment.enclosingFragment!.name}.${element.name}',
4646
);
4747
}
4848

49-
if (element is InterfaceElement2) {
50-
for (final e in element.fields2.where(
49+
if (element is InterfaceElement) {
50+
for (final e in element.fields.where(
5151
(f) => f.isPublic && f.isConst && f.computeConstantValue() == object,
5252
)) {
5353
return Revivable._(
5454
source: url.removeFragment(),
55-
accessor: '${element.name3}.${e.name3}',
55+
accessor: '${element.name}.${e.name}',
5656
);
5757
}
5858
}
@@ -67,25 +67,25 @@ Revivable reviveInstance(DartObject object, [LibraryElement2? origin]) {
6767
}
6868

6969
for (final type in origin!.classes) {
70-
for (final e in type.fields2.where(
70+
for (final e in type.fields.where(
7171
(f) => f.isConst && f.computeConstantValue() == object,
7272
)) {
7373
final result = Revivable._(
7474
source: url.removeFragment(),
75-
accessor: '${type.name3}.${e.name3}',
75+
accessor: '${type.name}.${e.name}',
7676
);
7777
if (tryResult(result)) {
7878
return result;
7979
}
8080
}
8181
}
82-
final i = (object as DartObjectImpl).getInvocation();
82+
final i = (object as DartObjectImpl).constructorInvocation;
8383
if (i != null) {
84-
url = Uri.parse(urlOfElement(i.constructor2.enclosingElement2));
84+
url = Uri.parse(urlOfElement(i.constructor.enclosingElement));
8585
String newToEmpty(String string) => string == 'new' ? '' : string;
8686
final result = Revivable._(
8787
source: url,
88-
accessor: newToEmpty(i.constructor2.name3!),
88+
accessor: newToEmpty(i.constructor.name!),
8989
namedArguments: i.namedArguments,
9090
positionalArguments: i.positionalArguments,
9191
);
@@ -98,7 +98,7 @@ Revivable reviveInstance(DartObject object, [LibraryElement2? origin]) {
9898
)) {
9999
final result = Revivable._(
100100
source: Uri.parse(urlOfElement(origin)).replace(fragment: ''),
101-
accessor: e.name3!,
101+
accessor: e.name!,
102102
);
103103
if (tryResult(result)) {
104104
return result;

source_gen/lib/src/constants/utils.dart

Lines changed: 10 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -2,31 +2,29 @@
22
// for details. All rights reserved. Use of this source code is governed by a
33
// BSD-style license that can be found in the LICENSE file.
44

5-
// ignore_for_file: deprecated_member_use until analyzer 7 support is dropped.
6-
75
import 'package:analyzer/dart/constant/value.dart';
8-
import 'package:analyzer/dart/element/element2.dart';
6+
import 'package:analyzer/dart/element/element.dart';
97

108
/// Throws a [FormatException] if [root] does not have a given field [name].
119
///
12-
/// Super types [InterfaceElement2.supertype] are also checked before throwing.
13-
void assertHasField(InterfaceElement2 root, String name) {
14-
InterfaceElement2? element = root;
10+
/// Super types [InterfaceElement.supertype] are also checked before throwing.
11+
void assertHasField(InterfaceElement root, String name) {
12+
InterfaceElement? element = root;
1513
while (element != null) {
16-
final field = element.getField2(name);
14+
final field = element.getField(name);
1715
if (field != null) {
1816
return;
1917
}
20-
element = element.supertype?.element3;
18+
element = element.supertype?.element;
2119
}
2220
final allFields = {
23-
...root.fields2,
24-
for (var t in root.allSupertypes) ...t.element3.fields2,
21+
...root.fields,
22+
for (var t in root.allSupertypes) ...t.element.fields,
2523
};
2624

2725
throw FormatException(
28-
'Class ${root.name3} does not have field "$name".',
29-
'Fields: \n - ${allFields.map((e) => e.name3).join('\n - ')}',
26+
'Class ${root.name} does not have field "$name".',
27+
'Fields: \n - ${allFields.map((e) => e.name).join('\n - ')}',
3028
);
3129
}
3230

source_gen/lib/src/generator.dart

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,7 @@
55
import 'dart:async';
66

77
import 'package:analyzer/dart/ast/ast.dart';
8-
// ignore: deprecated_member_use until analyzer 7 support is dropped.
9-
import 'package:analyzer/dart/element/element2.dart';
8+
import 'package:analyzer/dart/element/element.dart';
109
import 'package:build/build.dart';
1110
import 'package:source_span/source_span.dart';
1211

@@ -48,8 +47,7 @@ class InvalidGenerationSource implements Exception {
4847
final String todo;
4948

5049
/// The `Element2` associated with this error, if any.
51-
/// ignore: deprecated_member_use until analyzer 7 support is dropped.
52-
final Element2? element;
50+
final Element? element;
5351

5452
/// The [ElementDirective] associated with this error, if any.
5553
final ElementDirective? elementDirective;

source_gen/lib/src/generator_for_annotation.dart

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,7 @@
44

55
import 'dart:async';
66

7-
// ignore: deprecated_member_use until analyzer 7 support is dropped.
8-
import 'package:analyzer/dart/element/element2.dart';
7+
import 'package:analyzer/dart/element/element.dart';
98
import 'package:build/build.dart';
109

1110
import 'constants/reader.dart';
@@ -68,9 +67,7 @@ abstract class GeneratorForAnnotation<T> extends Generator {
6867
this.inSdk,
6968
});
7069

71-
// This will switch to `typeNamed` in 4.0.0.
72-
// ignore: deprecated_member_use_from_same_package
73-
TypeChecker get typeChecker => TypeChecker.fromRuntime(T);
70+
TypeChecker get typeChecker => TypeChecker.typeNamed(T);
7471

7572
@override
7673
FutureOr<String> generate(LibraryReader library, BuildStep buildStep) async {
@@ -127,8 +124,7 @@ abstract class GeneratorForAnnotation<T> extends Generator {
127124
/// Implementations should return `null` when no content is generated. Empty
128125
/// or whitespace-only [String] instances are also ignored.
129126
dynamic generateForAnnotatedElement(
130-
// ignore: deprecated_member_use until analyzer 7 support is dropped.
131-
Element2 element,
127+
Element element,
132128
ConstantReader annotation,
133129
BuildStep buildStep,
134130
) {}

0 commit comments

Comments
 (0)