Enable prefer_equal_for_default_values lint (#334)

Author: natebosch

analysis_options.yaml

@@ -49,6 +49,7 @@ linter:
     - prefer_conditional_assignment
     #- prefer_const_constructors
     - prefer_contains
+    - prefer_equal_for_default_values
     - prefer_final_fields
     - prefer_initializing_formals
     - prefer_interpolation_to_compose_strings

lib/src/builder.dart

@@ -35,9 +35,9 @@ class _Builder extends Builder {
   /// Wrap [_generators] to form a [Builder]-compatible API.
   _Builder(this._generators,
       {String formatOutput(String code),
-      String generatedExtension: '.g.dart',
-      List<String> additionalOutputExtensions: const [],
-      bool isStandalone: false,
+      String generatedExtension = '.g.dart',
+      List<String> additionalOutputExtensions = const [],
+      bool isStandalone = false,
       String header})
       : _generatedExtension = generatedExtension,
         buildExtensions = {
@@ -162,8 +162,8 @@ class PartBuilder extends _Builder {
   /// If [header] is an empty `String` no header is added.
   PartBuilder(List<Generator> generators,
       {String formatOutput(String code),
-      String generatedExtension: '.g.dart',
-      List<String> additionalOutputExtensions: const [],
+      String generatedExtension = '.g.dart',
+      List<String> additionalOutputExtensions = const [],
       String header})
       : super(generators,
             formatOutput: formatOutput,
@@ -189,8 +189,8 @@ class LibraryBuilder extends _Builder {
   /// If [header] is an empty `String` no header is added.
   LibraryBuilder(Generator generator,
       {String formatOutput(String code),
-      String generatedExtension: '.g.dart',
-      List<String> additionalOutputExtensions: const [],
+      String generatedExtension = '.g.dart',
+      List<String> additionalOutputExtensions = const [],
       String header})
       : super([generator],
             formatOutput: formatOutput,

lib/src/constants/revive.dart

@@ -104,9 +104,9 @@ class Revivable {
 
   const Revivable._({
     this.source,
-    this.accessor: '',
-    this.positionalArguments: const [],
-    this.namedArguments: const {},
+    this.accessor = '',
+    this.positionalArguments = const [],
+    this.namedArguments = const {},
   });
 
   /// Whether this instance is visible outside the same library.

test/src/comment_generator.dart

@@ -11,7 +11,7 @@ import 'package:source_gen/source_gen.dart';
 class CommentGenerator extends Generator {
   final bool forClasses, forLibrary;
 
-  const CommentGenerator({this.forClasses: true, this.forLibrary: false});
+  const CommentGenerator({this.forClasses = true, this.forLibrary = false});
 
   @override
   Future<String> generate(LibraryReader library, _) async {

test/test_files/annotations.dart

@@ -39,7 +39,7 @@ class PublicAnnotationClass {
         child2 = null;
 
   const PublicAnnotationClass.withPositionalArgs(int intArg, this.aString,
-      {bool boolArg: false, List listArg: const [2, 3, 4]})
+      {bool boolArg = false, List listArg = const [2, 3, 4]})
       : anInt = intArg,
         aList = listArg,
         aBool = boolArg,