InvalidSourceGenerationError should accept Fragments/Annotatable too.

[rrousselGit]

With latest analyzer, the concept of Element has been split in two. We now have "Fragments". The problem is, InvalidSourceGenerationError does not accept this new kind of object.

Annotatable has the same issue, since it's a base class for Fragment|Element|ElementDirective

If InvalidSourceGenerationError could accept those objects, then the error message would be more specific.

[davidmorgan]

Sounds good to me, thanks.

About to go on vacation for a week, but added it to the TODO list :)

[davidmorgan]

#774 seems to do most of what's needed.

For Annotatable, I can check for and handle Fragment and Element, but I'm not sure what to do with ElementDirective: I don't see a way to get to a source file + offset.

@scheglov any ideas please? I'm trying to extend source_gen support for reporting an error with source URL + offset to cover new types, not sure what to do with an ElementDirective.

[scheglov]

You can get the URI from ElementDirective.libraryFragment.

You can get offset from LibraryExport.exportKeywordOffset or LibraryImport.importKeywordOffset.
Hm... No offset for PartInclude. I will fix this.

[davidmorgan]

Thanks! I left a TODO for that case, the others look good.

[davidmorgan]

@scheglov I just noticed that in analyzer 8, Annotatable is deprecated

@Deprecated('Use Element or Fragment directly instead')
abstract class Annotatable {

so I'm now not sure about my change that accepted Annotatable and handled it as element/elementDirective/Fragment:

https://github.com/dart-lang/source_gen/pull/774/files#diff-e66a305cc81ae8b7c0bb04711f35378bdf8a381162171e5bdf74aa5ddf090922R63

is the Annotatable type going to go away / become private?

Perhaps it would be better then if I require the caller to explicitly pass Element/ElementDirective/Fragment, and don't release a version using Annotatable?

Thanks.

[scheglov]

Yes, I think it is better to have APIs that use Element, Fragment, and ElementDirective directly, without going down to Annotatable. Obviously, adding new APIs with now deprecated Annotatable will just add more work to clean this up later.

[davidmorgan]

Sounds good, done in #780