Skip to content

Commit 1937357

Browse files
committed
minor adjustments
1 parent 86a7341 commit 1937357

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

pkgs/test_core/CHANGELOG.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
## 0.6.16-wip
22

3-
* Fix default coverage reporting to include all collected coverage.
3+
- Fix coverage reporting to report all coverage when using JSON workflow.
44
* Add `SuiteConfiguration.suiteLoadTimeout` to configure the timeout for loading a test suite.
55
* Removed hard-coded timeout of 12m for loading a test suite and set default to `none`.
66

pkgs/test_core/lib/src/runner/vm/platform.dart

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -460,10 +460,10 @@ Future<Set<String>> _filterCoveragePackages(
460460
) async {
461461
if (coveragePackages == null || coveragePackages.isEmpty) {
462462
if (coverageLcov == null) {
463-
// If no filters were provided, report coverage for all packages.
464-
// This is required to maintain backward compatibility particularly
465-
// in cases where coverage is required for files outside of the lib directory.
466-
// See https://github.com/dart-lang/test/issues/2581
463+
// If no filters were provided and we using json workflow, report coverage
464+
// for all packages. This is required to maintain backward compatibility
465+
// particularly in cases where coverage is required for files outside of
466+
// the lib directory. See https://github.com/dart-lang/test/issues/2581
467467
return {};
468468
}
469469
return workspacePackageNames(await currentPackage);

0 commit comments

Comments
 (0)