Add support for CHROME_EXECUTABLE environment variable (#1883)

Closes #1862

Author: jakemac53

pkgs/test/CHANGELOG.md

@@ -1,7 +1,9 @@
-## 1.22.3-dev
+## 1.23.0-dev
 
 * Avoid empty expandable groups for tests without extra output in Github
   reporter.
+* Add support for CHROME_EXECUTABLE environment variable. This overrides any
+  config file settings.
 
 ## 1.22.2
 

pkgs/test/lib/src/runner/executable_settings.dart

@@ -36,6 +36,9 @@ class ExecutableSettings {
 
   /// The path to the executable for the current operating system.
   String get executable {
+    final envVariable = Platform.environment['CHROME_EXECUTABLE'];
+    if (envVariable != null) return envVariable;
+
     if (Platform.isMacOS) return _macOSExecutable!;
     if (!Platform.isWindows) return _linuxExecutable!;
     final windowsExecutable = _windowsExecutable!;

pkgs/test/pubspec.yaml

@@ -1,5 +1,5 @@
 name: test
-version: 1.22.3-dev
+version: 1.23.0-dev
 description: >-
   A full featured library for writing and running Dart tests across platforms.
 repository: https://github.com/dart-lang/test/tree/master/pkgs/test

pkgs/test/test/runner/browser/chrome_test.dart

@@ -82,4 +82,18 @@ void main() {
     expect(test.stdout, emitsThrough(contains('-1: Some tests failed.')));
     await test.shouldExit(1);
   });
+
+  test('can override chrome location with CHROME_EXECUTABLE var', () async {
+    await d.file('test.dart', '''
+import 'package:test/test.dart';
+
+void main() {
+  test("success", () {});
+}
+''').create();
+    var test = await runTest(['-p', 'chrome', 'test.dart'],
+        environment: {'CHROME_EXECUTABLE': '/some/bad/path'});
+    expect(test.stdout, emitsThrough(contains('Failed to run Chrome:')));
+    await test.shouldExit(1);
+  });
 }