Skip to content

Commit abe4939

Browse files
authored
Remove executable argument forwarding in tests (#2533)
Similar to #2528 This case of argument forwarding existed since the test runner was first written. It's not clear exactly why it was necessary, and it should be safe to remove. The existing argument forwarding breaks some tests on CI where an unexpected argument is passed to some dart invocations.
1 parent 81e0579 commit abe4939

File tree

1 file changed

+0
-4
lines changed

1 file changed

+0
-4
lines changed

pkgs/test/test/io.dart

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -142,10 +142,6 @@ Future<TestProcess> runDart(
142142
String? packageConfig,
143143
}) async {
144144
var allArgs = <String>[
145-
...Platform.executableArguments.where(
146-
(arg) =>
147-
!arg.startsWith('--package-root=') && !arg.startsWith('--packages='),
148-
),
149145
'--packages=${packageConfig ?? await Isolate.packageConfig}',
150146
...args,
151147
];

0 commit comments

Comments
 (0)