Update and fix latest lints, bump min SDK to 3.1 (dart-archive/stream_transform#178)

kevmoo · web-flow · commit 3d8fb7f60052 · 2023-11-29T10:23:05.000-08:00
diff --git a/pkgs/stream_transform/.github/workflows/test-package.yml b/pkgs/stream_transform/.github/workflows/test-package.yml
@@ -47,8 +47,8 @@ jobs:
       matrix:
         # Add macos-latest and/or windows-latest if relevant for this package.
         os: [ubuntu-latest]
-        # Bump SDK for Legacy tets when changning min SDK.
-        sdk: [2.18.0, dev]
+        # Bump SDK for Legacy tests when changing min SDK.
+        sdk: [3.1, dev]
     steps:
       - uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11
       - uses: dart-lang/setup-dart@b64355ae6ca0b5d484f0106a033dd1388965d06d
diff --git a/pkgs/stream_transform/CHANGELOG.md b/pkgs/stream_transform/CHANGELOG.md
@@ -1,6 +1,6 @@
-## 2.1.1-dev
+## 2.1.1-wip
 
-- Require Dart 2.18 or greater
+- Require Dart 3.1 or greater
 - Forward errors from the `trigger` future through to the result stream in
   `takeUntil`. Previously an error would have not closed the stream, and instead
   raised as an unhandled async error.
diff --git a/pkgs/stream_transform/analysis_options.yaml b/pkgs/stream_transform/analysis_options.yaml
@@ -1,4 +1,4 @@
-include: package:lints/recommended.yaml
+include: package:dart_flutter_team_lints/analysis_options.yaml
 
 analyzer:
   language:
@@ -7,24 +7,10 @@ analyzer:
 
 linter:
   rules:
-    - always_declare_return_types
     - avoid_bool_literals_in_conditional_expressions
     - avoid_classes_with_only_static_members
-    - avoid_returning_null
     - avoid_returning_this
     - avoid_unused_constructor_parameters
     - cascade_invocations
-    - comment_references
-    - directives_ordering
     - join_return_with_assignment
     - no_adjacent_strings_in_list
-    - omit_local_variable_types
-    - only_throw_errors
-    - prefer_const_constructors
-    - prefer_single_quotes
-    - test_types_in_equals
-    - throw_in_finally
-    - unawaited_futures
-    - unnecessary_lambdas
-    - unnecessary_parenthesis
-    - unnecessary_statements
diff --git a/pkgs/stream_transform/lib/src/async_map.dart b/pkgs/stream_transform/lib/src/async_map.dart
@@ -59,8 +59,8 @@ extension AsyncMap<T> on Stream<T> {
   /// pending event.
   ///
   /// Errors from this stream are forwarded directly to the result stream.
-  /// Errors during the conversion are also forwarded to the result stream and are
-  /// considered completing work so the next values are let through.
+  /// Errors during the conversion are also forwarded to the result stream and
+  /// are considered completing work so the next values are let through.
   ///
   /// The result stream will not close until this stream closes and all pending
   /// conversions have finished.
@@ -72,7 +72,7 @@ extension AsyncMap<T> on Stream<T> {
             trigger: workFinished.stream,
             aggregate: _dropPrevious,
             longPoll: true,
-            onEmpty: _ignore)
+            onEmpty: _ignore<T>)
         ._asyncMapThen(convert, workFinished.add);
   }
 
diff --git a/pkgs/stream_transform/lib/src/combine_latest.dart b/pkgs/stream_transform/lib/src/combine_latest.dart
@@ -152,11 +152,11 @@ extension CombineLatest<T> on Stream<T> {
   /// at least once, the result stream will emit any time any source stream
   /// emits.
   ///
-  /// The result stream will not close until all source streams have closed. When
-  /// a source stream closes, the result stream will continue to emit the last
-  /// value from the closed stream when the other source streams emit until the
-  /// result stream has closed. If a source stream closes without emitting any
-  /// value, the result stream will close as well.
+  /// The result stream will not close until all source streams have closed.
+  /// When a source stream closes, the result stream will continue to emit the
+  /// last value from the closed stream when the other source streams emit until
+  /// the result stream has closed. If a source stream closes without emitting
+  /// any value, the result stream will close as well.
   ///
   /// For example:
   ///
diff --git a/pkgs/stream_transform/lib/src/switch.dart b/pkgs/stream_transform/lib/src/switch.dart
@@ -19,7 +19,8 @@ extension Switch<T> on Stream<T> {
   ///
   /// This means that the source stream is not paused until a sub stream
   /// returned from the [convert] callback is done. Instead, the subscription
-  /// to the sub stream is canceled as soon as the source stream emits a new event.
+  /// to the sub stream is canceled as soon as the source stream emits a new
+  /// event.
   ///
   /// Errors from [convert], the source stream, or any of the sub streams are
   /// forwarded to the result stream.
@@ -36,7 +37,8 @@ extension Switch<T> on Stream<T> {
   ///
   /// See also:
   /// - [concurrentAsyncExpand], which emits events from all sub streams
-  ///   concurrently instead of cancelling subscriptions to previous subs streams.
+  ///   concurrently instead of cancelling subscriptions to previous subs
+  ///   streams.
   Stream<S> switchMap<S>(Stream<S> Function(T) convert) {
     return map(convert).switchLatest();
   }
diff --git a/pkgs/stream_transform/lib/src/where.dart b/pkgs/stream_transform/lib/src/where.dart
@@ -28,10 +28,10 @@ extension Where<T> on Stream<T> {
   /// Events on the result stream will be emitted in the order that [test]
   /// completes which may not match the order of this stream.
   ///
-  /// If the source stream is a broadcast stream the result will be as well. When
-  /// used with a broadcast stream behavior also differs from [where] in that
-  /// the [test] function is only called once per event, rather than once per
-  /// listener per event.
+  /// If the source stream is a broadcast stream the result will be as well.
+  /// When used with a broadcast stream behavior also differs from [where] in
+  /// that the [test] function is only called once per event, rather than once
+  /// per listener per event.
   ///
   /// Errors from the source stream are forwarded directly to the result stream.
   /// Errors from [test] are also forwarded to the result stream.
diff --git a/pkgs/stream_transform/pubspec.yaml b/pkgs/stream_transform/pubspec.yaml
@@ -1,13 +1,13 @@
 name: stream_transform
-version: 2.1.1-dev
+version: 2.1.1-wip
 description: A collection of utilities to transform and manipulate streams.
 repository: https://github.com/dart-lang/stream_transform
 
 environment:
-  sdk: ">=2.18.0 <3.0.0"
+  sdk: ^3.1.0
 
 dev_dependencies:
   async: ^2.5.0
+  dart_flutter_team_lints: ^2.0.0
   fake_async: ^1.3.0
-  lints: ^2.0.0
   test: ^1.16.0
diff --git a/pkgs/stream_transform/test/async_expand_test.dart b/pkgs/stream_transform/test/async_expand_test.dart
@@ -13,7 +13,7 @@ void main() {
   test('forwards errors from the convert callback', () async {
     var errors = <String>[];
     var source = Stream.fromIterable([1, 2, 3]);
-    source.concurrentAsyncExpand((i) {
+    source.concurrentAsyncExpand<void>((i) {
       // ignore: only_throw_errors
       throw 'Error: $i';
     }).listen((_) {}, onError: errors.add);
diff --git a/pkgs/stream_transform/test/async_map_buffer_test.dart b/pkgs/stream_transform/test/async_map_buffer_test.dart
@@ -158,7 +158,7 @@ void main() {
 
       if (streamType == 'broadcast') {
         test('multiple listeners all get values', () async {
-          var otherValues = [];
+          var otherValues = <String>[];
           transformed.listen(otherValues.add);
           values.add(1);
           await Future(() {});
diff --git a/pkgs/stream_transform/test/async_map_sample_test.dart b/pkgs/stream_transform/test/async_map_sample_test.dart
@@ -158,7 +158,7 @@ void main() {
 
       if (streamType == 'broadcast') {
         test('multiple listeners all get values', () async {
-          var otherValues = [];
+          var otherValues = <String>[];
           transformed.listen(otherValues.add);
           values.add(1);
           await Future(() {});
@@ -204,6 +204,6 @@ void main() {
 
   test('allows nulls', () async {
     var stream = Stream<int?>.value(null);
-    await stream.asyncMapSample(expectAsync1((_) async {})).drain();
+    await stream.asyncMapSample(expectAsync1((_) async {})).drain<void>();
   });
 }
diff --git a/pkgs/stream_transform/test/async_where_test.dart b/pkgs/stream_transform/test/async_where_test.dart
@@ -37,8 +37,8 @@ void main() {
   test('forwards values to multiple listeners', () async {
     var values = StreamController<int>.broadcast();
     var filtered = values.stream.asyncWhere((e) async => e > 2);
-    var firstValues = [];
-    var secondValues = [];
+    var firstValues = <int>[];
+    var secondValues = <int>[];
     filtered
       ..listen(firstValues.add)
       ..listen(secondValues.add);
@@ -53,7 +53,7 @@ void main() {
   });
 
   test('closes streams with multiple listeners', () async {
-    var values = StreamController.broadcast();
+    var values = StreamController<int>.broadcast();
     var predicate = Completer<bool>();
     var filtered = values.stream.asyncWhere((_) => predicate.future);
     var firstDone = false;
@@ -73,15 +73,15 @@ void main() {
   });
 
   test('forwards errors emitted by the test callback', () async {
-    var errors = [];
-    var emitted = [];
+    var errors = <Object>[];
+    var emitted = <Object>[];
     var values = Stream.fromIterable([1, 2, 3, 4]);
     var filtered = values.asyncWhere((e) async {
       await Future(() {});
       if (e.isEven) throw Exception('$e');
       return true;
     });
-    var done = Completer();
+    var done = Completer<Object?>();
     filtered.listen(emitted.add, onError: errors.add, onDone: done.complete);
     await done.future;
     expect(emitted, [1, 3]);
diff --git a/pkgs/stream_transform/test/audit_test.dart b/pkgs/stream_transform/test/audit_test.dart
@@ -119,7 +119,7 @@ void main() {
               values.add(1);
               async.elapse(const Duration(milliseconds: 3));
               values.add(2);
-              var otherValues = [];
+              var otherValues = <int>[];
               transformed.listen(otherValues.add);
               values.add(3);
               async.elapse(const Duration(milliseconds: 3));
diff --git a/pkgs/stream_transform/test/buffer_test.dart b/pkgs/stream_transform/test/buffer_test.dart
@@ -228,7 +228,7 @@ void main() {
           test('emits empty list before values', () async {
             trigger.add(null);
             await Future(() {});
-            expect(emittedValues, [[]]);
+            expect(emittedValues, [<int>[]]);
           });
 
           test('emits empty list after emitting values', () async {
@@ -242,7 +242,7 @@ void main() {
             await Future(() {});
             expect(emittedValues, [
               [1, 2],
-              []
+              <int>[]
             ]);
           });
         });
diff --git a/pkgs/stream_transform/test/combine_latest_test.dart b/pkgs/stream_transform/test/combine_latest_test.dart
@@ -127,7 +127,7 @@ void main() {
       var other = StreamController<int>();
       int sum(int a, int b) => throw _NumberedException(3);
 
-      var errors = [];
+      var errors = <Object>[];
       source.stream
           .combineLatest(other.stream, sum)
           .listen(null, onError: errors.add);
diff --git a/pkgs/stream_transform/test/concurrent_async_map_test.dart b/pkgs/stream_transform/test/concurrent_async_map_test.dart
@@ -111,7 +111,7 @@ void main() {
 
       if (streamType == 'broadcast') {
         test('multiple listeners all get values', () async {
-          var otherValues = [];
+          var otherValues = <String>[];
           transformed.listen(otherValues.add);
           controller.add(1);
           await Future(() {});
diff --git a/pkgs/stream_transform/test/debounce_test.dart b/pkgs/stream_transform/test/debounce_test.dart
@@ -100,7 +100,7 @@ void main() {
           test('multiple listeners all get values', () {
             fakeAsync((async) {
               listen();
-              var otherValues = [];
+              var otherValues = <int>[];
               transformed.listen(otherValues.add);
               values
                 ..add(1)
@@ -157,7 +157,7 @@ void main() {
           test('multiple listeners all get values', () {
             fakeAsync((async) {
               listen();
-              var otherValues = [];
+              var otherValues = <int>[];
               transformed.listen(otherValues.add);
               values
                 ..add(1)
@@ -221,7 +221,7 @@ void main() {
           test('multiple listeners all get values', () {
             fakeAsync((async) {
               listen();
-              var otherValues = [];
+              var otherValues = <int>[];
               transformed.listen(otherValues.add);
               values
                 ..add(1)
@@ -284,7 +284,7 @@ void main() {
           test('multiple listeners all get values', () {
             fakeAsync((async) {
               listen();
-              var otherValues = [];
+              var otherValues = <List<int>>[];
               transformed.listen(otherValues.add);
               values
                 ..add(1)
diff --git a/pkgs/stream_transform/test/followd_by_test.dart b/pkgs/stream_transform/test/followd_by_test.dart
@@ -138,13 +138,13 @@ void main() {
           });
 
           test('forwards values to multiple listeners', () async {
-            var otherValues = [];
+            var otherValues = <int>[];
             transformed.listen(otherValues.add);
             first.add(1);
             await first.close();
             second.add(2);
             await Future(() {});
-            var thirdValues = [];
+            var thirdValues = <int>[];
             transformed.listen(thirdValues.add);
             second.add(3);
             await Future(() {});
diff --git a/pkgs/stream_transform/test/merge_test.dart b/pkgs/stream_transform/test/merge_test.dart
@@ -20,12 +20,12 @@ void main() {
 
     test('cancels both sources', () async {
       var firstCanceled = false;
-      var first = StreamController()
+      var first = StreamController<int>()
         ..onCancel = () {
           firstCanceled = true;
         };
       var secondCanceled = false;
-      var second = StreamController()
+      var second = StreamController<int>()
         ..onCancel = () {
           secondCanceled = true;
         };
@@ -36,8 +36,8 @@ void main() {
     });
 
     test('completes when both sources complete', () async {
-      var first = StreamController();
-      var second = StreamController();
+      var first = StreamController<int>();
+      var second = StreamController<int>();
       var isDone = false;
       first.stream.merge(second.stream).listen((_) {}, onDone: () {
         isDone = true;
@@ -49,9 +49,9 @@ void main() {
     });
 
     test('can cancel and relisten to broadcast stream', () async {
-      var first = StreamController.broadcast();
-      var second = StreamController();
-      var emittedValues = [];
+      var first = StreamController<int>.broadcast();
+      var second = StreamController<int>();
+      var emittedValues = <int>[];
       var transformed = first.stream.merge(second.stream);
       var subscription = transformed.listen(emittedValues.add);
       first.add(1);
@@ -84,26 +84,26 @@ void main() {
 
     test('handles mix of broadcast and single-subscription', () async {
       var firstCanceled = false;
-      var first = StreamController.broadcast()
+      var first = StreamController<int>.broadcast()
         ..onCancel = () {
           firstCanceled = true;
         };
       var secondBroadcastCanceled = false;
-      var secondBroadcast = StreamController.broadcast()
+      var secondBroadcast = StreamController<int>.broadcast()
         ..onCancel = () {
           secondBroadcastCanceled = true;
         };
       var secondSingleCanceled = false;
-      var secondSingle = StreamController()
+      var secondSingle = StreamController<int>()
         ..onCancel = () {
           secondSingleCanceled = true;
         };
 
       var merged =
           first.stream.mergeAll([secondBroadcast.stream, secondSingle.stream]);
 
-      var firstListenerValues = [];
-      var secondListenerValues = [];
+      var firstListenerValues = <int>[];
+      var secondListenerValues = <int>[];
 
       var firstSubscription = merged.listen(firstListenerValues.add);
       var secondSubscription = merged.listen(secondListenerValues.add);
diff --git a/pkgs/stream_transform/test/scan_test.dart b/pkgs/stream_transform/test/scan_test.dart
diff --git a/pkgs/stream_transform/test/switch_test.dart b/pkgs/stream_transform/test/switch_test.dart
diff --git a/pkgs/stream_transform/test/take_until_test.dart b/pkgs/stream_transform/test/take_until_test.dart
diff --git a/pkgs/stream_transform/test/tap_test.dart b/pkgs/stream_transform/test/tap_test.dart
diff --git a/pkgs/stream_transform/test/where_not_null_test.dart b/pkgs/stream_transform/test/where_not_null_test.dart
diff --git a/pkgs/stream_transform/test/where_type_test.dart b/pkgs/stream_transform/test/where_type_test.dart
