More migration

Author: bkonyi

_analysis_config/lib/analysis_options.yaml

@@ -5,8 +5,8 @@
 include: package:dart_flutter_team_lints/analysis_options.yaml
 
 analyzer:
-  #  language:
-  #    strict-casts: true
+  language:
+    strict-casts: true
   errors:
     dead_code: error
     unused_element: error
@@ -15,27 +15,18 @@ analyzer:
 
 linter:
   rules:
-    - always_declare_return_types
     - avoid_classes_with_only_static_members
     - avoid_returning_this
     - avoid_unused_constructor_parameters
     - avoid_void_async
     - cancel_subscriptions
-    - directives_ordering
     - join_return_with_assignment
     - library_names
     - literal_only_boolean_expressions
-    - omit_local_variable_types
-    - only_throw_errors
     - package_prefixed_library_names
     - prefer_final_in_for_each
     - prefer_final_locals
-    - prefer_single_quotes
-    # - prefer_relative_imports
     - prefer_void_to_null
-    - test_types_in_equals
-    - throw_in_finally
-    - unawaited_futures
     - unnecessary_lambdas
     - unnecessary_parenthesis
     - unnecessary_statements
@@ -55,7 +46,7 @@ dart_code_metrics:
     - avoid-collection-methods-with-unrelated-types
     # - avoid-double-slash-imports
     - avoid-duplicate-exports
-    # - avoid-Object?
+    # - avoid-dynamic
     # - avoid-global-state # Enable.
     # - avoid-ignoring-return-values
     # - avoid-late-keyword

dwds/debug_extension/web/background.dart

@@ -66,7 +66,7 @@ Future<void> _handleRuntimeMessages(
   Function sendResponse,
 ) async {
   if (jsRequest is! String) return;
-
+  if (sendResponse is! void Function(Object?)) return;
   interceptMessage<String>(
     message: jsRequest,
     expectedType: MessageType.isAuthenticated,

dwds/debug_extension/web/debug_session.dart

@@ -278,7 +278,9 @@ Future<void> _onDebuggerEvent(
 }
 
 Future<void> _maybeConnectToDwds(int tabId, Object? params) async {
-  final context = json.decode(JSON.stringify(params))['context'];
+  final context =
+      (json.decode(JSON.stringify(params)) as Map<String, Object?>)['context']!
+          as Map<String, Object?>;
   final contextOrigin = context['origin'] as String?;
   if (contextOrigin == null) return;
   if (contextOrigin.contains('chrome-extension:')) return;

dwds/debug_extension/web/messaging.dart

@@ -24,7 +24,7 @@ import 'utils.dart';
 //
 // Prevents the message port from closing. See:
 // https://developer.chrome.com/docs/extensions/mv3/messaging/#simple
-final defaultResponse = jsify({'response': 'received'});
+final defaultResponse = jsify({'response': 'received'}) as Map<String, Object?>;
 
 enum Script {
   background,

dwds/lib/dart_web_debug_service.dart

@@ -146,8 +146,9 @@ class Dwds {
       debugSettings.expressionCompiler,
       injected,
       DartDevelopmentServiceConfiguration(
-        // This technically isn't correct, but DartDevelopmentServiceConfiguration.enable
-        // is true by default, so this won't break unmigrated tools.
+        // This technically isn't correct, but
+        // DartDevelopmentServiceConfiguration.enable is true by default, so
+        // this won't break unmigrated tools.
         // ignore: deprecated_member_use_from_same_package
         enable: debugSettings.spawnDds && debugSettings.ddsConfiguration.enable,
         // ignore: deprecated_member_use_from_same_package

dwds/lib/src/debugging/chrome_inspector.dart

@@ -165,7 +165,8 @@ class ChromeAppInspector extends AppInspector {
     if (namedArgs.isNotEmpty) {
       throw UnsupportedError('Named arguments are not yet supported');
     }
-    // We use the JS pseudo-variable 'arguments' to get the list of all arguments.
+    // We use the JS pseudo-variable 'arguments' to get the list of all
+    // arguments.
     final send = globalToolConfiguration.loadStrategy.dartRuntimeDebugger
         .callInstanceMethodJsExpression(methodName);
     final remote = await jsCallFunctionOn(receiver, send, positionalArgs);

dwds/lib/src/debugging/dart_runtime_debugger.dart

@@ -107,7 +107,8 @@ class DartRuntimeDebugger {
   /// Generates a JS expression for retrieving Dart Developer Extension Names.
   String getDartDeveloperExtensionNamesJsExpression() {
     return _generateJsExpression(
-      "${_loadStrategy.loadModuleSnippet}('dart_sdk').developer._extensions.keys.toList();",
+      "${_loadStrategy.loadModuleSnippet}('dart_sdk')'"
+          '.developer._extensions.keys.toList();"',
       'dartDevEmbedder.debugger.extensionNames',
     );
   }
@@ -180,19 +181,24 @@ class DartRuntimeDebugger {
 
     return _generateJsExpression(
       generateInstanceMethodJsExpression(
-        '${_loadStrategy.loadModuleSnippet}("dart_sdk").dart.dsendRepl(this, "$methodName", arguments)',
+        '${_loadStrategy.loadModuleSnippet}("dart_sdk").dart.dsendRepl(this, '
+        '"$methodName", arguments)',
       ),
       generateInstanceMethodJsExpression(
-        'dartDevEmbedder.debugger.callInstanceMethod(this, "$methodName", arguments)',
+        'dartDevEmbedder.debugger.callInstanceMethod(this, "$methodName", '
+        'arguments)',
       ),
     );
   }
 
   /// Generates a JS expression to invoke a Dart extension method.
   String invokeExtensionJsExpression(String methodName, String encodedJson) {
     return _generateJsExpression(
-      "${_loadStrategy.loadModuleSnippet}('dart_sdk').developer.invokeExtension('$methodName', JSON.stringify($encodedJson));",
-      "dartDevEmbedder.debugger.invokeExtension('$methodName', JSON.stringify($encodedJson));",
+      "${_loadStrategy.loadModuleSnippet}('dart_sdk')"
+          ".developer.invokeExtension('$methodName',"
+          'JSON.stringify($encodedJson));',
+      "dartDevEmbedder.debugger.invokeExtension('$methodName',"
+          'JSON.stringify($encodedJson));',
     );
   }
 
@@ -209,14 +215,15 @@ class DartRuntimeDebugger {
      })();
      ''';
 
-    // `callLibraryMethod` expects an array of arguments. Chrome DevTools spreads
-    // arguments individually when calling functions. This code reconstructs the
-    // expected argument array.
+    // `callLibraryMethod` expects an array of arguments. Chrome DevTools
+    // spreads arguments individually when calling functions. This code
+    // reconstructs the expected argument array.
     return _generateJsExpression(
       findLibraryExpression,
       _wrapWithBundleLoader(
         '',
-        'callLibraryMethod("$libraryUri", "$methodName", Array.from(arguments))',
+        'callLibraryMethod("$libraryUri", "$methodName", '
+            'Array.from(arguments))',
       ),
     );
   }

dwds/lib/src/debugging/debugger.dart

@@ -424,6 +424,7 @@ class Debugger {
   // void _showPausedOverlay() async {
   //   if (_pausedOverlayVisible) return;
   //   handleErrorIfPresent(await _remoteDebugger?.sendCommand('DOM.enable'));
+  // ignore: lines_longer_than_80_chars
   //   handleErrorIfPresent(await _remoteDebugger?.sendCommand('Overlay.enable'));
   //   handleErrorIfPresent(await _remoteDebugger
   //       ?.sendCommand('Overlay.setPausedInDebuggerMessage', params: {
@@ -435,6 +436,7 @@ class Debugger {
   // Removes the paused at breakpoint overlay from the application.
   // void _hidePausedOverlay() async {
   //   if (!_pausedOverlayVisible) return;
+  // ignore: lines_longer_than_80_chars
   //   handleErrorIfPresent(await _remoteDebugger?.sendCommand('Overlay.disable'));
   //   _pausedOverlayVisible = false;
   // }
@@ -500,7 +502,8 @@ class Debugger {
   void logAnyFrameErrors({required String frameType}) {
     if (_frameErrorCount > 0) {
       logger.warning(
-        'Error calculating Dart variables for $_frameErrorCount $frameType frames.',
+        'Error calculating Dart variables for $_frameErrorCount $frameType '
+        'frames.',
       );
     }
     _frameErrorCount = 0;

dwds/lib/src/debugging/execution_context.dart

@@ -89,9 +89,9 @@ class RemoteDebuggerExecutionContext extends ExecutionContext {
     _remoteDebugger
         .eventStream('Runtime.executionContextCreated', (e) {
           // Parse and add the context ID to the stream.
-          // If we cannot detect or parse the context ID, add `null` to the stream
-          // to indicate an error context - those will be skipped when trying to find
-          // the dart context, with a warning.
+          // If we cannot detect or parse the context ID, add `null` to the
+          // stream to indicate an error context - those will be skipped when
+          // trying to find the dart context, with a warning.
           final id = (e.params?['context'] as Map<String, Object?>?)?['id']
               ?.toString();
           final parsedId = id == null ? null : int.parse(id);

dwds/lib/src/debugging/frame_computer.dart

@@ -113,7 +113,7 @@ class FrameComputer {
               'url': callFrame.url,
               'functionName': callFrame.functionName,
               'location': location.json,
-              'scopeChain': [],
+              'scopeChain': <Map<String, Object?>>[],
             });
 
             final frame = await debugger.calculateDartFrameFor(