Skip to content

Commit 35225b0

Browse files
committed
[dwds] Remove reassemble extension invocation for restarter
#2584 This can and should be done in Flutter tools.
1 parent 616da45 commit 35225b0

File tree

2 files changed

+0
-43
lines changed

2 files changed

+0
-43
lines changed

dwds/lib/src/injected/client.js

Lines changed: 0 additions & 32 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dwds/web/reloader/ddc_library_bundle_restarter.dart

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -34,13 +34,6 @@ extension type _Debugger._(JSObject _) implements JSObject {
3434
await invokeExtension(method, '{}').toDart;
3535
}
3636
}
37-
38-
Future<void> maybeInvokeFlutterReassemble() async {
39-
final method = 'ext.flutter.reassemble';
40-
if (extensionNames.toDart.contains(method.toJS)) {
41-
await invokeExtension(method, '{}').toDart;
42-
}
43-
}
4437
}
4538

4639
@JS('XMLHttpRequest')
@@ -105,9 +98,5 @@ class DdcLibraryBundleRestarter implements Restarter {
10598
}
10699
}
107100
await _dartDevEmbedder.hotReload(filesToLoad, librariesToReload).toDart;
108-
// TODO(srujzs): Reassembling is slow. It's roughly almost the time it takes
109-
// to recompile and do a hot reload. We should do some better profiling and
110-
// see if we can improve this.
111-
await _dartDevEmbedder.debugger.maybeInvokeFlutterReassemble();
112101
}
113102
}

0 commit comments

Comments
 (0)