Skip to content

Commit 3743cd3

Browse files
committed
Use 'compile js-dev' instead of invoking DDC directly using knowledge of the Dart sdk internals.
1 parent 9430dd7 commit 3743cd3

File tree

5 files changed

+7
-6
lines changed

5 files changed

+7
-6
lines changed

dwds/CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
## 24.3.3-wip
22
- Added support for some debugging APIs with the DDC library bundle format. - [#2563](https://github.com/dart-lang/webdev/issues/2563)
33
- Update `DCM` version to `1.26.0-1`
4+
- Use 'compile js-dev' for compilation instead of invoking DDC directly using knowledge of internals of the dart sdk
45

56
## 24.3.2
67

dwds/pubspec.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ description: >-
66
service protocol.
77
repository: https://github.com/dart-lang/webdev/tree/main/dwds
88
environment:
9-
sdk: ^3.4.0
9+
sdk: ^3.8.0-edge
1010

1111
dependencies:
1212
async: ^2.9.0

dwds/test/expression_compiler_service_common.dart

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -52,8 +52,6 @@ void testAll({required CompilerOptions compilerOptions}) {
5252
// generated in the SDK, so we use the current SDK layout and
5353
// configuration.
5454
final executable = Platform.resolvedExecutable;
55-
final dartdevc =
56-
SdkConfiguration.defaultConfiguration.compilerWorkerPath!;
5755
// redirect logs for testing
5856
_output = StreamController<String>.broadcast();
5957
output.stream.listen(printOnFailure);
@@ -110,7 +108,8 @@ void testAll({required CompilerOptions compilerOptions}) {
110108
''');
111109

112110
final args = [
113-
dartdevc,
111+
'compile',
112+
'js-dev',
114113
'try.dart',
115114
'-o',
116115
'try.js',

test_common/lib/sdk_asset_generator.dart

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -112,7 +112,8 @@ class SdkAssetGenerator {
112112

113113
final sdkDirectoryUri = fileSystem.directory(sdkLayout.sdkDirectory).uri;
114114
final args = <String>[
115-
sdkLayout.dartdevcSnapshotPath,
115+
'compile',
116+
'js-dev',
116117
'--compile-sdk',
117118
'--multi-root',
118119
'$sdkDirectoryUri',

test_common/pubspec.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ publish_to: none
33
description: >-
44
Common test functionality.
55
environment:
6-
sdk: ^3.1.0
6+
sdk: ^3.8.0-edge
77

88
dependencies:
99
dwds: any

0 commit comments

Comments
 (0)