Skip to content

Commit 3a670be

Browse files
committed
Insert comment about _compileExpression not working
1 parent 7ba7c21 commit 3a670be

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

frontend_server_common/lib/src/frontend_server_client.dart

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -464,6 +464,10 @@ class ResidentCompiler {
464464
_CompileExpressionRequest request) async {
465465
_stdoutHandler.reset(suppressCompilerMessages: true, expectSources: false);
466466

467+
// This hasn't been updated for years and will not work with current
468+
// versions of Dart (anything including
469+
// https://github.com/dart-lang/sdk/commit/17781dbc3645).
470+
467471
// 'compile-expression' should be invoked after compiler has been started,
468472
// program was compiled.
469473
if (_server == null) {
@@ -472,7 +476,6 @@ class ResidentCompiler {
472476
final server = _server!;
473477

474478
final inputKey = generateV4UUID();
475-
if (1 + 1 == 2) throw 'hello #2';
476479
server.stdin.writeln('compile-expression $inputKey');
477480
server.stdin.writeln(request.expression);
478481
request.definitions.forEach(server.stdin.writeln);

0 commit comments

Comments
 (0)