Skip to content

Commit 6849d64

Browse files
committed
Wait for breakpoints to be removed and added using events and restore timeout factor
1 parent c8390cf commit 6849d64

File tree

2 files changed

+20
-3
lines changed

2 files changed

+20
-3
lines changed

dwds/test/hot_reload_breakpoints_test.dart

Lines changed: 13 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -98,17 +98,28 @@ void main() {
9898
isolateId,
9999
scriptRef,
100100
);
101-
return await client.addBreakpointWithScriptUri(
101+
final breakpointAdded = expectLater(
102+
stream,
103+
emitsThrough(_hasKind(EventKind.kBreakpointAdded)),
104+
);
105+
final breakpoint = await client.addBreakpointWithScriptUri(
102106
isolateId,
103107
scriptRef.uri!,
104108
bpLine,
105109
);
110+
await breakpointAdded;
111+
return breakpoint;
106112
}
107113

108114
Future<void> removeBreakpoint(Breakpoint bp) async {
109115
final vm = await client.getVM();
110116
final isolateId = vm.isolates!.first.id!;
117+
final breakpointRemoved = expectLater(
118+
stream,
119+
emitsThrough(_hasKind(EventKind.kBreakpointRemoved)),
120+
);
111121
await client.removeBreakpoint(isolateId, bp.id!);
122+
await breakpointRemoved;
112123
}
113124

114125
Future<void> resume() async {
@@ -387,7 +398,7 @@ void main() {
387398
// the old string still as the closure has not been reevaluated.
388399
await callEvaluateAndExpectLog(oldCapturedString);
389400
});
390-
}, timeout: Timeout.factor(3));
401+
}, timeout: Timeout.factor(2));
391402

392403
group('when pause_isolates_on_start is false', () {
393404
late VmService client;

dwds/test/hot_restart_breakpoints_test.dart

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -110,11 +110,17 @@ void main() {
110110
isolateId,
111111
scriptRef,
112112
);
113-
return await client.addBreakpointWithScriptUri(
113+
final breakpointAdded = expectLater(
114+
stream,
115+
emitsThrough(_hasKind(EventKind.kBreakpointAdded)),
116+
);
117+
final breakpoint = await client.addBreakpointWithScriptUri(
114118
isolateId,
115119
scriptRef.uri!,
116120
bpLine,
117121
);
122+
await breakpointAdded;
123+
return breakpoint;
118124
}
119125

120126
Future<void> resume() async {

0 commit comments

Comments
 (0)