Skip to content

Commit 799ba87

Browse files
committed
skip running test if indexBaseMode == IndexBaseMode.base && Platform.isWindows
1 parent ef5f9ca commit 799ba87

File tree

1 file changed

+5
-4
lines changed

1 file changed

+5
-4
lines changed

dwds/test/frontend_server_ddc_and_canary_evaluate_test.dart

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@
77
@Timeout(Duration(minutes: 5))
88
library;
99

10+
import 'dart:io';
11+
1012
import 'package:dwds/expression_compiler.dart';
1113
import 'package:test/test.dart';
1214
import 'package:test_common/test_sdk_configuration.dart';
@@ -41,10 +43,9 @@ void main() async {
4143
debug: debug,
4244
);
4345
},
44-
// TODO(#2488): Restore the skip argument below, related to
45-
// https://github.com/dart-lang/sdk/issues/49277, once
46-
// https://github.com/dart-lang/webdev/issues/2488 is resolved.
47-
// skip: indexBaseMode == IndexBaseMode.base && Platform.isWindows,
46+
skip: indexBaseMode == IndexBaseMode.base && Platform.isWindows
47+
? 'Skipped on Windows when indexBaseMode is base. See issue: https://github.com/dart-lang/sdk/issues/49277'
48+
: null,
4849
);
4950
}
5051
});

0 commit comments

Comments
 (0)