Skip to content

Commit 9130d89

Browse files
committed
Adjust sdk layout.
1 parent d2e65fa commit 9130d89

File tree

4 files changed

+5
-19
lines changed

4 files changed

+5
-19
lines changed

dwds/lib/src/utilities/sdk_configuration.dart

Lines changed: 2 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,6 @@ class SdkLayout {
4545

4646
final String sdkDirectory;
4747
final String summaryPath;
48-
final String dartdevcJitSnapshotPath;
4948
final String dartdevcSnapshotPath;
5049

5150
@Deprecated('Only sound null safety is supported as of Dart 3.0')
@@ -63,17 +62,11 @@ class SdkLayout {
6362
'_internal',
6463
'ddc_outline.dill',
6564
),
66-
dartdevcJitSnapshotPath: p.join(
67-
sdkDirectory,
68-
'bin',
69-
'snapshots',
70-
'dartdevc.dart.snapshot',
71-
),
7265
dartdevcSnapshotPath: p.join(
7366
sdkDirectory,
7467
'bin',
7568
'snapshots',
76-
'dartdevc.aot.dart.snapshot',
69+
'dartdevc.dart.snapshot',
7770
),
7871
);
7972

@@ -82,7 +75,6 @@ class SdkLayout {
8275
required this.summaryPath,
8376
this.soundSummaryPath = '',
8477
this.weakSummaryPath = '',
85-
required this.dartdevcJitSnapshotPath,
8678
required this.dartdevcSnapshotPath,
8779
});
8880
}
@@ -121,10 +113,7 @@ class SdkConfiguration {
121113
: this(
122114
sdkDirectory: sdkLayout.sdkDirectory,
123115
sdkSummaryPath: sdkLayout.summaryPath,
124-
// This compiler path is used to spawn the expression compiler
125-
// in a new isolate and hence it needs to be a JIT snapshot
126-
// until dwds itself can run in AOT mode.
127-
compilerWorkerPath: sdkLayout.dartdevcJitSnapshotPath,
116+
compilerWorkerPath: sdkLayout.dartdevcSnapshotPath,
128117
);
129118

130119
static Uri? _toUri(String? path) => path == null ? null : p.toUri(path);

dwds/test/sdk_configuration_test.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,7 @@ void main() {
100100
final sdkLayout = SdkLayout.createDefault(sdkDirectory);
101101
final sdkConfiguration = SdkConfiguration.fromSdkLayout(sdkLayout);
102102
final sdkSummaryPath = sdkLayout.summaryPath;
103-
final compilerWorkerPath = sdkLayout.dartdevcJitSnapshotPath;
103+
final compilerWorkerPath = sdkLayout.dartdevcSnapshotPath;
104104

105105
setUp(() async {
106106
fs = MemoryFileSystem();

test_common/lib/test_sdk_layout.dart

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,6 @@ class TestSdkLayout {
103103
'snapshots',
104104
'frontend_server_aot.dart.snapshot',
105105
),
106-
dartdevcJitSnapshotPath: sdkLayout.dartdevcJitSnapshotPath,
107106
dartdevcSnapshotPath: sdkLayout.dartdevcSnapshotPath,
108107
kernelWorkerSnapshotPath: p.join(
109108
sdkLayout.sdkDirectory,
@@ -142,7 +141,6 @@ class TestSdkLayout {
142141
final String dartPath;
143142
final String dartAotRuntimePath;
144143
final String frontendServerSnapshotPath;
145-
final String dartdevcJitSnapshotPath;
146144
final String dartdevcSnapshotPath;
147145
final String kernelWorkerSnapshotPath;
148146
final String devToolsDirectory;
@@ -161,7 +159,6 @@ class TestSdkLayout {
161159
required this.dartPath,
162160
required this.dartAotRuntimePath,
163161
required this.frontendServerSnapshotPath,
164-
required this.dartdevcJitSnapshotPath,
165162
required this.dartdevcSnapshotPath,
166163
required this.kernelWorkerSnapshotPath,
167164
required this.devToolsDirectory,
@@ -172,7 +169,7 @@ class TestSdkLayout {
172169
SdkConfiguration(
173170
sdkDirectory: sdkLayout.sdkDirectory,
174171
sdkSummaryPath: sdkLayout.summaryPath,
175-
compilerWorkerPath: sdkLayout.dartdevcJitSnapshotPath,
172+
compilerWorkerPath: sdkLayout.dartdevcSnapshotPath,
176173
);
177174
}
178175

test_common/test/sdk_asset_generator_test.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ void main() {
3838
final copySdkLayout = TestSdkLayout.createDefault(sdkDirectory);
3939

4040
sdkSummaryPath = copySdkLayout.summaryPath;
41-
compilerWorkerPath = copySdkLayout.dartdevcJitSnapshotPath;
41+
compilerWorkerPath = copySdkLayout.dartdevcSnapshotPath;
4242

4343
// Copy the SDK directory into a temp directory.
4444
await copyDirectory(TestSdkLayout.defaultSdkDirectory, sdkDirectory);

0 commit comments

Comments
 (0)