Skip to content

Commit 9705c86

Browse files
committed
review comments
1 parent afe913e commit 9705c86

File tree

1 file changed

+7
-6
lines changed

1 file changed

+7
-6
lines changed

dwds/lib/src/debugging/debugger.dart

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -105,7 +105,7 @@ class Debugger extends Domain {
105105
// sent the event. To avoid that and still signal that a pause is completed,
106106
// this completer is used. See https://github.com/dart-lang/sdk/issues/61560
107107
// for more details.
108-
Completer<void>? _pauseInterruptedCompleter;
108+
Completer<void>? _internalPauseCompleter;
109109

110110
void updateInspector(AppInspectorInterface appInspector) {
111111
inspector = appInspector;
@@ -114,10 +114,10 @@ class Debugger extends Domain {
114114

115115
Future<Success> pause({bool internalPause = false}) async {
116116
_isStepping = false;
117-
if (internalPause) _pauseInterruptedCompleter = Completer<void>();
117+
if (internalPause) _internalPauseCompleter = Completer<void>();
118118
final result = await _remoteDebugger.pause();
119119
handleErrorIfPresent(result);
120-
await _pauseInterruptedCompleter?.future;
120+
await _internalPauseCompleter?.future;
121121
return Success();
122122
}
123123

@@ -645,10 +645,11 @@ class Debugger extends Domain {
645645
// DevTools is showing an overlay. Both cannot be shown at the same time.
646646
// _showPausedOverlay();
647647
isolate.pauseEvent = event;
648+
final internalPauseCompleter = _internalPauseCompleter;
648649
if (event.kind == EventKind.kPauseInterrupted &&
649-
_pauseInterruptedCompleter != null &&
650-
!_pauseInterruptedCompleter!.isCompleted) {
651-
_pauseInterruptedCompleter!.complete();
650+
internalPauseCompleter != null &&
651+
!internalPauseCompleter.isCompleted) {
652+
internalPauseCompleter.complete();
652653
} else {
653654
_streamNotify('Debug', event);
654655
}

0 commit comments

Comments
 (0)