Skip to content

Commit 9d3aefc

Browse files
nshahansrujzs
authored andcommitted
Remove skip from chrome proxy service test
Start running the "shared context Step Into goes to the next Dart location" test case now that it is passing again. Fixes: #2617
1 parent 13821dd commit 9d3aefc

File tree

1 file changed

+13
-20
lines changed

1 file changed

+13
-20
lines changed

dwds/test/common/chrome_proxy_service_common.dart

Lines changed: 13 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -1579,26 +1579,19 @@ void runTests({
15791579
await service.resume(isolateId!);
15801580
});
15811581

1582-
test(
1583-
'Into goes to the next Dart location',
1584-
() async {
1585-
await service.resume(isolateId!, step: 'Into');
1586-
// Wait for the step to actually occur.
1587-
await stream.firstWhere(
1588-
(event) => event.kind == EventKind.kPauseInterrupted,
1589-
);
1590-
final stack = await service.getStack(isolateId!);
1591-
expect(stack, isNotNull);
1592-
final first = stack.frames!.first;
1593-
expect(first.kind, 'Regular');
1594-
expect(first.code!.kind, 'Dart');
1595-
expect(first.code!.name, 'printCount');
1596-
},
1597-
skip:
1598-
moduleFormat == ModuleFormat.ddc && canaryFeatures
1599-
? 'https://github.com/dart-lang/webdev/issues/2617'
1600-
: null,
1601-
);
1582+
test('Into goes to the next Dart location', () async {
1583+
await service.resume(isolateId!, step: 'Into');
1584+
// Wait for the step to actually occur.
1585+
await stream.firstWhere(
1586+
(event) => event.kind == EventKind.kPauseInterrupted,
1587+
);
1588+
final stack = await service.getStack(isolateId!);
1589+
expect(stack, isNotNull);
1590+
final first = stack.frames!.first;
1591+
expect(first.kind, 'Regular');
1592+
expect(first.code!.kind, 'Dart');
1593+
expect(first.code!.name, 'printCount');
1594+
});
16021595

16031596
test('Over goes to the next Dart location', () async {
16041597
await service.resume(isolateId!, step: 'Over');

0 commit comments

Comments
 (0)