Skip to content

Commit a52e6c8

Browse files
committed
[DWDS] Make pause a no-op on WebSocketProxyService
We can't actually pause during execution so we shouldn't signal that we did.
1 parent 186bfe7 commit a52e6c8

File tree

4 files changed

+9
-18
lines changed

4 files changed

+9
-18
lines changed

dwds/CHANGELOG.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,8 @@
1+
## 26.1.0-wip
2+
3+
- `pause` now does not send a `PauseInterrupted` event in
4+
`WebSocketProxyService` as we didn't actually pause.
5+
16
## 26.0.0
27

38
- Bump SDK constraint to ^3.10.0

dwds/lib/src/services/web_socket_proxy_service.dart

Lines changed: 2 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -940,22 +940,8 @@ class WebSocketProxyService extends ProxyService {
940940
/// Pauses execution of the isolate.
941941
@override
942942
Future<Success> pause(String isolateId) =>
943-
wrapInErrorHandlerAsync('pause', () => _pause(isolateId));
944-
945-
Future<Success> _pause(String _) async {
946-
// Create a pause event and store it
947-
if (_isolateRef != null) {
948-
final pauseEvent = vm_service.Event(
949-
kind: vm_service.EventKind.kPauseInterrupted,
950-
timestamp: DateTime.now().millisecondsSinceEpoch,
951-
isolate: _isolateRef!,
952-
);
953-
_currentPauseEvent = pauseEvent;
954-
_streamNotify(vm_service.EventStreams.kDebug, pauseEvent);
955-
}
956-
957-
return Success();
958-
}
943+
// Can't pause with the web socket implementation, so do nothing.
944+
Future.value(Success());
959945

960946
/// Resumes execution of the isolate.
961947
@override

dwds/lib/src/version.dart

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dwds/pubspec.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
name: dwds
22
# Every time this changes you need to run `dart run build_runner build`.
3-
version: 26.0.0
3+
version: 26.1.0-wip
44

55
description: >-
66
A service that proxies between the Chrome debug protocol and the Dart VM

0 commit comments

Comments
 (0)