Skip to content

Commit ae4f862

Browse files
committed
updated Dwds with bool that only enableDebuggingSupport when set to true
1 parent 302b6db commit ae4f862

File tree

2 files changed

+23
-9
lines changed

2 files changed

+23
-9
lines changed

dwds/lib/dart_web_debug_service.dart

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,6 +66,7 @@ class Dwds {
6666
required Stream<BuildResult> buildResults,
6767
required ConnectionProvider chromeConnection,
6868
required ToolConfiguration toolConfiguration,
69+
bool enableDebuggingSupport = true,
6970
}) async {
7071
globalToolConfiguration = toolConfiguration;
7172
final debugSettings = toolConfiguration.debugSettings;
@@ -117,7 +118,10 @@ class Dwds {
117118
_logger.info('Serving DevTools at $uri\n');
118119
}
119120

120-
final injected = DwdsInjector(extensionUri: extensionUri);
121+
final injected = DwdsInjector(
122+
extensionUri: extensionUri,
123+
enableDebuggingSupport: enableDebuggingSupport,
124+
);
121125

122126
final devHandler = DevHandler(
123127
chromeConnection,

dwds/lib/src/handlers/injector.dart

Lines changed: 18 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -32,8 +32,14 @@ class DwdsInjector {
3232
final Future<String>? _extensionUri;
3333
final _devHandlerPaths = StreamController<String>();
3434
final _logger = Logger('DwdsInjector');
35+
final bool _enableDebuggingSupport;
3536

36-
DwdsInjector({Future<String>? extensionUri}) : _extensionUri = extensionUri;
37+
DwdsInjector({
38+
Future<String>? extensionUri,
39+
bool enableDebuggingSupport = true,
40+
})
41+
: _extensionUri = extensionUri,
42+
_enableDebuggingSupport = enableDebuggingSupport;
3743

3844
/// Returns the embedded dev handler paths.
3945
///
@@ -95,13 +101,17 @@ class DwdsInjector {
95101
await globalToolConfiguration.loadStrategy.trackEntrypoint(
96102
entrypoint,
97103
);
98-
body = await _injectClientAndHoistMain(
99-
body,
100-
appId,
101-
devHandlerPath,
102-
entrypoint,
103-
await _extensionUri,
104-
);
104+
// If true, inject the debugging client and hoist the main function
105+
// to enable debugging support.
106+
if (_enableDebuggingSupport) {
107+
body = await _injectClientAndHoistMain(
108+
body,
109+
appId,
110+
devHandlerPath,
111+
entrypoint,
112+
await _extensionUri,
113+
);
114+
}
105115
body += await globalToolConfiguration.loadStrategy.bootstrapFor(
106116
entrypoint,
107117
);

0 commit comments

Comments
 (0)