Skip to content

Commit afb1f0a

Browse files
committed
Merge remote-tracking branch 'upstream/main' into fixwindowstests
2 parents 59998a0 + d0fd3f7 commit afb1f0a

File tree

3 files changed

+18
-9
lines changed

3 files changed

+18
-9
lines changed

dwds/CHANGELOG.md

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,12 @@
11
## 25.1.0-wip
22

3+
## 25.0.3
4+
5+
### Bug Fixes:
6+
7+
- Fix issue in hot restart with the web socket where we didn't pass the reloaded
8+
sources path, resulting in a null assertion.
9+
310
## 25.0.2
411

512
### Bug Fixes:

dwds/lib/src/injected/client.js

Lines changed: 4 additions & 7 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dwds/web/client.dart

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -190,7 +190,9 @@ Future<void>? main() {
190190
manager.reloadPage();
191191
} else if (reloadConfiguration ==
192192
'ReloadConfiguration.hotRestart') {
193-
await manager.hotRestart();
193+
await manager.hotRestart(
194+
reloadedSourcesPath: hotRestartReloadedSourcesPath,
195+
);
194196
} else if (reloadConfiguration == 'ReloadConfiguration.hotReload') {
195197
await manager.hotReloadStart(hotReloadReloadedSourcesPath);
196198
await manager.hotReloadEnd();
@@ -493,7 +495,10 @@ Future<void> handleWebSocketHotRestartRequest(
493495
final requestId = event.id;
494496
try {
495497
final runId = const Uuid().v4().toString();
496-
await manager.hotRestart(runId: runId);
498+
await manager.hotRestart(
499+
runId: runId,
500+
reloadedSourcesPath: hotRestartReloadedSourcesPath,
501+
);
497502
_sendHotRestartResponse(clientSink, requestId, success: true);
498503
} catch (e) {
499504
_sendHotRestartResponse(

0 commit comments

Comments
 (0)