Skip to content

Commit afe9fc9

Browse files
committed
addressed comments regarding closing remoteDebugger
1 parent 6ba7f5b commit afe9fc9

File tree

3 files changed

+5
-27
lines changed

3 files changed

+5
-27
lines changed

dwds/CHANGELOG.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@
44
- Added WebSocket-based hot reload and service extension support via new `WebSocketProxyService` class that implements VM service protocol over WebSockets.
55
- Enhanced `DevHandler` with `useWebSocketConnection` flag to toggle between Chrome-based and WebSocket-based communication protocols.
66

7-
87
## 24.4.0
98

109
- Added support for breakpoint registering on a hot reload with the DDC library bundle format using PausePostRequests.

dwds/lib/src/connections/debug_connection.dart

Lines changed: 4 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -22,20 +22,9 @@ class DebugConnection {
2222
Future<void>? _closed;
2323

2424
DebugConnection(this._appDebugServices) {
25-
_setupChromeCloseHandler();
26-
}
27-
28-
/// Sets up Chrome remote debugger close handler if available.
29-
void _setupChromeCloseHandler() {
30-
try {
31-
final chromeProxyService = _appDebugServices.chromeProxyService;
32-
if (chromeProxyService != null) {
33-
final remoteDebugger = chromeProxyService.remoteDebugger;
34-
remoteDebugger.onClose.first.then((_) => close());
35-
}
36-
} catch (_) {
37-
// Chrome proxy service not available in WebSocket-only mode - ignore
38-
}
25+
_appDebugServices.chromeProxyService?.remoteDebugger.onClose.first.then(
26+
(_) => close(),
27+
);
3928
}
4029

4130
/// The port of the host Dart VM Service.
@@ -53,14 +42,7 @@ class DebugConnection {
5342
Future<void> close() =>
5443
_closed ??= () async {
5544
// Close Chrome remote debugger if available
56-
try {
57-
final chromeProxyService = _appDebugServices.chromeProxyService;
58-
if (chromeProxyService != null) {
59-
await chromeProxyService.remoteDebugger.close();
60-
}
61-
} catch (_) {
62-
// Chrome proxy service not available in WebSocket-only mode - ignore
63-
}
45+
await _appDebugServices.chromeProxyService?.remoteDebugger.close();
6446

6547
await _appDebugServices.close();
6648
_onDoneCompleter.complete();

dwds/lib/src/services/web_socket_app_debug_services.dart

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -34,10 +34,7 @@ class WebSocketAppDebugServices implements IAppDebugServices {
3434
@override
3535
Uri? get ddsUri => null;
3636
@override
37-
dynamic get chromeProxyService =>
38-
throw UnsupportedError(
39-
'Chrome proxy service not available in WebSocket-only mode',
40-
);
37+
dynamic get chromeProxyService => null;
4138

4239
@override
4340
dynamic get webSocketProxyService => _debugService.webSocketProxyService;

0 commit comments

Comments
 (0)