Use var/final consistently across repository

Author: parlough

_analysis_config/lib/analysis_options.yaml

@@ -25,16 +25,16 @@ linter:
     - join_return_with_assignment
     - library_names
     - literal_only_boolean_expressions
+    - omit_local_variable_types
+    - only_throw_errors
     - package_api_docs
     - package_prefixed_library_names
-    # - prefer_final_locals
-    # - prefer_relative_imports
+    - prefer_final_locals
     - prefer_single_quotes
+    # - prefer_relative_imports
     - prefer_void_to_null
     - test_types_in_equals
     - throw_in_finally
-    - omit_local_variable_types
-    - only_throw_errors
     - unawaited_futures
     - unnecessary_lambdas
     - unnecessary_parenthesis

dwds/analysis_options.yaml

@@ -10,5 +10,4 @@ analyzer:
 linter:
   rules:
     - always_use_package_imports
-    - prefer_final_locals
     - require_trailing_commas

fixtures/_experimentSound/web/main.dart

@@ -64,9 +64,11 @@ void testClass() {
 
 String testPattern(Object obj) {
   switch (obj) {
-    case [var a, int n] || [int n, var a] when n == 1 && a is String:
+    case [final a, final int n] || [final int n, final a]
+        when n == 1 && a is String:
       return a.toString(); // Breakpoint: testPatternCase1
-    case [double n, var a] || [var a, double n] when (n - 3.14).abs() < 0.001:
+    case [final double n, final a] || [final a, final double n]
+        when (n - 3.14).abs() < 0.001:
       return a.toString(); // Breakpoint: testPatternCase2
     default:
       return 'default'; // Breakpoint: testPatternDefault

fixtures/_testPackageSound/web/main.dart

@@ -14,7 +14,7 @@ import 'package:_test_sound/library.dart';
 
 extension NumberParsing on String {
   int parseInt() {
-    var ret = int.parse(this);
+    final ret = int.parse(this);
     return ret; // Breakpoint: extension
   }
 }
@@ -75,22 +75,22 @@ void printGeneric<T>(T formal) {
 }
 
 void printLocal() {
-  var local = 42;
+  final local = 42;
   print('Local is: $local'); // Breakpoint: printLocal
 }
 
 void printFieldFromLibraryClass() {
-  var instance = TestLibraryClass(1, 2); // Breakpoint: createLibraryObject
+  final instance = TestLibraryClass(1, 2); // Breakpoint: createLibraryObject
   print('$instance'); // Breakpoint: printFieldFromLibraryClass
 }
 
 void printFieldFromLibraryPartClass() {
-  var instance = TestLibraryPartClass(1, 2);
+  final instance = TestLibraryPartClass(1, 2);
   print('$instance'); // Breakpoint: printFieldFromLibraryPartClass
 }
 
 void printFieldMain() {
-  var instance = MainClass(2, 1);
+  final instance = MainClass(2, 1);
   print('$instance'); // Breakpoint: printFieldMain
 }
 
@@ -103,22 +103,22 @@ void printFromTestPackage() {
 }
 
 void printFromTestLibrary() {
-  var local = 23;
+  final local = 23;
   print(testLibraryFunction(local));
 }
 
 void printFromTestLibraryPart() {
-  var local = 23;
+  final local = 23;
   print(testLibraryPartFunction(local));
 }
 
 void printCallExtension() {
-  var local = '23';
+  final local = '23';
   print(local.parseInt());
 }
 
 void printLoopVariable() {
-  var list = <String>['1'];
+  final list = <String>['1'];
   for (var item in list) {
     print(item); // Breakpoint: printLoopVariable
   }
@@ -147,9 +147,9 @@ void printEnclosingObject(EnclosingClass o) {
 }
 
 void printStream() {
-  var controller = StreamController<int>();
-  var stream = controller.stream.asBroadcastStream();
-  var subscription = stream.listen(print);
+  final controller = StreamController<int>();
+  final stream = controller.stream.asBroadcastStream();
+  final subscription = stream.listen(print);
   controller.sink.add(0);
   subscription.cancel(); // Breakpoint: printStream
 }
@@ -185,26 +185,26 @@ void printFrame1() {
 }
 
 void printLargeScope() {
-  var t0 = 0;
-  var t1 = 1;
-  var t2 = 2;
-  var t3 = 3;
-  var t4 = 4;
-  var t5 = 5;
-  var t6 = 6;
-  var t7 = 7;
-  var t8 = 8;
-  var t9 = 9;
-  var t10 = 10;
-  var t11 = 11;
-  var t12 = 12;
-  var t13 = 13;
-  var t14 = 14;
-  var t15 = 15;
-  var t16 = 16;
-  var t17 = 17;
-  var t18 = 18;
-  var t19 = 19;
+  final t0 = 0;
+  final t1 = 1;
+  final t2 = 2;
+  final t3 = 3;
+  final t4 = 4;
+  final t5 = 5;
+  final t6 = 6;
+  final t7 = 7;
+  final t8 = 8;
+  final t9 = 9;
+  final t10 = 10;
+  final t11 = 11;
+  final t12 = 12;
+  final t13 = 13;
+  final t14 = 14;
+  final t15 = 15;
+  final t16 = 16;
+  final t17 = 17;
+  final t18 = 18;
+  final t19 = 19;
 
   print('$t0 $t1, $t2, $t3, $t4, $t5, $t6, $t7, $t8, $t9, $t10, '
       '$t11, $t12, $t13, $t14, $t15, $t16, $t17, $t18, $t19'); // Breakpoint: printLargeScope

fixtures/_testSound/example/hello_world/main.dart

@@ -18,7 +18,7 @@ part 'part.dart';
 // dwds/test/chrome_proxy_service_test.dart
 
 final topLevelList = () {
-  var l = List.filled(1001, 5);
+  final l = List.filled(1001, 5);
   l[4] = 100;
   return l;
 }();
@@ -37,7 +37,7 @@ void main() async {
 
   // long running to test evaluateInFrame
   Timer.periodic(const Duration(seconds: 1), (_) {
-    var local = 42;
+    final local = 42;
     print(local); // Breakpoint: printLocal
   });
 
@@ -101,13 +101,13 @@ void printCount() {
 }
 
 void asyncCall() async {
-  var now = DateTime.now();
+  final now = DateTime.now();
 
   await Future.delayed(Duration.zero);
 
-  var then = DateTime.now(); // Breakpoint: asyncCall
+  final then = DateTime.now(); // Breakpoint: asyncCall
   // ignore: unused_local_variable
-  var diff = then.difference(now);
+  final diff = then.difference(now);
 }
 
 void throwsException() {

fixtures/_testSound/example/scopes/main.dart

@@ -28,15 +28,16 @@ void staticFunction(int formal) {
 }
 
 void staticAsyncFunction(String value) async {
-  var myLocal = await 'a local value';
+  // ignore: unused_local_variable
+  final myLocal = await 'a local value';
   print(value); // Breakpoint: staticAsyncFunction
 }
 
 void staticAsyncLoopFunction(String value) async {
   Function? f;
   for (var i in [1, 2, 3]) {
     print(i);
-    var myLocal = await 'my local value';
+    final myLocal = await 'my local value';
     f ??= () {
       print(value);
       print(i);
@@ -48,9 +49,9 @@ void staticAsyncLoopFunction(String value) async {
 
 void main() async {
   print('Initial print from scopes app');
-  var local = 'local in main';
-  var intLocalInMain = 42;
-  var testClass = MyTestClass();
+  final local = 'local in main';
+  final intLocalInMain = 42;
+  final testClass = MyTestClass();
   Object? localThatsNull;
   identityMap['a'] = 1;
   identityMap['b'] = 2;
@@ -59,7 +60,7 @@ void main() async {
   notAList.add(7);
 
   String nestedFunction<T>(T parameter, Object aClass) {
-    var another = int.tryParse('$parameter');
+    final another = int.tryParse('$parameter');
     return '$local: parameter, $another'; // Breakpoint: nestedFunction
   }
 
@@ -68,7 +69,7 @@ void main() async {
   }
 
   Timer.periodic(const Duration(seconds: 1), (Timer t) {
-    var ticks = t.tick;
+    final ticks = t.tick;
     // ignore: unused_local_variable, prefer_typing_uninitialized_variables
     var closureLocal;
     libraryPublicFinal.printCount();
@@ -79,12 +80,12 @@ void main() async {
     print(nestedFunction('$ticks ${testClass.message}', Timer));
     print(localThatsNull);
     print(libraryNull);
-    var localList = libraryPublic;
+    final localList = libraryPublic;
     print(localList);
     localList.add('abc');
-    var f = testClass.methodWithVariables();
+    final f = testClass.methodWithVariables();
     print(f('parameter'));
-    var num = '1234'.someExtensionMethod();
+    final num = '1234'.someExtensionMethod();
     print('$num');
   });
 
@@ -96,7 +97,7 @@ void main() async {
 
 String libraryFunction(String arg) {
   print('calling a library function with $arg');
-  var concat = 'some constant plus $arg plus whatever';
+  final concat = 'some constant plus $arg plus whatever';
   print(concat);
   return concat;
 }
@@ -118,11 +119,11 @@ class MyTestClass<T> extends MyAbstractClass {
   String hello() => message;
 
   String Function(String) methodWithVariables() {
-    var local = '$message + something';
+    final local = '$message + something';
     print(local);
     return (String parameter) {
       // Be sure to use a field from this, so it isn't entirely optimized away.
-      var closureLocalInsideMethod = '$message/$local/$parameter';
+      final closureLocalInsideMethod = '$message/$local/$parameter';
       print(closureLocalInsideMethod);
       return closureLocalInsideMethod; // Breakpoint: nestedClosure
     };
@@ -184,7 +185,7 @@ class NotReallyAList extends ListBase<Object?> {
 
 extension NumberParsing on String {
   int someExtensionMethod() {
-    var ret = int.parse(this);
+    final ret = int.parse(this);
     return ret; // Breakpoint: extension
   }
 }

fixtures/_webdevSoundSmoke/web/scopes_main.dart

@@ -27,9 +27,9 @@ void staticFunction(int formal) {
 
 void main() async {
   print('Initial print from scopes app');
-  var local = 'local in main';
-  var intLocalInMain = 42;
-  var testClass = MyTestClass();
+  final local = 'local in main';
+  final intLocalInMain = 42;
+  final testClass = MyTestClass();
   Object? localThatsNull;
   identityMap['a'] = 1;
   identityMap['b'] = 2;
@@ -38,7 +38,7 @@ void main() async {
   notAList.add(7);
 
   String nestedFunction<T>(T parameter, Object aClass) {
-    var another = int.tryParse('$parameter');
+    final another = int.tryParse('$parameter');
     return '$local: parameter, $another'; // Breakpoint: nestedFunction
   }
 
@@ -47,7 +47,7 @@ void main() async {
   }
 
   Timer.periodic(const Duration(seconds: 1), (Timer t) {
-    var ticks = t.tick;
+    final ticks = t.tick;
     // ignore: unused_local_variable, prefer_typing_uninitialized_variables
     var closureLocal;
     libraryPublicFinal.printCount();
@@ -56,10 +56,10 @@ void main() async {
     print(nestedFunction('$ticks ${testClass.message}', Timer));
     print(localThatsNull);
     print(libraryNull);
-    var localList = libraryPublic;
+    final localList = libraryPublic;
     print(localList);
     localList.add('abc');
-    var f = testClass.methodWithVariables();
+    final f = testClass.methodWithVariables();
     print(f('parameter'));
   });
 
@@ -71,7 +71,7 @@ void main() async {
 
 String libraryFunction(String arg) {
   print('calling a library function with $arg');
-  var concat = 'some constant plus $arg plus whatever';
+  final concat = 'some constant plus $arg plus whatever';
   print(concat);
   return concat;
 }
@@ -89,11 +89,11 @@ class MyTestClass<T> {
   String hello() => message;
 
   String Function(String) methodWithVariables() {
-    var local = '$message + something';
+    final local = '$message + something';
     print(local);
     return (String parameter) {
       // Be sure to use a field from this, so it isn't entirely optimized away.
-      var closureLocalInsideMethod = '$message/$local/$parameter';
+      final closureLocalInsideMethod = '$message/$local/$parameter';
       print(closureLocalInsideMethod);
       return closureLocalInsideMethod; // Breakpoint: nestedClosure
     };