Fix analyzer warnings.

a-siva · a-siva · commit c1f39eff2004 · 2025-02-20T13:56:01.000-08:00
diff --git a/dwds/debug_extension/web/background.dart b/dwds/debug_extension/web/background.dart
@@ -6,6 +6,8 @@
 library;
 
 import 'package:dwds/data/debug_info.dart';
+// TODO: https://github.com/dart-lang/webdev/issues/2508
+// ignore: deprecated_member_use
 import 'package:js/js.dart';
 
 import 'chrome_api.dart';
diff --git a/dwds/debug_extension/web/chrome_api.dart b/dwds/debug_extension/web/chrome_api.dart
@@ -6,6 +6,8 @@
 // ignore: deprecated_member_use
 import 'dart:html';
 
+// TODO: https://github.com/dart-lang/webdev/issues/2508
+// ignore: deprecated_member_use
 import 'package:js/js.dart';
 
 @JS()
diff --git a/dwds/debug_extension/web/cider_connection.dart b/dwds/debug_extension/web/cider_connection.dart
@@ -10,6 +10,8 @@ import 'dart:convert';
 // ignore: deprecated_member_use
 import 'dart:js_util';
 
+// TODO: https://github.com/dart-lang/webdev/issues/2508
+// ignore: deprecated_member_use
 import 'package:js/js.dart';
 
 import 'chrome_api.dart';
diff --git a/dwds/debug_extension/web/copier.dart b/dwds/debug_extension/web/copier.dart
@@ -9,6 +9,8 @@ library;
 // ignore: deprecated_member_use
 import 'dart:html';
 
+// TODO: https://github.com/dart-lang/webdev/issues/2508
+// ignore: deprecated_member_use
 import 'package:js/js.dart';
 
 import 'chrome_api.dart';
diff --git a/dwds/debug_extension/web/cross_extension_communication.dart b/dwds/debug_extension/web/cross_extension_communication.dart
@@ -5,6 +5,8 @@
 @JS()
 library;
 
+// TODO: https://github.com/dart-lang/webdev/issues/2508
+// ignore: deprecated_member_use
 import 'package:js/js.dart';
 
 import 'chrome_api.dart';
diff --git a/dwds/debug_extension/web/debug_info.dart b/dwds/debug_extension/web/debug_info.dart
@@ -15,6 +15,8 @@ import 'dart:js';
 
 import 'package:dwds/data/debug_info.dart';
 import 'package:dwds/data/serializers.dart';
+// TODO: https://github.com/dart-lang/webdev/issues/2508
+// ignore: deprecated_member_use
 import 'package:js/js.dart';
 
 void main() {
diff --git a/dwds/debug_extension/web/debug_session.dart b/dwds/debug_extension/web/debug_session.dart
@@ -15,7 +15,11 @@ import 'package:dwds/data/devtools_request.dart';
 import 'package:dwds/data/extension_request.dart';
 import 'package:dwds/shared/batched_stream.dart';
 import 'package:dwds/src/sockets.dart';
+// TODO: https://github.com/dart-lang/webdev/issues/2508
+// ignore: deprecated_member_use
 import 'package:js/js.dart';
+// TODO: https://github.com/dart-lang/webdev/issues/2508
+// ignore: deprecated_member_use
 import 'package:js/js_util.dart' as js_util;
 import 'package:sse/client/sse_client.dart';
 import 'package:web_socket_channel/web_socket_channel.dart';
diff --git a/dwds/debug_extension/web/detector.dart b/dwds/debug_extension/web/detector.dart
@@ -14,6 +14,8 @@ import 'dart:html';
 import 'dart:js_util';
 
 import 'package:dwds/data/debug_info.dart';
+// TODO: https://github.com/dart-lang/webdev/issues/2508
+// ignore: deprecated_member_use
 import 'package:js/js.dart';
 
 import 'chrome_api.dart';
diff --git a/dwds/debug_extension/web/devtools.dart b/dwds/debug_extension/web/devtools.dart
@@ -10,6 +10,8 @@ library;
 import 'dart:html';
 
 import 'package:dwds/data/debug_info.dart';
+// TODO: https://github.com/dart-lang/webdev/issues/2508
+// ignore: deprecated_member_use
 import 'package:js/js.dart';
 
 import 'chrome_api.dart';
diff --git a/dwds/debug_extension/web/logger.dart b/dwds/debug_extension/web/logger.dart
@@ -5,6 +5,8 @@
 @JS()
 library;
 
+// TODO: https://github.com/dart-lang/webdev/issues/2508
+// ignore: deprecated_member_use
 import 'package:js/js.dart';
 
 import 'utils.dart';
diff --git a/dwds/debug_extension/web/messaging.dart b/dwds/debug_extension/web/messaging.dart
@@ -11,6 +11,8 @@ import 'dart:convert';
 // ignore: deprecated_member_use
 import 'dart:js_util';
 
+// TODO: https://github.com/dart-lang/webdev/issues/2508
+// ignore: deprecated_member_use
 import 'package:js/js.dart';
 
 import 'chrome_api.dart';
diff --git a/dwds/debug_extension/web/panel.dart b/dwds/debug_extension/web/panel.dart
@@ -12,6 +12,8 @@ import 'dart:convert';
 import 'dart:html';
 
 import 'package:dwds/data/debug_info.dart';
+// TODO: https://github.com/dart-lang/webdev/issues/2508
+// ignore: deprecated_member_use
 import 'package:js/js.dart';
 
 import 'chrome_api.dart';
diff --git a/dwds/debug_extension/web/popup.dart b/dwds/debug_extension/web/popup.dart
@@ -12,6 +12,8 @@ import 'dart:convert';
 import 'dart:html';
 
 import 'package:dwds/data/debug_info.dart';
+// TODO: https://github.com/dart-lang/webdev/issues/2508
+// ignore: deprecated_member_use
 import 'package:js/js.dart';
 
 import 'data_serializers.dart';
diff --git a/dwds/debug_extension/web/storage.dart b/dwds/debug_extension/web/storage.dart
@@ -11,6 +11,8 @@ import 'dart:convert';
 // ignore: deprecated_member_use
 import 'dart:js_util';
 
+// TODO: https://github.com/dart-lang/webdev/issues/2508
+// ignore: deprecated_member_use
 import 'package:js/js.dart';
 
 import 'chrome_api.dart';
diff --git a/dwds/debug_extension/web/utils.dart b/dwds/debug_extension/web/utils.dart
@@ -10,6 +10,8 @@ import 'dart:async';
 // ignore: deprecated_member_use
 import 'dart:js_util';
 
+// TODO: https://github.com/dart-lang/webdev/issues/2508
+// ignore: deprecated_member_use
 import 'package:js/js.dart';
 
 import 'chrome_api.dart';
diff --git a/dwds/debug_extension/web/web_api.dart b/dwds/debug_extension/web/web_api.dart
@@ -9,6 +9,8 @@ import 'dart:html';
 // ignore: deprecated_member_use
 import 'dart:js_util' as js_util;
 
+// TODO: https://github.com/dart-lang/webdev/issues/2508
+// ignore: deprecated_member_use
 import 'package:js/js.dart';
 
 @JS()
diff --git a/dwds/lib/src/services/chrome_proxy_service.dart b/dwds/lib/src/services/chrome_proxy_service.dart
@@ -224,7 +224,7 @@ class ChromeProxyService implements VmServiceInterface {
         // Expression evaluation is ready after dependencies are updated.
         if (!_compilerCompleter.isCompleted) _compilerCompleter.complete();
         return result;
-      }, (result) => DwdsEvent.compilerUpdateDependencies(entrypoint));
+      }, (result) => DwdsEvent.compilerUpdateDependencies(entrypoint),);
     }
   }
 
@@ -683,7 +683,7 @@ class ChromeProxyService implements VmServiceInterface {
         RPCErrorKind.kInvalidRequest.code,
         'Expression evaluation is not supported for this configuration.',
       );
-    }, (result) => DwdsEvent.evaluate(expression, result));
+    }, (result) => DwdsEvent.evaluate(expression, result),);
   }
 
   String _newVariableForScope(Map<String, String>? scope) {
@@ -744,7 +744,7 @@ class ChromeProxyService implements VmServiceInterface {
         RPCErrorKind.kInvalidRequest.code,
         'Expression evaluation is not supported for this configuration.',
       );
-    }, (result) => DwdsEvent.evaluateInFrame(expression, result));
+    }, (result) => DwdsEvent.evaluateInFrame(expression, result),);
   }
 
   @override
@@ -796,7 +796,7 @@ class ChromeProxyService implements VmServiceInterface {
       await isInitialized;
       _checkIsolate('getIsolate', isolateId);
       return inspector.isolate;
-    }, (result) => DwdsEvent.getIsolate());
+    }, (result) => DwdsEvent.getIsolate(),);
   }
 
   @override
@@ -848,7 +848,7 @@ class ChromeProxyService implements VmServiceInterface {
       await isInitialized;
       _checkIsolate('getScripts', isolateId);
       return inspector.getScripts();
-    }, (result) => DwdsEvent.getScripts());
+    }, (result) => DwdsEvent.getScripts(),);
   }
 
   @override
@@ -900,7 +900,7 @@ class ChromeProxyService implements VmServiceInterface {
         reportLines: reportLines,
         libraryFilters: libraryFilters,
       );
-    }, (result) => DwdsEvent.getSourceReport());
+    }, (result) => DwdsEvent.getSourceReport(),);
   }
 
   /// Returns the current stack.
@@ -936,7 +936,7 @@ class ChromeProxyService implements VmServiceInterface {
     return captureElapsedTime(() async {
       await isInitialized;
       return _vm;
-    }, (result) => DwdsEvent.getVM());
+    }, (result) => DwdsEvent.getVM(),);
   }
 
   @override
@@ -1159,7 +1159,7 @@ class ChromeProxyService implements VmServiceInterface {
           step: step,
           frameIndex: frameIndex,
         );
-      }, (result) => DwdsEvent.resume(step));
+      }, (result) => DwdsEvent.resume(step),);
     } else {
       inspector.appConnection.runMain();
       return Success();
diff --git a/dwds/lib/src/utilities/server.dart b/dwds/lib/src/utilities/server.dart
@@ -68,7 +68,7 @@ void serveHttpRequests(
 ) {
   return Chain.capture(() {
     serveRequests(requests, handler);
-  }, onError: onError);
+  }, onError: onError,);
 }
 
 /// Throws an [wip.ExceptionDetails] object if `exceptionDetails` is present on the
@@ -96,7 +96,7 @@ Map<String, dynamic> getResultOrHandleError(
   if (result == null) {
     throw ChromeDebugException({
       'text': 'null result from Chrome Devtools',
-    }, evalContents: evalContents);
+    }, evalContents: evalContents,);
   }
   return result;
 }
diff --git a/dwds/lib/src/utilities/shared.dart b/dwds/lib/src/utilities/shared.dart
@@ -44,5 +44,5 @@ Future<T> wrapInErrorHandlerAsync<T>(
         'Unexpected DWDS error for $command: $error',
       ),
     );
-  }, test: (e) => e is! RPCError && e is! SentinelException);
+  }, test: (e) => e is! RPCError && e is! SentinelException,);
 }
diff --git a/dwds/test/common/chrome_proxy_service_common.dart b/dwds/test/common/chrome_proxy_service_common.dart
@@ -1462,7 +1462,7 @@ void runTests({
 
         final sourceReport = await service.getSourceReport(isolateId, [
           'PossibleBreakpoints',
-        ], scriptId: mainScript.id);
+        ], scriptId: mainScript.id,);
 
         expect(sourceReport.scripts, isNotEmpty);
         expect(sourceReport.ranges, isNotEmpty);
diff --git a/dwds/test/devtools_test.dart b/dwds/test/devtools_test.dart
@@ -54,7 +54,7 @@ void main() {
       expect(await context.webDriver.pageSource, contains('DevTools'));
       expect(await context.webDriver.currentUrl, contains('ide=Dwds'));
       // TODO(https://github.com/dart-lang/webdev/issues/1888): Re-enable.
-    }, skip: Platform.isWindows);
+    }, skip: Platform.isWindows,);
 
     test(
       'can not launch devtools for the same app in multiple tabs',
@@ -140,7 +140,7 @@ void main() {
       },
       skip: 'https://github.com/dart-lang/webdev/issues/1888',
     );
-  }, timeout: Timeout.factor(2));
+  }, timeout: Timeout.factor(2),);
 
   group('Injected client without a DevTools server', () {
     setUp(() async {
diff --git a/dwds/test/evaluate_common.dart b/dwds/test/evaluate_common.dart
@@ -612,7 +612,7 @@ void testAll({
             matchErrorRef(contains(EvaluationErrorKind.loadModule)),
           );
         });
-      }, skip: 'https://github.com/dart-lang/sdk/issues/48587');
+      }, skip: 'https://github.com/dart-lang/sdk/issues/48587',);
 
       test('cannot evaluate in unsupported isolate', () async {
         await onBreakPoint(mainScript, 'printLocal', (event) async {
@@ -795,7 +795,7 @@ void testAll({
         expect(result, matchInstanceRef('42'));
       });
     });
-  }, timeout: const Timeout.factor(2));
+  }, timeout: const Timeout.factor(2),);
 
   group('shared context with no evaluation |', () {
     setUpAll(() async {
diff --git a/dwds/test/events_test.dart b/dwds/test/events_test.dart
@@ -164,7 +164,7 @@ void main() {
               'elapsedMilliseconds': isNotNull,
               'screen': equals('debugger'),
             }),
-          ], () => keyboard.sendChord([Keyboard.alt, 'd']));
+          ], () => keyboard.sendChord([Keyboard.alt, 'd']),);
         },
         skip: 'https://github.com/dart-lang/webdev/issues/2394',
       );
@@ -380,7 +380,7 @@ void main() {
             }),
             () => service.getSourceReport(isolateId, [
               SourceReportKind.kPossibleBreakpoints,
-            ], scriptId: mainScript.id),
+            ], scriptId: mainScript.id,),
           );
         });
       });
diff --git a/dwds/test/fixtures/context.dart b/dwds/test/fixtures/context.dart
@@ -209,7 +209,7 @@ class TestContext {
       await Process.run(sdkLayout.dartPath, [
         'pub',
         'upgrade',
-      ], workingDirectory: project.absolutePackageDirectory);
+      ], workingDirectory: project.absolutePackageDirectory,);
 
       ExpressionCompiler? expressionCompiler;
       AssetReader assetReader;
diff --git a/dwds/test/fixtures/project.dart b/dwds/test/fixtures/project.dart
@@ -156,7 +156,7 @@ class TestProject {
       'run',
       'build_runner',
       'clean',
-    ], workingDirectory: absolutePackageDirectory);
+    ], workingDirectory: absolutePackageDirectory,);
   }
 
   /// The path to the Dart specified file in the 'lib' directory, e.g,
diff --git a/dwds/test/fixtures/utilities.dart b/dwds/test/fixtures/utilities.dart
@@ -28,7 +28,7 @@ Future<BuildDaemonClient> connectClient(
   'build_runner',
   'daemon',
   ...options,
-], logHandler: logHandler);
+], logHandler: logHandler,);
 
 /// Returns the port of the daemon asset server.
 int daemonPort(String workingDirectory) {
diff --git a/dwds/test/instances/common/instance_common.dart b/dwds/test/instances/common/instance_common.dart
@@ -243,7 +243,7 @@ void runTests({
         expect(classRef.name, '_ControllerStream<int>');
         expect(classRef.id, 'classes|dart:async|_ControllerStream<int>');
         expect(inspector.isDisplayableObject(ref), isTrue);
-      }, skip: !dartSdkIsAtLeast('3.6.0-148.0.dev'));
+      }, skip: !dartSdkIsAtLeast('3.6.0-148.0.dev'),);
 
       test(
         'for a Dart error',
@@ -431,7 +431,7 @@ void runTests({
         final classRef = instance.classRef!;
         expect(classRef.name, '_ControllerStream<int>');
         expect(inspector.isDisplayableObject(instance), isTrue);
-      }, skip: !dartSdkIsAtLeast('3.6.0-148.0.dev'));
+      }, skip: !dartSdkIsAtLeast('3.6.0-148.0.dev'),);
 
       test(
         'for a Dart error',
diff --git a/dwds/test/instances/common/record_type_inspection_common.dart b/dwds/test/instances/common/record_type_inspection_common.dart
@@ -126,7 +126,7 @@ void runTests({
           matchDisplayedTypeObjectGetters,
         );
       });
-    }, skip: !dartSdkIsAtLeast('3.4.0-56.0.dev'));
+    }, skip: !dartSdkIsAtLeast('3.4.0-56.0.dev'),);
 
     test('simple record type display', () async {
       await onBreakPoint('printSimpleLocalRecord', (event) async {
@@ -190,7 +190,7 @@ void runTests({
           matchDisplayedTypeObjectGetters,
         );
       });
-    }, skip: !dartSdkIsAtLeast('3.4.0-56.0.dev'));
+    }, skip: !dartSdkIsAtLeast('3.4.0-56.0.dev'),);
 
     test('complex record type display', () async {
       await onBreakPoint('printComplexLocalRecord', (event) async {
@@ -332,7 +332,7 @@ void runTests({
           matchDisplayedTypeObjectGetters,
         );
       });
-    }, skip: !dartSdkIsAtLeast('3.4.0-56.0.dev'));
+    }, skip: !dartSdkIsAtLeast('3.4.0-56.0.dev'),);
 
     test('nested record type display', () async {
       await onBreakPoint('printNestedLocalRecord', (event) async {
diff --git a/dwds/test/instances/common/type_inspection_common.dart b/dwds/test/instances/common/type_inspection_common.dart
diff --git a/dwds/test/package_uri_mapper_test.dart b/dwds/test/package_uri_mapper_test.dart
diff --git a/dwds/test/puppeteer/test_utils.dart b/dwds/test/puppeteer/test_utils.dart
diff --git a/dwds/test/readers/frontend_server_asset_reader_test.dart b/dwds/test/readers/frontend_server_asset_reader_test.dart
diff --git a/dwds/test/reload_correctness_test.dart b/dwds/test/reload_correctness_test.dart
diff --git a/dwds/test/reload_test.dart b/dwds/test/reload_test.dart
diff --git a/dwds/test/run_request_test.dart b/dwds/test/run_request_test.dart
