Skip to content

Commit d6846d4

Browse files
committed
Fix tests
1 parent d9e89ad commit d6846d4

File tree

1 file changed

+7
-18
lines changed

1 file changed

+7
-18
lines changed

dwds/test/devtools_test.dart

Lines changed: 7 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -58,18 +58,13 @@ void main() {
5858
await context.tearDown();
5959
});
6060

61-
test(
62-
'can launch devtools',
63-
() async {
64-
final windows = await context.webDriver.windows.toList();
65-
await context.webDriver.driver.switchTo.window(windows.last);
66-
expect(await context.webDriver.pageSource, contains('DevTools'));
67-
expect(await context.webDriver.currentUrl, contains('ide=Dwds'));
68-
// TODO(https://github.com/dart-lang/webdev/issues/1888): Re-enable.
69-
},
70-
skip: Platform.isWindows,
71-
retry: 0,
72-
);
61+
test('can launch devtools', () async {
62+
final windows = await context.webDriver.windows.toList();
63+
await context.webDriver.driver.switchTo.window(windows.last);
64+
expect(await context.webDriver.pageSource, contains('DevTools'));
65+
expect(await context.webDriver.currentUrl, contains('ide=Dwds'));
66+
// TODO(https://github.com/dart-lang/webdev/issues/1888): Re-enable.
67+
}, skip: Platform.isWindows);
7368

7469
test(
7570
'can not launch devtools for the same app in multiple tabs',
@@ -169,9 +164,6 @@ void main() {
169164
await context.setUp(
170165
debugSettings: TestDebugSettings.noDevToolsLaunch().copyWith(
171166
enableDevToolsLaunch: true,
172-
ddsConfiguration: DartDevelopmentServiceConfiguration(
173-
serveDevTools: false,
174-
),
175167
),
176168
);
177169
});
@@ -198,9 +190,6 @@ void main() {
198190
await context.setUp(
199191
debugSettings: TestDebugSettings.noDevToolsLaunch().copyWith(
200192
enableDebugExtension: true,
201-
ddsConfiguration: DartDevelopmentServiceConfiguration(
202-
serveDevTools: false,
203-
),
204193
),
205194
);
206195
});

0 commit comments

Comments
 (0)