Use var/final consistently across repository (#2502)

* Use var/final consistently across repository

* Also enable prefer_final_in_for_each for consistency

Author: parlough

_analysis_config/lib/analysis_options.yaml

@@ -25,16 +25,17 @@ linter:
     - join_return_with_assignment
     - library_names
     - literal_only_boolean_expressions
+    - omit_local_variable_types
+    - only_throw_errors
     - package_api_docs
     - package_prefixed_library_names
-    # - prefer_final_locals
-    # - prefer_relative_imports
+    - prefer_final_in_for_each
+    - prefer_final_locals
     - prefer_single_quotes
+    # - prefer_relative_imports
     - prefer_void_to_null
     - test_types_in_equals
     - throw_in_finally
-    - omit_local_variable_types
-    - only_throw_errors
     - unawaited_futures
     - unnecessary_lambdas
     - unnecessary_parenthesis

dwds/analysis_options.yaml

@@ -10,5 +10,4 @@ analyzer:
 linter:
   rules:
     - always_use_package_imports
-    - prefer_final_locals
     - require_trailing_commas

dwds/debug_extension/web/detector.dart

@@ -78,7 +78,7 @@ void _detectMultipleDartAppsCallback(
   List<dynamic> mutations,
   MutationObserver observer,
 ) {
-  for (var mutation in mutations) {
+  for (final mutation in mutations) {
     if (_isMultipleAppsMutation(mutation)) {
       _sendMessageToBackgroundScript(
         type: MessageType.multipleAppsDetected,

dwds/lib/src/debugging/classes.dart

@@ -22,7 +22,7 @@ class ClassHelper extends Domain {
       classRefForString,
       classRefForUnknown,
     ];
-    for (var classRef in staticClasses) {
+    for (final classRef in staticClasses) {
       final classId = classRef.id;
       if (classId != null) {
         _classes[classId] = Class(

dwds/lib/src/debugging/dart_scope.dart

@@ -56,7 +56,7 @@ Future<List<Property>> visibleVariables({
 
   // Iterate to least specific scope last to help preserve order in the local
   // variables view when stepping.
-  for (var scope in filterScopes(frame).reversed) {
+  for (final scope in filterScopes(frame).reversed) {
     final objectId = scope.object.objectId;
     if (objectId != null) {
       final properties = await inspector.getProperties(objectId);

dwds/lib/src/debugging/inspector.dart

@@ -538,7 +538,7 @@ class AppInspector implements AppInspectorInterface {
     // breakpoints. This is because the token positions are derived from the
     // DDC source maps which Chrome also uses.
     final tokenPositions = <int>[
-      for (var location in mappedLocations) location.tokenPos,
+      for (final location in mappedLocations) location.tokenPos,
     ];
     tokenPositions.sort();
 
@@ -710,11 +710,11 @@ class AppInspector implements AppInspectorInterface {
       // for them.
       final userLibraries =
           _userLibraryUris(isolate.libraries ?? <LibraryRef>[]);
-      for (var uri in userLibraries) {
+      for (final uri in userLibraries) {
         final parts = scripts[uri];
         final scriptRefs = [
           ScriptRef(uri: uri, id: createId()),
-          for (var part in parts ?? []) ScriptRef(uri: part, id: createId()),
+          for (final part in parts ?? []) ScriptRef(uri: part, id: createId()),
         ];
         final libraryRef = await _libraryHelper.libraryRefFor(uri);
         final libraryId = libraryRef?.id;
@@ -723,7 +723,7 @@ class AppInspector implements AppInspectorInterface {
             libraryId,
             () => <ScriptRef>[],
           );
-          for (var scriptRef in scriptRefs) {
+          for (final scriptRef in scriptRefs) {
             final scriptId = scriptRef.id;
             final scriptUri = scriptRef.uri;
             if (scriptId != null && scriptUri != null) {

dwds/lib/src/debugging/libraries.dart

@@ -56,7 +56,7 @@ class LibraryHelper extends Domain {
     final libraries = await globalToolConfiguration.loadStrategy
         .metadataProviderFor(inspector.appConnection.request.entrypointPath)
         .libraries;
-    for (var library in libraries) {
+    for (final library in libraries) {
       _libraryRefsById[library] =
           LibraryRef(id: library, name: library, uri: library);
     }

dwds/lib/src/debugging/location.dart

@@ -227,7 +227,7 @@ class Locations {
     int column,
   ) {
     Location? bestLocation;
-    for (var location in locations) {
+    for (final location in locations) {
       if (location.dartLocation.line == line &&
           location.dartLocation.column >= column) {
         bestLocation ??= location;
@@ -255,7 +255,7 @@ class Locations {
   ) {
     column ??= 0;
     Location? bestLocation;
-    for (var location in locations) {
+    for (final location in locations) {
       if (location.jsLocation.compareToLine(line, column) <= 0) {
         bestLocation ??= location;
         if (location.jsLocation.compareTo(bestLocation.jsLocation) > 0) {
@@ -277,16 +277,16 @@ class Locations {
     tokenPosTable = <List<int>>[];
     final locations = await locationsForDart(serverPath);
     final lineNumberToLocation = <int, Set<Location>>{};
-    for (var location in locations) {
+    for (final location in locations) {
       lineNumberToLocation
           .putIfAbsent(location.dartLocation.line, () => <Location>{})
           .add(location);
     }
-    for (var lineNumber in lineNumberToLocation.keys) {
+    for (final lineNumber in lineNumberToLocation.keys) {
       final locations = lineNumberToLocation[lineNumber]!;
       tokenPosTable.add([
         lineNumber,
-        for (var location in locations) ...[
+        for (final location in locations) ...[
           location.tokenPos,
           location.dartLocation.column,
         ],
@@ -341,8 +341,8 @@ class Locations {
       final mapping = parse(sourceMapContents);
       if (mapping is SingleMapping) {
         // Create TokenPos for each entry in the source map.
-        for (var lineEntry in mapping.lines) {
-          for (var entry in lineEntry.entries) {
+        for (final lineEntry in mapping.lines) {
+          for (final entry in lineEntry.entries) {
             final location = _locationForSourceMapEntry(
               lineEntry: lineEntry,
               entry: entry,
@@ -357,7 +357,7 @@ class Locations {
           }
         }
       }
-      for (var location in result) {
+      for (final location in result) {
         _sourceToLocation
             .putIfAbsent(
               location.dartLocation.uri.serverPath,

dwds/lib/src/debugging/metadata/module_metadata.dart

@@ -161,7 +161,7 @@ class ModuleMetadata {
           '\n    ${ModuleMetadataVersion.previous.version}');
     }
 
-    for (var l in _readRequiredList(json, 'libraries')) {
+    for (final l in _readRequiredList(json, 'libraries')) {
       addLibrary(LibraryMetadata.fromJson(l as Map<String, dynamic>));
     }
   }
@@ -173,7 +173,7 @@ class ModuleMetadata {
       'closureName': closureName,
       'sourceMapUri': sourceMapUri,
       'moduleUri': moduleUri,
-      'libraries': [for (var lib in libraries.values) lib.toJson()],
+      'libraries': [for (final lib in libraries.values) lib.toJson()],
       'soundNullSafety': soundNullSafety,
     };
   }

dwds/lib/src/debugging/metadata/provider.dart

@@ -189,7 +189,7 @@ class MetadataProvider {
         final merged = await _assetReader.metadataContents(serverPath);
         if (merged != null) {
           _addSdkMetadata();
-          for (var contents in merged.split('\n')) {
+          for (final contents in merged.split('\n')) {
             try {
               if (contents.isEmpty ||
                   contents.startsWith('// intentionally empty:')) {
@@ -227,15 +227,15 @@ class MetadataProvider {
     _modulePathToModule[modulePath] = metadata.name;
     _moduleToModulePath[metadata.name] = modulePath;
 
-    for (var library in metadata.libraries.values) {
+    for (final library in metadata.libraries.values) {
       if (library.importUri.startsWith('file:/')) {
         throw AbsoluteImportUriException(library.importUri);
       }
       _libraries.add(library.importUri);
       _scripts[library.importUri] = [];
 
       _scriptToModule[library.importUri] = metadata.name;
-      for (var path in library.partUris) {
+      for (final path in library.partUris) {
         // Parts in metadata are relative to the library Uri directory.
         final partPath = p.url.join(p.dirname(library.importUri), path);
         _scripts[library.importUri]!.add(partPath);
@@ -247,7 +247,7 @@ class MetadataProvider {
   void _addSdkMetadata() {
     final moduleName = 'dart_sdk';
 
-    for (var lib in sdkLibraries) {
+    for (final lib in sdkLibraries) {
       _libraries.add(lib);
       _scripts[lib] = [];
       _scriptToModule[lib] = moduleName;