Skip to content

Commit f2f1023

Browse files
committed
addressed comments
1 parent fbeacb6 commit f2f1023

File tree

2 files changed

+10
-10
lines changed

2 files changed

+10
-10
lines changed

dwds/lib/src/services/proxy_service.dart

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -185,23 +185,23 @@ abstract class ProxyService implements VmServiceInterface {
185185

186186
/// Completes hot reload with response from client.
187187
///
188-
/// Default implementation throws UnimplementedError.
188+
/// Default implementation throws [UnimplementedError].
189189
/// Override in subclasses that support hot reload completion.
190190
void completeHotReload(HotReloadResponse response) {
191191
throw UnimplementedError('completeHotReload not supported');
192192
}
193193

194194
/// Completes hot restart with response from client.
195195
///
196-
/// Default implementation throws UnimplementedError.
196+
/// Default implementation throws [UnimplementedError].
197197
/// Override in subclasses that support hot restart completion.
198198
void completeHotRestart(HotRestartResponse response) {
199199
throw UnimplementedError('completeHotRestart not supported');
200200
}
201201

202202
/// Completes service extension with response from client.
203203
///
204-
/// Default implementation throws UnimplementedError.
204+
/// Default implementation throws [UnimplementedError].
205205
/// Override in subclasses that support service extension completion.
206206
void completeServiceExtension(ServiceExtensionResponse response) {
207207
throw UnimplementedError('completeServiceExtension not supported');

dwds/lib/src/services/web_socket_proxy_service.dart

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ const _pauseIsolatesOnStartFlag = 'pause_isolates_on_start';
3131
/// Grace period before destroying isolate when no clients are detected.
3232
/// This handles the race condition during page refresh where the old connection
3333
/// closes before the new connection is established, preventing premature isolate destruction.
34-
const _isolateDestructionGracePeriod = Duration(seconds: 10);
34+
const _isolateDestructionGracePeriod = Duration(seconds: 15);
3535

3636
/// Tracks hot reload responses from multiple browser windows/tabs.
3737
class _HotReloadTracker {
@@ -48,7 +48,7 @@ class _HotReloadTracker {
4848
required this.timeoutTimer,
4949
});
5050

51-
bool get isComplete => responses.length >= expectedResponses;
51+
bool get gotAllResponses => responses.length >= expectedResponses;
5252

5353
void addResponse(HotReloadResponse response) {
5454
responses.add(response);
@@ -76,7 +76,7 @@ class _HotRestartTracker {
7676
required this.timeoutTimer,
7777
});
7878

79-
bool get isComplete => responses.length >= expectedResponses;
79+
bool get gotAllResponses => responses.length >= expectedResponses;
8080

8181
void addResponse(HotRestartResponse response) {
8282
responses.add(response);
@@ -104,7 +104,7 @@ class _ServiceExtensionTracker {
104104
required this.timeoutTimer,
105105
});
106106

107-
bool get isComplete => responses.length >= expectedResponses;
107+
bool get gotAllResponses => responses.length >= expectedResponses;
108108

109109
void addResponse(ServiceExtensionResponse response) {
110110
responses.add(response);
@@ -543,7 +543,7 @@ class WebSocketProxyService extends ProxyService {
543543

544544
tracker.addResponse(response);
545545

546-
if (tracker.isComplete) {
546+
if (tracker.gotAllResponses) {
547547
_pendingHotReloads.remove(response.id);
548548
tracker.dispose();
549549

@@ -575,7 +575,7 @@ class WebSocketProxyService extends ProxyService {
575575

576576
tracker.addResponse(response);
577577

578-
if (tracker.isComplete) {
578+
if (tracker.gotAllResponses) {
579579
_pendingHotRestarts.remove(response.id);
580580
tracker.dispose();
581581

@@ -812,7 +812,7 @@ class WebSocketProxyService extends ProxyService {
812812

813813
tracker.addResponse(response);
814814

815-
if (tracker.isComplete) {
815+
if (tracker.gotAllResponses) {
816816
_pendingServiceExtensionTrackers.remove(id);
817817
tracker.dispose();
818818

0 commit comments

Comments
 (0)