fix(size): display results even when listing errors occur

Previously, any error during directory enumeration (e.g., a subdirectory
being deleted mid-operation) would cause the size command to exit without
displaying results, even though partial counts were successfully computed.

Remove the early return on error and ensure results are always printed
before returning. The error is still returned for proper exit code
handling, so scripts checking exit status continue to work correctly.

For JSON output, if both Count and JSON encoding fail, the Count error
takes priority as it's more meaningful to the user.

Signed-off-by: Anagh Kumar Baranwal <[email protected]>

Author: darthShadow

cmd/size/size.go

@@ -58,14 +58,19 @@ of the size command.`,
 			}
 
 			results.Count, results.Bytes, results.Sizeless, err = operations.Count(context.Background(), fsrc)
-			if err != nil {
-				return err
-			}
+			// Don't return early on error - always show results
 			if results.Sizeless > 0 {
 				fs.Logf(fsrc, "Size may be underestimated due to %d objects with unknown size", results.Sizeless)
 			}
 			if jsonOutput {
-				return json.NewEncoder(os.Stdout).Encode(results)
+				encErr := json.NewEncoder(os.Stdout).Encode(results)
+				if err != nil {
+					if encErr != nil {
+						fs.Logf(fsrc, "JSON output may be incomplete or corrupted: %v", encErr)
+					}
+					return err
+				}
+				return encErr
 			}
 			count := strconv.FormatInt(results.Count, 10)
 			countSuffix := fs.CountSuffix(results.Count).String()
@@ -78,7 +83,7 @@ of the size command.`,
 			if results.Sizeless > 0 {
 				operations.SyncPrintf("Total objects with unknown size: %s (%d)\n", fs.CountSuffix(results.Sizeless), results.Sizeless)
 			}
-			return nil
+			return err
 		})
 	},
 }