[Extensions] Improve assertions (open-telemetry#2828)

martincostello · web-flow · commit 1eea36be5e4d · 2025-06-12T11:03:29.000-07:00
diff --git a/test/OpenTelemetry.Extensions.Tests/Trace/RateLimitingSamplerTests.cs b/test/OpenTelemetry.Extensions.Tests/Trace/RateLimitingSamplerTests.cs
@@ -102,7 +102,7 @@ public async Task ShouldFilter_WhenAboveRateLimit()
 
         // Assert - We should have sampled in 5 traces per second over duration
         // Adding in a fudge factor
-        Assert.True(sampleIn > (approxSamples * 0.9) && sampleIn < (approxSamples * 1.1));
-        Assert.True(sampleOut == (CYCLES - sampleIn));
+        Assert.InRange(sampleIn, approxSamples * 0.9, approxSamples * 1.1);
+        Assert.Equal(sampleOut, CYCLES - sampleIn);
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -102,7 +102,7 @@ public async Task ShouldFilter_WhenAboveRateLimit()`
`102`	`102`
`103`	`103`	`// Assert - We should have sampled in 5 traces per second over duration`
`104`	`104`	`// Adding in a fudge factor`
`105`		`- Assert.True(sampleIn > (approxSamples * 0.9) && sampleIn < (approxSamples * 1.1));`
`106`		`- Assert.True(sampleOut == (CYCLES - sampleIn));`
	`105`	`+ Assert.InRange(sampleIn, approxSamples * 0.9, approxSamples * 1.1);`
	`106`	`+ Assert.Equal(sampleOut, CYCLES - sampleIn);`
`107`	`107`	`}`
`108`	`108`	`}`