fix --web and --draft interop issue for github cli

Author: dashed

src/main.rs

@@ -2318,10 +2318,14 @@ impl GitChain {
                 println!("Pushed branch {}, creating PR...", branch.branch_name.bold());
 
                 let mut gh_command = Command::new("gh");
-                gh_command.arg("pr").arg("create").arg("--base").arg(base_branch).arg("--head").arg(&branch.branch_name).arg("--web");
+                gh_command.arg("pr").arg("create").arg("--base").arg(base_branch).arg("--head").arg(&branch.branch_name);
 
+                // For draft PRs, we can't use --web flag due to GitHub CLI limitation
+                // Instead, we'll create the draft PR and then open it separately
                 if draft {
                     gh_command.arg("--draft");
+                } else {
+                    gh_command.arg("--web");
                 }
 
                 let output = gh_command.output().unwrap_or_else(|_| {
@@ -2333,6 +2337,26 @@ impl GitChain {
 
                 if output.status.success() {
                     println!("✅ Created PR for {} -> {}", branch.branch_name.bold(), base_branch.bold());
+                    
+                    // If draft mode, open the PR in browser separately
+                    if draft {
+                        let pr_url = String::from_utf8_lossy(&output.stdout).trim().to_string();
+                        if let Some(pr_number) = pr_url.split('/').last() {
+                            let browse_output = Command::new("gh")
+                                .arg("browse")
+                                .arg(pr_number)
+                                .output();
+                            
+                            match browse_output {
+                                Ok(browse_result) if browse_result.status.success() => {
+                                    println!("🌐 Opened draft PR in browser");
+                                }
+                                _ => {
+                                    println!("ℹ️  Draft PR created: {}", pr_url);
+                                }
+                            }
+                        }
+                    }
                 } else {
                     io::stdout().write_all(&output.stdout).unwrap();
                     io::stderr().write_all(&output.stderr).unwrap();

tests/pr.rs

@@ -84,13 +84,20 @@ if [ "$1" = "pr" ] && [ "$2" = "create" ]; then
     if [ "$3" = "--base" ] && [ "$5" = "--head" ] && [ "$7" = "--draft" ]; then
         base="$4"
         head="$6"
-        echo "Creating draft pull request for $head into $base in test/repo"
-        echo ""
+        # Draft PR creation outputs the URL to stdout
         echo "https://github.com/test/repo/pull/999"
         exit 0
     fi
 fi
 
+if [ "$1" = "browse" ]; then
+    # gh browse <PR_NUMBER> - simulate opening PR in browser
+    if [ -n "$2" ]; then
+        echo "Opening https://github.com/test/repo/pull/$2 in your browser."
+        exit 0
+    fi
+fi
+
 # Default error response
 echo "Error: unknown gh command" >&2
 exit 1
@@ -306,14 +313,13 @@ fn test_pr_command_with_draft_flag() {
     println!("EXIT STATUS: {}", output.status);
     println!("======");
 
-    // git-chain continues running even when individual PR creations fail
-    // but it should show the error from gh CLI and report failed PR creation
+    // With the fix, draft PRs should now work successfully
     assert!(output.status.success(), 
-            "git-chain should complete successfully even when individual PRs fail");
-    assert!(stderr.contains("the `--draft` flag is not supported with `--web`"), 
-            "Should show GitHub CLI error about incompatible flags, got: {}", stderr);
-    assert!(stdout.contains("🛑 Failed to create PR for"), 
-            "Should show failed PR creation messages, got: {}", stdout);
+            "Command should succeed with draft flag");
+    assert!(stdout.contains("✅ Created PR for"), 
+            "Should show successful PR creation, got: {}", stdout);
+    assert!(stdout.contains("🌐 Opened draft PR in browser") || stdout.contains("ℹ️  Draft PR created:"), 
+            "Should show browser opening or PR URL, got: {}", stdout);
 
     teardown_git_repo(test_name);
 }
@@ -364,7 +370,7 @@ fn test_gh_cli_not_installed() {
     println!("EXIT STATUS: {}", output.status);
     println!("======");
 
-    // Assertions
+    // Assertions - the command should fail when gh is not installed
     assert!(!output.status.success(), "Command should fail when gh is not installed");
     assert!(stderr.contains("GitHub CLI (gh) is not installed") || 
             stderr.contains("not found in the PATH"),