wip: serialized with signature

Author: coolaj86

bincode.js

@@ -137,7 +137,7 @@ export function Struct(name, inner) {
     name,
     encode(bc, val) {
       for (const innerKey in inner) {
-        console.log(`DEBUG`, name);
+        console.log(`DEBUG Struct ${name}:`, innerKey);
         // const startIdx = bc.idx;
         inner[innerKey].encode(bc, val[innerKey]);
         // console.log('DEBUG:', 'encode', name + '.' + innerKey, '=', val[innerKey], 'at', startIdx, toHex(bc.dataview.buffer.slice(startIdx, bc.idx)));
@@ -524,7 +524,7 @@ export function FixedBytes(length) {
     encode(bc, val) {
       let idx = bc._idxThenAddExtend(length);
       let bytes = new Uint8Array(bc.dataview.buffer);
-        console.log(`DEBUG val, idx`, val, idx);
+      console.log(`DEBUG val, idx`, val, idx);
       bytes.set(val, idx);
     },
     decode(bc) {
@@ -543,10 +543,15 @@ export function NotSignable(inner) {
   return {
     name: "NotSignable<" + inner.name + ">",
     encode(bc, value) {
-      if (!bc.options.signable) inner.encode(bc, value);
+      console.log(`DEBUG NotSignable<${inner.name}>`, bc, value);
+      if (!bc.options.signable) {
+        inner.encode(bc, value);
+      }
     },
     decode(bc) {
-      if (!bc.options.signable) return inner.decode(bc);
+      if (!bc.options.signable) {
+        return inner.decode(bc);
+      }
     },
   };
 }

demo.js

@@ -335,29 +335,42 @@ async function main() {
     signable: true,
   });
   let bc = new Uint8Array(bcAb);
-  console.log(`bc:`);
+  console.log(`bc (ready-to-sign):`);
   console.log(DashTx.utils.bytesToHex(bc));
   console.log(bytesToBase64(bc));
 
   /** @type {Uint8Array} */ //@ts-expect-error
   let privBytes = addressKey.privateKey;
   let sigBytes = await KeyUtils.sign(privBytes, bc);
-  let sigHex = DashTx.utils.bytesToHex(sigBytes);
+  // let sigHex = DashTx.utils.bytesToHex(sigBytes);
   Object.assign(stateTransition, {
-    signature: sigHex,
+    identity_id: identityId,
+    // signature: sigHex,
+    signature: sigBytes,
   });
   for (let i = 0; i < identityKeys.length; i += 1) {
     let key = identityKeys[i];
     let stPub = stateTransition.public_keys[i];
     let sigBytes = await KeyUtils.sign(key.privateKey, bc);
-    let sigHex = DashTx.utils.bytesToHex(sigBytes);
+    // let sigHex = DashTx.utils.bytesToHex(sigBytes);
     Object.assign(stPub, {
-      signature: sigHex,
+      // signature: sigHex,
+      signature: sigBytes,
     });
   }
 
   console.log(JSON.stringify(stateTransition, null, 2));
 
+  {
+    let bcAb = Bincode.encode(Bincode.StateTransition, stateTransition, {
+      signable: false,
+    });
+    let bc = new Uint8Array(bcAb);
+    console.log(`bc (signed):`);
+    console.log(DashTx.utils.bytesToHex(bc));
+    console.log(bytesToBase64(bc));
+  }
+
   // let identityId = assetLockProof.createIdentifier();
   // let identity = Dpp.identity.create(identityId, dppKeys);
   // let signedTransition = signTransition(
@@ -390,8 +403,9 @@ async function getFundingOutPointHex(txSignedHex, outputIndex) {
 function createIdentityId(fundingOutPointHex) {
   let fundingOutPointBytes = DashTx.utils.hexToBytes(fundingOutPointHex);
   let identityHashBytes = DashTx.doubleSha256(fundingOutPointBytes);
-  let identityId = b58.encode(identityHashBytes);
-  return identityId;
+  // let identityId = b58.encode(identityHashBytes);
+  // return identityId;
+  return identityHashBytes;
 }
 
 /**