Skip to content

Commit 3be3c1d

Browse files
trivial: use WITH_LOCK when possible (dashpay#5879)
1 parent c5fcab9 commit 3be3c1d

File tree

1 file changed

+2
-6
lines changed

1 file changed

+2
-6
lines changed

src/llmq/ehf_signals.cpp

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -70,8 +70,7 @@ void CEHFSignalsHandler::trySignEHFSignal(int bit, const CBlockIndex* const pind
7070
return;
7171
}
7272
if (sigman.HasRecoveredSigForId(llmqType, requestId)) {
73-
LOCK(cs);
74-
ids.insert(requestId);
73+
WITH_LOCK(cs, ids.insert(requestId));
7574

7675
LogPrint(BCLog::EHF, "CEHFSignalsHandler::trySignEHFSignal: already signed bit=%d at height=%d id=%s\n", bit, pindex->nHeight, requestId.ToString());
7776
// no need to sign same message one more time
@@ -88,10 +87,7 @@ void CEHFSignalsHandler::trySignEHFSignal(int bit, const CBlockIndex* const pind
8887
mnhfPayload.signal.quorumHash = quorum->qc->quorumHash;
8988
const uint256 msgHash = mnhfPayload.PrepareTx().GetHash();
9089

91-
{
92-
LOCK(cs);
93-
ids.insert(requestId);
94-
}
90+
WITH_LOCK(cs, ids.insert(requestId));
9591
sigman.AsyncSignIfMember(llmqType, shareman, requestId, msgHash);
9692
}
9793

0 commit comments

Comments
 (0)