Skip to content

Commit 9f80734

Browse files
kwvgPastaPastaPasta
authored andcommitted
merge bitcoin#26065: use the same destination type for transient and persistent addresses
1 parent 9bf3829 commit 9f80734

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

src/i2p.cpp

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -326,6 +326,7 @@ void Session::DestGenerate(const Sock& sock)
326326
// https://geti2p.net/spec/common-structures#key-certificates
327327
// "7" or "EdDSA_SHA512_Ed25519" - "Recent Router Identities and Destinations".
328328
// Use "7" because i2pd <2.24.0 does not recognize the textual form.
329+
// If SIGNATURE_TYPE is not specified, then the default one is DSA_SHA1.
329330
const Reply& reply = SendRequestAndGetReply(sock, "DEST GENERATE SIGNATURE_TYPE=7", false);
330331

331332
m_private_key = DecodeI2PBase64(reply.Get("PRIV"));
@@ -379,7 +380,7 @@ void Session::CreateIfNotCreatedAlready()
379380
// in the reply in DESTINATION=.
380381
const Reply& reply = SendRequestAndGetReply(
381382
*sock,
382-
strprintf("SESSION CREATE STYLE=STREAM ID=%s DESTINATION=TRANSIENT", session_id));
383+
strprintf("SESSION CREATE STYLE=STREAM ID=%s DESTINATION=TRANSIENT SIGNATURE_TYPE=7", session_id));
383384

384385
m_private_key = DecodeI2PBase64(reply.Get("DESTINATION"));
385386
} else {

0 commit comments

Comments
 (0)