chore: update list of circular dependencies

It is partial de-circularisation of dependencies between that includes net_processing

Classes that still depends on net_processing but should not:
 - llmq/dkgsessionmgr
 - llmq/signing
 - llmq/instantsend

They have asynchronous processing and with current impl that's impossible to do

Author: knst

test/lint/lint-circular-dependencies.sh

@@ -24,20 +24,18 @@ EXPECTED_CIRCULAR_DEPENDENCIES=(
     "wallet/wallet -> wallet/walletdb -> wallet/wallet"
     "node/coinstats -> validation -> node/coinstats"
     # Dash
-    "coinjoin/server -> net_processing -> coinjoin/server"
+    "coinjoin/server -> core_io -> evo/assetlocktx -> llmq/signing -> net_processing -> coinjoin/server"
+    "coinjoin/coinjoin -> llmq/instantsend -> net_processing -> coinjoin/server -> coinjoin/coinjoin"
     "dsnotificationinterface -> llmq/chainlocks -> node/blockstorage -> dsnotificationinterface"
     "evo/cbtx -> evo/simplifiedmns -> evo/cbtx"
     "evo/deterministicmns -> llmq/commitment -> evo/deterministicmns"
     "evo/deterministicmns -> llmq/utils -> evo/deterministicmns"
-    "evo/mnauth -> net_processing -> evo/mnauth"
     "governance/classes -> governance/governance -> governance/classes"
     "governance/governance -> governance/object -> governance/governance"
     "governance/governance -> masternode/sync -> governance/governance"
-    "governance/governance -> net_processing -> governance/governance"
     "llmq/quorums -> llmq/utils -> llmq/quorums"
-    "llmq/blockprocessor -> net_processing -> llmq/blockprocessor"
     "llmq/chainlocks -> llmq/instantsend -> llmq/chainlocks"
-    "llmq/chainlocks -> net_processing -> llmq/chainlocks"
+    "llmq/chainlocks -> llmq/instantsend -> net_processing -> llmq/chainlocks"
     "llmq/dkgsessionmgr -> net_processing -> llmq/dkgsessionmgr"
     "llmq/instantsend -> net_processing -> llmq/instantsend"
     "llmq/instantsend -> txmempool -> llmq/instantsend"
@@ -49,45 +47,40 @@ EXPECTED_CIRCULAR_DEPENDENCIES=(
     "masternode/payments -> validation -> masternode/payments"
     "masternode/sync -> validation -> masternode/sync"
     "net -> netmessagemaker -> net"
-    "net_processing -> spork -> net_processing"
     "netaddress -> netbase -> netaddress"
     "qt/appearancewidget -> qt/guiutil -> qt/appearancewidget"
     "qt/bitcoinaddressvalidator -> qt/guiutil -> qt/bitcoinaddressvalidator"
     "qt/bitcoingui -> qt/guiutil -> qt/bitcoingui"
     "qt/guiutil -> qt/optionsdialog -> qt/guiutil"
     "qt/guiutil -> qt/qvalidatedlineedit -> qt/guiutil"
     "core_io -> evo/cbtx -> evo/simplifiedmns -> core_io"
-    "evo/simplifiedmns -> llmq/blockprocessor -> net_processing -> evo/simplifiedmns"
+    "core_io -> evo/assetlocktx -> llmq/signing -> net_processing -> governance/governance -> governance/object -> core_io"
     "llmq/dkgsession -> llmq/dkgsessionmgr -> llmq/dkgsessionhandler -> llmq/dkgsession"
     "logging -> util/system -> sync -> logging"
     "logging -> util/system -> stacktraces -> logging"
     "logging -> util/system -> util/getuniquepath -> random -> logging"
-    "coinjoin/client -> net_processing -> coinjoin/context -> coinjoin/client"
-    "coinjoin/context -> coinjoin/server -> net_processing -> coinjoin/context"
+    "coinjoin/context -> coinjoin/server -> core_io -> evo/assetlocktx -> llmq/signing -> net_processing -> coinjoin/context"
     "qt/appearancewidget -> qt/guiutil -> qt/optionsdialog -> qt/appearancewidget"
     "qt/guiutil -> qt/optionsdialog -> qt/optionsmodel -> qt/guiutil"
 
     "bloom -> evo/assetlocktx -> llmq/quorums -> net -> bloom"
+    "bloom -> evo/assetlocktx -> llmq/signing -> net_processing -> governance/governance -> bloom"
+    "bloom -> evo/assetlocktx -> llmq/signing -> net_processing -> merkleblock -> bloom"
     "banman -> bloom -> evo/assetlocktx -> llmq/quorums -> net -> banman"
-    "banman -> bloom -> evo/assetlocktx -> llmq/quorums -> net_processing -> banman"
-    "bloom -> evo/assetlocktx -> llmq/quorums -> net_processing -> merkleblock -> bloom"
+    "banman -> bloom -> evo/assetlocktx -> llmq/signing -> net_processing -> banman"
 
-    "coinjoin/client -> net_processing -> coinjoin/client"
-    "llmq/quorums -> net_processing -> llmq/quorums"
+    "coinjoin/client -> coinjoin/coinjoin -> llmq/instantsend -> net_processing -> coinjoin/client"
+    "coinjoin/client -> coinjoin/coinjoin -> llmq/instantsend -> net_processing -> coinjoin/context -> coinjoin/client"
     "llmq/dkgsession -> llmq/dkgsessionmgr -> llmq/dkgsession"
     "llmq/chainlocks -> validation -> llmq/chainlocks"
     "coinjoin/coinjoin -> llmq/chainlocks -> net -> coinjoin/coinjoin"
     "evo/deterministicmns -> llmq/utils -> net -> evo/deterministicmns"
     "policy/policy -> policy/settings -> policy/policy"
     "evo/specialtxman -> validation -> evo/specialtxman"
     "consensus/tx_verify -> evo/assetlocktx -> validation -> consensus/tx_verify"
-    "consensus/tx_verify -> evo/assetlocktx -> llmq/quorums -> net_processing -> txmempool -> consensus/tx_verify"
-    "evo/assetlocktx -> llmq/quorums -> net_processing -> txmempool -> evo/assetlocktx"
+    "consensus/tx_verify -> evo/assetlocktx -> llmq/signing -> net_processing -> txmempool -> consensus/tx_verify"
+    "evo/assetlocktx -> llmq/signing -> net_processing -> txmempool -> evo/assetlocktx"
 
-    "evo/simplifiedmns -> llmq/blockprocessor -> net_processing -> llmq/snapshot -> evo/simplifiedmns"
-    "llmq/blockprocessor -> net_processing -> llmq/context -> llmq/blockprocessor"
-    "llmq/blockprocessor -> net_processing -> llmq/snapshot -> llmq/blockprocessor"
-    "llmq/chainlocks -> net_processing -> llmq/context -> llmq/chainlocks"
     "llmq/context -> llmq/dkgsessionmgr -> net_processing -> llmq/context"
     "llmq/dkgsession -> llmq/dkgsessionmgr -> llmq/quorums -> llmq/dkgsession"
     "llmq/dkgsessionmgr -> llmq/quorums -> llmq/dkgsessionmgr"