Skip to content

Commit aaa83ae

Browse files
laanwjPastaPastaPasta
authored andcommitted
Merge bitcoin#25165: doc: Explain squashing with merge commits
fa2d226 doc: Explain squashing with merge commits (MacroFake) Pull request description: This avoids having to explain it in each thread ACKs for top commit: laanwj: ACK fa2d226 Tree-SHA512: e1533ee7c0ab0101c78aaebed97dc889b5eb941cf4c2dfbabbb5f0ec1bb7b1313a1a2e2405235d68c761f039373cebac67ce691a72c820a9252429d50c1ac7d5
1 parent ef13101 commit aaa83ae

File tree

1 file changed

+6
-4
lines changed

1 file changed

+6
-4
lines changed

CONTRIBUTING.md

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -190,9 +190,9 @@ Please update the resulting commit message, if needed. It should read as a
190190
coherent message. In most cases, this means not just listing the interim
191191
commits.
192192

193-
If you have problems with squashing or other git workflows, you can enable
194-
"Allow edits from maintainers" in the right-hand sidebar of the GitHub web
195-
interface and ask for help in the pull request.
193+
If your change contains a merge commit, the above workflow may not work and you
194+
will need to remove the merge commit first. See the next section for details on
195+
how to rebase.
196196

197197
Please refrain from creating several pull requests for the same change.
198198
Use the pull request that is already open (or was created earlier) to amend
@@ -205,7 +205,9 @@ pull request to pull request.
205205
### Rebasing Changes
206206

207207
When a pull request conflicts with the target branch, you may be asked to rebase it on top of the current target branch.
208-
The `git rebase` command will take care of rebuilding your commits on top of the new base.
208+
209+
git fetch https://github.com/bitcoin/bitcoin # Fetch the latest upstream commit
210+
git rebase FETCH_HEAD # Rebuild commits on top of the new base
209211

210212
Avoid rebasing a non-conflicting pull request on top of the updated target
211213
branch if you requested a review already. If you need to tweak some commit in

0 commit comments

Comments
 (0)