qt: add interface for CGovernanceObject querying

The GetAbsoluteYesCount -> Get{Yes,No}Count -> CountMatchingVotes call
chain eventually results in needing to call GetListAtChainTip from the
CDeterministicMNManager instance.

Currently it's being accessed as a global but future deglobalization
will move fetching the CDeterministicMNList outside CGovernanceObject,
requiring an instance of CDeterministicMNManager.

In preparation of that, these changes are being made in advance.

Author: kwvg

src/governance/vote.h

@@ -16,7 +16,7 @@ class CKey;
 class CKeyID;
 
 // INTENTION OF MASTERNODES REGARDING ITEM
-enum vote_outcome_enum_t {
+enum vote_outcome_enum_t : uint8_t {
     VOTE_OUTCOME_NONE      = 0,
     VOTE_OUTCOME_YES       = 1,
     VOTE_OUTCOME_NO        = 2,
@@ -25,7 +25,7 @@ enum vote_outcome_enum_t {
 
 
 // SIGNAL VARIOUS THINGS TO HAPPEN:
-enum vote_signal_enum_t {
+enum vote_signal_enum_t : uint8_t {
     VOTE_SIGNAL_NONE       = 0,
     VOTE_SIGNAL_FUNDING    = 1, //   -- fund this object for it's stated amount
     VOTE_SIGNAL_VALID      = 2, //   -- this object checks out in sentinel engine

src/interfaces/node.h

@@ -37,6 +37,8 @@ enum class SynchronizationState;
 struct CNodeStateStats;
 struct NodeContext;
 
+enum vote_signal_enum_t : uint8_t;
+
 namespace interfaces {
 class Handler;
 class WalletLoader;
@@ -59,6 +61,8 @@ class GOV
 public:
     virtual ~GOV() {}
     virtual void getAllNewerThan(std::vector<CGovernanceObject> &objs, int64_t nMoreThanTime) = 0;
+    virtual int32_t getObjAbsYesCount(const CGovernanceObject& obj, vote_signal_enum_t vote_signal) = 0;
+    virtual bool getObjLocalValidity(const CGovernanceObject& obj, std::string& error, bool check_collateral) = 0;
 };
 
 //! Interface for the src/llmq part of a dash node (dashd process).

src/node/interfaces.cpp

@@ -100,8 +100,29 @@ class GOVImpl : public GOV
 public:
     void getAllNewerThan(std::vector<CGovernanceObject> &objs, int64_t nMoreThanTime) override
     {
-        if (governance == nullptr) return;
-        governance->GetAllNewerThan(objs, nMoreThanTime);
+        if (::governance != nullptr) {
+            return ::governance->GetAllNewerThan(objs, nMoreThanTime);
+        }
+        return;
+    }
+    int32_t getObjAbsYesCount(const CGovernanceObject& obj, vote_signal_enum_t vote_signal) override
+    {
+        // TODO: Move GetListAtChainTip query outside CGovernanceObject, query requires
+        //       active CDeterministicMNManager instance
+        if (::governance != nullptr && ::deterministicMNManager != nullptr) {
+            return obj.GetAbsoluteYesCount(vote_signal);
+        }
+        return 0;
+    }
+    bool getObjLocalValidity(const CGovernanceObject& obj, std::string& error, bool check_collateral) override
+    {
+        // TODO: Move GetListAtChainTip query outside CGovernanceObject, query requires
+        //       active CDeterministicMNManager instance
+        if (::governance != nullptr && ::deterministicMNManager != nullptr) {
+            LOCK(cs_main);
+            return obj.IsValidLocally(error, check_collateral);
+        }
+        return false;
     }
 };
 

src/qt/governancelist.cpp

@@ -26,8 +26,9 @@
 /// Proposal wrapper
 ///
 
-Proposal::Proposal(const CGovernanceObject& _govObj, QObject* parent) :
+Proposal::Proposal(ClientModel* _clientModel, const CGovernanceObject& _govObj, QObject* parent) :
     QObject(parent),
+    clientModel(_clientModel),
     govObj(_govObj)
 {
     UniValue prop_data;
@@ -68,17 +69,16 @@ QString Proposal::url() const { return m_url; }
 
 bool Proposal::isActive() const
 {
-    LOCK(cs_main);
     std::string strError;
-    return govObj.IsValidLocally(strError, false);
+    return clientModel->node().gov().getObjLocalValidity(govObj, strError, false);
 }
 
 QString Proposal::votingStatus(const int nAbsVoteReq) const
 {
     // Voting status...
     // TODO: determine if voting is in progress vs. funded or not funded for past proposals.
     // see CSuperblock::GetNearestSuperblocksHeights(nBlockHeight, nLastSuperblock, nNextSuperblock);
-    const int absYesCount = govObj.GetAbsoluteYesCount(VOTE_SIGNAL_FUNDING);
+    const int absYesCount = clientModel->node().gov().getObjAbsYesCount(govObj, VOTE_SIGNAL_FUNDING);
     QString qStatusString;
     if (absYesCount >= nAbsVoteReq) {
         // Could use govObj.IsSetCachedFunding here, but need nAbsVoteReq to display numbers anyway.
@@ -90,7 +90,7 @@ QString Proposal::votingStatus(const int nAbsVoteReq) const
 
 int Proposal::GetAbsoluteYesCount() const
 {
-    return govObj.GetAbsoluteYesCount(VOTE_SIGNAL_FUNDING);
+    return clientModel->node().gov().getObjAbsYesCount(govObj, VOTE_SIGNAL_FUNDING);
 }
 
 void Proposal::openUrl() const
@@ -360,7 +360,7 @@ void GovernanceList::updateProposalList()
                 continue; // Skip triggers.
             }
 
-            newProposals.emplace_back(new Proposal(govObj, proposalModel));
+            newProposals.emplace_back(new Proposal(this->clientModel, govObj, proposalModel));
         }
         proposalModel->reconcile(newProposals);
     }

src/qt/governancelist.h

@@ -59,15 +59,17 @@ class Proposal : public QObject
 private:
     Q_OBJECT
 
+    ClientModel* clientModel;
     const CGovernanceObject govObj;
+
     QString m_title;
     QDateTime m_startDate;
     QDateTime m_endDate;
     float m_paymentAmount;
     QString m_url;
 
 public:
-    explicit Proposal(const CGovernanceObject& _govObj, QObject* parent = nullptr);
+    explicit Proposal(ClientModel* _clientModel, const CGovernanceObject& _govObj, QObject* parent = nullptr);
     QString title() const;
     QString hash() const;
     QDateTime startDate() const;