Skip to content

Commit c617d4a

Browse files
Merge dashpay#5992: fix(qt): remove stretchers from Overview page when it's not needed
b9a2ce7 fix: remove stretching from Overview page when it's not needed (Konstantin Akimov) Pull request description: ## Issue being fixed or feature implemented Overview page has strange stretching on sides, which make balance moving left-right when window is scalled. ![image](https://github.com/dashpay/dash/assets/545784/a2b3332a-55f4-4abc-a96f-9ca6c1184360) ![image](https://github.com/dashpay/dash/assets/545784/1b8e7eca-d0db-4574-a337-096bfa645242) ## What was done? Removed stretches for Overview Page from the sides, it makes window a little more balanced. This PR lets to do backport of bitcoin-core/gui#176 which improves behavior further more be increasing size of "transaction list" part of window. ## How Has This Been Tested? See screenshot. Resized window with/without patch, in "Discreet mode" off and on. Both looks not perfect but better than before. ## Breaking Changes N/A ## Checklist: - [x] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have added or updated relevant unit/integration/functional/e2e tests - [ ] I have made corresponding changes to the documentation - [x] I have assigned this pull request to a milestone Top commit has no ACKs. Tree-SHA512: f599f4f40986b37c3c9a8c36e2146bdf7b8e38d15a6f65f26fec4e30440ab54d07ea1f36a2b11e48a6dc3bcd64ececd3c4da6255fc6c9f58fba2a4abb2221b8d
2 parents a8cfd70 + b9a2ce7 commit c617d4a

File tree

1 file changed

+1
-46
lines changed

1 file changed

+1
-46
lines changed

src/qt/forms/overviewpage.ui

Lines changed: 1 addition & 46 deletions
Original file line numberDiff line numberDiff line change
@@ -37,23 +37,7 @@
3737
</widget>
3838
</item>
3939
<item>
40-
<layout class="QHBoxLayout" name="horizontalLayout" stretch="1,0,1,0,1">
41-
<item>
42-
<spacer name="horizontalSpacerLeft">
43-
<property name="orientation">
44-
<enum>Qt::Horizontal</enum>
45-
</property>
46-
<property name="sizeType">
47-
<enum>QSizePolicy::Preferred</enum>
48-
</property>
49-
<property name="sizeHint" stdset="0">
50-
<size>
51-
<width>10</width>
52-
<height>20</height>
53-
</size>
54-
</property>
55-
</spacer>
56-
</item>
40+
<layout class="QHBoxLayout" name="horizontalLayout" stretch="0,0">
5741
<item>
5842
<layout class="QVBoxLayout" name="verticalLayout_2">
5943
<item>
@@ -576,19 +560,6 @@
576560
</item>
577561
</layout>
578562
</item>
579-
<item>
580-
<spacer name="horizontalSpacerCenter">
581-
<property name="orientation">
582-
<enum>Qt::Horizontal</enum>
583-
</property>
584-
<property name="sizeHint" stdset="0">
585-
<size>
586-
<width>10</width>
587-
<height>20</height>
588-
</size>
589-
</property>
590-
</spacer>
591-
</item>
592563
<item>
593564
<layout class="QVBoxLayout" name="verticalLayout_3">
594565
<item>
@@ -658,22 +629,6 @@
658629
</item>
659630
</layout>
660631
</item>
661-
<item>
662-
<spacer name="horizontalSpacerRight">
663-
<property name="orientation">
664-
<enum>Qt::Horizontal</enum>
665-
</property>
666-
<property name="sizeType">
667-
<enum>QSizePolicy::Preferred</enum>
668-
</property>
669-
<property name="sizeHint" stdset="0">
670-
<size>
671-
<width>10</width>
672-
<height>20</height>
673-
</size>
674-
</property>
675-
</spacer>
676-
</item>
677632
</layout>
678633
</item>
679634
</layout>

0 commit comments

Comments
 (0)