Skip to content

Commit eeec2f2

Browse files
fanquakeknst
authored andcommitted
Merge bitcoin#21884: fuzz: Remove unused --enable-danger-fuzz-link-all option
fa27d6d fuzz: Remove unused --enable-danger-fuzz-link-all option (MarcoFalke) Pull request description: Remove the unused build option, which was *dangerous* (as the name implies). Also remove the fuzzbuzz config, which was never used as part of this repo and seems redundant now that we integrate with oss-fuzz. ACKs for top commit: practicalswift: cr ACK fa27d6d: patch looks correct and rationale makes sense hebasto: ACK fa27d6d, I have reviewed the code and it looks OK, I agree it can be merged. Tree-SHA512: 9bd65ed6a76d13d8d9c7a88aaae30f701215d5d0619693a3115d5ec350808aaf6a1aa4737466a5b96f3948513ec4d063808fe16219818366720e247880a15177
1 parent 51633d7 commit eeec2f2

File tree

4 files changed

+0
-56
lines changed

4 files changed

+0
-56
lines changed

.fuzzbuzz.yml

Lines changed: 0 additions & 16 deletions
This file was deleted.

configure.ac

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -185,12 +185,6 @@ AC_ARG_ENABLE([fuzz-binary],
185185
[enable_fuzz_binary=$enableval],
186186
[enable_fuzz_binary=yes])
187187

188-
AC_ARG_ENABLE([danger_fuzz_link_all],
189-
AS_HELP_STRING([--enable-danger-fuzz-link-all],
190-
[Danger! Modifies source code. Needs git and gnu sed installed. Link each fuzz target (default no).]),
191-
[enable_danger_fuzz_link_all=$enableval],
192-
[enable_danger_fuzz_link_all=no])
193-
194188
AC_ARG_WITH([qrencode],
195189
[AS_HELP_STRING([--with-qrencode],
196190
[enable QR code support (default is yes if qt is enabled and libqrencode is found)])],
@@ -1818,7 +1812,6 @@ AM_CONDITIONAL([ENABLE_TRACING],[test x$have_sdt = xyes])
18181812
AM_CONDITIONAL([ENABLE_TESTS],[test x$BUILD_TEST = xyes])
18191813
AM_CONDITIONAL([ENABLE_FUZZ],[test x$enable_fuzz = xyes])
18201814
AM_CONDITIONAL([ENABLE_FUZZ_BINARY],[test x$enable_fuzz_binary = xyes])
1821-
AM_CONDITIONAL([ENABLE_FUZZ_LINK_ALL],[test x$enable_danger_fuzz_link_all = xyes])
18221815
AM_CONDITIONAL([ENABLE_QT],[test x$bitcoin_enable_qt = xyes])
18231816
AM_CONDITIONAL([ENABLE_QT_TESTS],[test x$BUILD_TEST_QT = xyes])
18241817
AM_CONDITIONAL([ENABLE_BENCH],[test x$use_bench = xyes])

src/Makefile.test.include

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -398,11 +398,6 @@ univalue_test_object_CPPFLAGS = -I$(srcdir)/$(UNIVALUE_INCLUDE_DIR_INT)
398398
univalue_test_object_LDFLAGS = -static $(LIBTOOL_APP_LDFLAGS)
399399
endif
400400

401-
if ENABLE_FUZZ_LINK_ALL
402-
all-local: $(FUZZ_BINARY)
403-
bash ./test/fuzz/danger_link_all.sh
404-
endif
405-
406401
%.cpp.test: %.cpp
407402
@echo Running tests: $$(\
408403
cat $< | \

src/test/fuzz/danger_link_all.sh

Lines changed: 0 additions & 28 deletions
This file was deleted.

0 commit comments

Comments
 (0)