forked from dashpay/dash
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit f542e8e
committed
Merge dashpay#6076: refactor: use new type of composite commands for governance NNN
91aae7b refactor: use properly RPCHelpMan for governance RPC getsuperblockbudget (Konstantin Akimov)
e92e5ef refactor: use properly RPCHelpMan for governance RPC voteraw (Konstantin Akimov)
87b3011 refactor: duplicated code between governance RPC list and diff (Konstantin Akimov)
faa6179 docs: move comments from the old code to the new implementation of governance RPC (Konstantin Akimov)
39cd5e4 fix: format code for rpc governance (Konstantin Akimov)
0062421 refactor: use new style of composite commands for RPC gobject NNN (Konstantin Akimov)
42e0b37 refactor: use properly RPCHelpMan for governance RPC getgovernanceinfo (Konstantin Akimov)
Pull request description:
## Issue being fixed or feature implemented
See dashpay#6051
## What was done?
Commands starting from 'governance ...' uses new a new way to make composite commands.
This PR includes also a refactoring to remove common code between `gobject list` and `gobject diff`
This PR includes also a refactoring to properly use RPCHelpMan for remaining governance's RPC.
## How Has This Been Tested?
Run unit/functional tests.
## Breaking Changes
N/A
## Checklist:
- [x] I have performed a self-review of my own code
- [x] I have commented my code, particularly in hard-to-understand areas
- [x] I have added or updated relevant unit/integration/functional/e2e tests
- [ ] I have made corresponding changes to the documentation
- [x] I have assigned this pull request to a milestone
ACKs for top commit:
UdjinM6:
utACK 91aae7b
PastaPastaPasta:
utACK 91aae7b
Tree-SHA512: 46c00df924a7d2c5af799c605bfc479034019eed346f9d487827b0688993aa712ba3dc528d9bdd09b64f0e07b6940078337ca1baf0a1355f87eb792406c676caFile tree
Expand file treeCollapse file tree
1 file changed
+139
-206
lines changedFilter options
- src/rpc
Expand file treeCollapse file tree
1 file changed
+139
-206
lines changed
0 commit comments