Skip to content

Commit fab41fd

Browse files
laanwjknst
authored andcommitted
partial Merge bitcoin#18878: test: Add test for conflicted wallet tx notifications
Backport notice: we don't have bumpfee feature, so, only some part of code is backported f963a68 test: Add test for conflicted wallet tx notifications (Russell Yanofsky) Pull request description: Add test coverage for conflicted wallet transaction notifications so we can improve current behavior and avoid future regressions bitcoin#9240 - accidental break bitcoin#9479 - bug report bitcoin#9371 - fix bitcoin#16624 - accidental break bitcoin#18325 - bug report bitcoin#18600 - potential fix ACKs for top commit: laanwj: ACK f963a68 jonatack: re-ACK f963a68 MarcoFalke: ACK f963a68 Tree-SHA512: d3a7952a2d3dc2ff0800ef857575ea4ef9759c0917d58a7fc91e2db0ca3cc3baf0dd0cf9af61683f691e5fefb11afe8120bb5810c7037ed9ecedee385dd4aa07 fixup dashify of feature_notifications
1 parent db5bd34 commit fab41fd

File tree

1 file changed

+5
-0
lines changed

1 file changed

+5
-0
lines changed

test/functional/feature_notifications.py

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@
77
import os
88

99
from test_framework.address import ADDRESS_BCRT1_UNSPENDABLE
10+
1011
from test_framework.test_framework import DashTestFramework
1112
from test_framework.util import (
1213
assert_equal,
@@ -95,6 +96,9 @@ def run_test(self):
9596
# directory content should equal the generated transaction hashes
9697
txids_rpc = list(map(lambda t: notify_outputname(self.wallet, t['txid']), self.nodes[1].listtransactions("*", block_count)))
9798
assert_equal(sorted(txids_rpc), sorted(os.listdir(self.walletnotify_dir)))
99+
for tx_file in os.listdir(self.walletnotify_dir):
100+
os.remove(os.path.join(self.walletnotify_dir, tx_file))
101+
98102

99103
self.log.info("test -chainlocknotify")
100104

@@ -141,5 +145,6 @@ def run_test(self):
141145

142146
# TODO: add test for `-alertnotify` large fork notifications
143147

148+
144149
if __name__ == '__main__':
145150
NotificationsTest().main()

0 commit comments

Comments
 (0)