feat: signed dmg for mac (#437)

* feat: signed mac binaries and dmg

* fix

* fix

* extra check

* app bundle

* fix

* fix icon

* feat: simplify icon padding to 3% for correct sizing

* ok

* ok

* fmt

* fix: split dmgs into arm64 and x86 instead of universal

* cleanup

* fmt

* fix naming

* ok

* fix

* disk space fix

* fix

* fix

* fix attempt

* fix: enhance disk space cleanup for macOS DMG creation

- Add more aggressive cleanup of Xcode caches and derived data
- Remove additional Cargo build artifacts (.rlib, .d files)
- Clean system-level caches to free maximum space
- Add cleanup step for both ARM64 and x86_64 macOS builds
- Remove temporary icon files after app bundle creation

This should resolve the "No space left on device" error during DMG creation
on GitHub Actions runners.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>

* macos-latest

* latest for arm too

* revert

* re-revert

* clear cache

* fix

* cleanup

* try large

* omg

* apply suggestion

* cleanup

* fix

* fix

* fix

---------

Co-authored-by: Claude <[email protected]>

Author: pauldelucia

.github/workflows/release.yml

@@ -74,6 +74,9 @@ raw-cpuid = "11.5.0"
 tempfile = { version = "3.20.0" }
 egui_kittest = { version = "0.32.0", features = ["eframe"] }
 
+[build-dependencies]
+winres = "0.1"
+
 [lints.clippy]
 uninlined_format_args = "allow"
 

Cargo.lock

@@ -0,0 +1,39 @@
+use std::env;
+use std::path::Path;
+
+fn main() {
+    println!("cargo:rerun-if-changed=assets/DET_LOGO.ico");
+
+    let target = env::var("TARGET").unwrap_or_default();
+    if !target.contains("windows") {
+        return;
+    }
+
+    let icon_path = Path::new("assets/DET_LOGO.ico");
+    if !icon_path.exists() {
+        eprintln!(
+            "cargo:warning=Windows icon asset missing at {}",
+            icon_path.display()
+        );
+        return;
+    }
+
+    let mut res = winres::WindowsResource::new();
+    let icon_str = icon_path
+        .to_str()
+        .expect("icon path must be valid UTF-8 for the resource compiler");
+    res.set_icon(icon_str);
+
+    if let Ok(version) = env::var("CARGO_PKG_VERSION") {
+        res.set("FileVersion", &version);
+        res.set("ProductVersion", &version);
+    }
+
+    if let Ok(product_name) = env::var("CARGO_PKG_NAME") {
+        res.set("ProductName", &product_name);
+    }
+
+    if let Err(err) = res.compile() {
+        panic!("Failed to embed Windows resources: {err}");
+    }
+}

Cargo.toml

@@ -344,19 +344,27 @@ impl CoreZMQListener {
                                             let mut cursor = Cursor::new(data_bytes);
                                             match Block::consensus_decode(&mut cursor) {
                                                 Ok(block) => {
-                                                    if let Some(ref tx) = tx_zmq_status {
-                                                        // ZMQ refresh socket connected status
-                                                        tx.send(ZMQConnectionEvent::Connected)
-                                                            .expect("Failed to send connected event");
-                                                    }
-                                                    if let Err(e) = sender.send((
-                                                        ZMQMessage::ChainLockedBlock(block),
-                                                        network,
-                                                    )) {
-                                                        eprintln!(
-                                                            "Error sending data to main thread: {}",
-                                                            e
-                                                        );
+                                                    match ChainLock::consensus_decode(&mut cursor) {
+                                                        Ok(chain_lock) => {
+                                                            // Send the ChainLock and Network back to the main thread
+                                                            if let Err(e) = sender.send((
+                                                                ZMQMessage::ChainLockedBlock(
+                                                                    block, chain_lock,
+                                                                ),
+                                                                network,
+                                                            )) {
+                                                                eprintln!(
+                                                                    "Error sending data to main thread: {}",
+                                                                    e
+                                                                );
+                                                            }
+                                                        }
+                                                        Err(e) => {
+                                                            eprintln!(
+                                                                "Error deserializing ChainLock: {}",
+                                                                e
+                                                            );
+                                                        }
                                                     }
                                                 }
                                                 Err(e) => {

assets/DET_LOGO.png

@@ -25,11 +25,28 @@ fn main() -> eframe::Result<()> {
     runtime.block_on(start(&app_data_dir))
 }
 
+fn load_icon() -> egui::IconData {
+    let icon_bytes = include_bytes!("../assets/DET_LOGO.png");
+    let image = image::load_from_memory(icon_bytes)
+        .expect("Failed to load icon")
+        .to_rgba8();
+    let (width, height) = image.dimensions();
+    egui::IconData {
+        rgba: image.into_raw(),
+        width,
+        height,
+    }
+}
+
 async fn start(app_data_dir: &std::path::Path) -> Result<(), eframe::Error> {
+    // Load icon for the window
+    let icon_data = load_icon();
+
     let native_options = eframe::NativeOptions {
         persist_window: true, // Persist window size and position
         centered: true,       // Center window on startup if not maximized
         persistence_path: Some(app_data_dir.join("app.ron")),
+        viewport: egui::ViewportBuilder::default().with_icon(icon_data),
         ..Default::default()
     };