Merge #6690: feat(qt): add governance voting functionality to Qt wallet

cf4e9e6 fix: move CGovernanceVote inline methods to header for wallet linkage (pasta)
6f0723a chore: run clang-format (pasta)
2db939e fix: address PR review comments (pasta)
bd0f59e feat(governance): implement SignGovernanceVote method in CWallet for vote signing (pasta)
13b4117 feat(governance): refactor vote signing logic into a helper function (pasta)
778a0b1 feat(gui): add tooltip for masternode count display in governance tab (pasta)
81d6648 chore: apply clang-format (pasta)
edfe1ee refactor(governance): avoid recursion in wallet unlock handling (pasta)
24240a6 docs: add release notes for governance voting GUI feature (pasta)
0caee40 feat(gui): add masternode count display to governance tab (pasta)
5ac8475 feat(gui): add governance voting functionality to Qt wallet (pasta)

Pull request description:

  ## Issue being fixed or feature implemented

    - Why is this change required? Currently, users must use CLI commands (gobject vote-many) to vote on governance proposals, which is not user-friendly for non-technical users who prefer the GUI wallet.
    - What problem does it solve? This eliminates the need to use command-line tools for governance voting, making the voting process accessible to all GUI wallet users who own masternodes.

  ## What was done?

    This PR adds complete governance voting functionality to the Qt wallet interface:

    - Added right-click context menu to governance proposals table with "Vote Yes", "Vote No", and "Vote Abstain" options
    - Implemented voting capability detection that checks if the wallet contains any masternode voting keys
    - Added vote signing and submission logic that matches the existing RPC implementation (gobject vote-many)
    - Implemented network-specific signing:
      - Testnet: Uses SignSpecialTxPayload with vote.GetSignatureHash()
      - Other networks: Uses SignMessage with vote.GetSignatureString()
    - Extended interfaces:
      - Added processVoteAndRelay method to the GOV interface (interfaces/node.h)
      - Added signSpecialTxPayload method to the wallet interface (interfaces/wallet.h)
    - Added comprehensive error handling with detailed feedback showing success/failure counts and specific error messages
    - Implemented wallet unlock handling that prompts for passphrase when needed
    - Updates vote counts in the governance list after voting

  ##  How Has This Been Tested?

    - Tested on testnet with multiple masternodes in wallet
    - Verified voting capability detection correctly identifies wallets with/without voting keys
    - Confirmed votes are successfully submitted and accepted by the network
    - Tested wallet unlock flow with encrypted wallets
    - Verified testnet-specific signing works correctly
    - Confirmed vote counts update in the governance list after voting

    Testing environment: macOS, testnet, wallet with 3 masternode voting keys

  https://github.com/user-attachments/assets/de777bf7-2e05-4751-9e56-98e273703e66

  ##  Breaking Changes

    None - this PR only adds new functionality to the GUI without modifying existing behavior.

  ##  Checklist:
    - [x] I have performed a self-review of my own code
    - [x] I have commented my code, particularly in hard-to-understand areas
    - [ ] I have added or updated relevant unit/integration/functional/e2e tests
    - [ ] I have made corresponding changes to the documentation (@thephez)
    - [x] I have assigned this pull request to a milestone (for repository code-owners and collaborators only)

ACKs for top commit:
  UdjinM6:
    light ACK cf4e9e6

Tree-SHA512: aec92043e2432f66d071dccf91d127b91728d35e84ad1ca9fe88c1e15b5c2545a6730108833e7f19f2ef69ac5fdaf4d08288ce9ea0051d123f5a07f2c5f1c91c

Author: PastaPastaPasta

doc/release-notes/release-notes-6690.md

@@ -0,0 +1,5 @@
+GUI changes
+-----------
+
+- Added governance proposal voting functionality to the Qt interface. Users with masternode voting keys can now vote on governance proposals directly from the governance tab via right-click context menu (#6690).
+- Added masternode count display to governance tab showing how many masternodes the wallet can vote with (#6690).

src/governance/vote.cpp

@@ -140,10 +140,6 @@ uint256 CGovernanceVote::GetHash() const
     return hash;
 }
 
-uint256 CGovernanceVote::GetSignatureHash() const
-{
-    return SerializeHash(*this);
-}
 
 bool CGovernanceVote::CheckSignature(const CKeyID& keyID) const
 {
@@ -218,13 +214,6 @@ bool CGovernanceVote::IsValid(const CDeterministicMNList& tip_mn_list, bool useV
     }
 }
 
-std::string CGovernanceVote::GetSignatureString() const
-{
-    return masternodeOutpoint.ToStringShort() + "|" + nParentHash.ToString() + "|" +
-                             ::ToString(nVoteSignal) + "|" +
-                             ::ToString(nVoteOutcome) + "|" +
-                             ::ToString(nTime);
-}
 
 bool operator==(const CGovernanceVote& vote1, const CGovernanceVote& vote2)
 {

src/governance/vote.h

@@ -5,8 +5,10 @@
 #ifndef BITCOIN_GOVERNANCE_VOTE_H
 #define BITCOIN_GOVERNANCE_VOTE_H
 
+#include <hash.h>
 #include <primitives/transaction.h>
 #include <uint256.h>
+#include <util/string.h>
 
 class CActiveMasternodeManager;
 class CBLSPublicKey;
@@ -100,7 +102,13 @@ class CGovernanceVote
     bool Sign(const CActiveMasternodeManager& mn_activeman);
     bool CheckSignature(const CBLSPublicKey& pubKey) const;
     bool IsValid(const CDeterministicMNList& tip_mn_list, bool useVotingKey) const;
-    std::string GetSignatureString() const;
+    std::string GetSignatureString() const
+    {
+        return masternodeOutpoint.ToStringShort() + "|" + nParentHash.ToString() + "|" +
+                                 ::ToString(nVoteSignal) + "|" +
+                                 ::ToString(nVoteOutcome) + "|" +
+                                 ::ToString(nTime);
+    }
     void Relay(PeerManager& peerman, const CMasternodeSync& mn_sync, const CDeterministicMNList& tip_mn_list) const;
 
     const COutPoint& GetMasternodeOutpoint() const { return masternodeOutpoint; }
@@ -112,7 +120,10 @@ class CGovernanceVote
     */
 
     uint256 GetHash() const;
-    uint256 GetSignatureHash() const;
+    uint256 GetSignatureHash() const
+    {
+        return SerializeHash(*this);
+    }
 
     std::string ToString(const CDeterministicMNList& tip_mn_list) const;
 
@@ -126,4 +137,9 @@ class CGovernanceVote
     }
 };
 
+/**
+ * Sign a governance vote using wallet signing methods
+ * Handles different signing approaches for different networks
+ */
+
 #endif // BITCOIN_GOVERNANCE_VOTE_H

src/interfaces/node.h

@@ -27,6 +27,7 @@ class CBlockIndex;
 class CDeterministicMNList;
 class CFeeRate;
 class CGovernanceObject;
+class CGovernanceVote;
 class CNodeStats;
 class Coin;
 class RPCTimerInterface;
@@ -70,6 +71,7 @@ class GOV
     virtual int32_t getObjAbsYesCount(const CGovernanceObject& obj, vote_signal_enum_t vote_signal) = 0;
     virtual bool getObjLocalValidity(const CGovernanceObject& obj, std::string& error, bool check_collateral) = 0;
     virtual bool isEnabled() = 0;
+    virtual bool processVoteAndRelay(const CGovernanceVote& vote, std::string& error) = 0;
     virtual void setContext(node::NodeContext* context) {}
 };
 

src/interfaces/wallet.h

@@ -120,6 +120,9 @@ class Wallet
     //! Sign message
     virtual SigningResult signMessage(const std::string& message, const PKHash& pkhash, std::string& str_sig) = 0;
 
+    //! Sign special transaction payload
+    virtual bool signSpecialTxPayload(const uint256& hash, const CKeyID& keyid, std::vector<unsigned char>& vchSig) = 0;
+
     //! Return whether wallet has private key.
     virtual bool isSpendable(const CScript& script) = 0;
     virtual bool isSpendable(const CTxDestination& dest) = 0;

src/node/interfaces.cpp

@@ -11,8 +11,10 @@
 #include <coinjoin/common.h>
 #include <deploymentstatus.h>
 #include <evo/deterministicmns.h>
+#include <governance/exceptions.h>
 #include <governance/governance.h>
 #include <governance/object.h>
+#include <governance/vote.h>
 #include <init.h>
 #include <interfaces/chain.h>
 #include <interfaces/coinjoin.h>
@@ -140,6 +142,19 @@ class GOVImpl : public GOV
         }
         return false;
     }
+    bool processVoteAndRelay(const CGovernanceVote& vote, std::string& error) override
+    {
+        if (context().govman != nullptr && context().connman != nullptr && context().peerman != nullptr) {
+            CGovernanceException exception;
+            bool result = context().govman->ProcessVoteAndRelay(vote, exception, *context().connman, *context().peerman);
+            if (!result) {
+                error = exception.GetMessage();
+            }
+            return result;
+        }
+        error = "Governance manager not available";
+        return false;
+    }
     void setContext(NodeContext* context) override
     {
         m_context = context;

src/qt/forms/governancelist.ui

@@ -73,9 +73,45 @@
            <property name="orientation">
             <enum>Qt::Horizontal</enum>
            </property>
+           <property name="sizeType">
+            <enum>QSizePolicy::Expanding</enum>
+           </property>
+           <property name="sizeHint" stdset="0">
+            <size>
+             <width>40</width>
+             <height>20</height>
+            </size>
+           </property>
+          </spacer>
+         </item>
+         <item>
+          <widget class="QLabel" name="label_mn_count">
+           <property name="text">
+            <string>Masternode Count:</string>
+           </property>
+           <property name="toolTip">
+            <string>Number of masternodes this wallet can vote with (masternodes for which this wallet holds the voting key)</string>
+           </property>
+          </widget>
+         </item>
+         <item>
+          <widget class="QLabel" name="mnCountLabel">
+           <property name="text">
+            <string notr="true">0</string>
+           </property>
+          </widget>
+         </item>
+         <item>
+          <spacer name="horizontalSpacer_5">
+           <property name="orientation">
+            <enum>Qt::Horizontal</enum>
+           </property>
+           <property name="sizeType">
+            <enum>QSizePolicy::Fixed</enum>
+           </property>
            <property name="sizeHint" stdset="0">
             <size>
-             <width>10</width>
+             <width>20</width>
              <height>20</height>
             </size>
            </property>