fix: more fixes for bugprone-use-after-move clang-tidy

knst · knst · commit 245d1b17c744 · 2025-11-25T22:21:39.000+07:00
diff --git a/src/test/coins_tests.cpp b/src/test/coins_tests.cpp
@@ -761,10 +761,10 @@ static void CheckAddCoinBase(CAmount base_value, CAmount cache_value, CAmount mo
 // while still verifying that the CoinsViewCache::AddCoin implementation
 // ignores base values.
 template <typename... Args>
-static void CheckAddCoin(Args&&... args)
+static void CheckAddCoin(const Args&... args)
 {
     for (const CAmount base_value : {ABSENT, SPENT, VALUE1})
-        CheckAddCoinBase(base_value, std::forward<Args>(args)...);
+        CheckAddCoinBase(base_value, args...);
 }
 
 BOOST_AUTO_TEST_CASE(ccoins_add)

Original file line number	Diff line number	Diff line change
`@@ -761,10 +761,10 @@ static void CheckAddCoinBase(CAmount base_value, CAmount cache_value, CAmount mo`
`761`	`761`	`// while still verifying that the CoinsViewCache::AddCoin implementation`
`762`	`762`	`// ignores base values.`
`763`	`763`	`template <typename... Args>`
`764`		`-static void CheckAddCoin(Args&&... args)`
	`764`	`+static void CheckAddCoin(const Args&... args)`
`765`	`765`	`{`
`766`	`766`	`for (const CAmount base_value : {ABSENT, SPENT, VALUE1})`
`767`		`- CheckAddCoinBase(base_value, std::forward<Args>(args)...);`
	`767`	`+ CheckAddCoinBase(base_value, args...);`
`768`	`768`	`}`
`769`	`769`
`770`	`770`	`BOOST_AUTO_TEST_CASE(ccoins_add)`