Skip to content

Commit 4f8ff3c

Browse files
fanquakevijaydasmp
authored andcommitted
Merge bitcoin#25849: refactor: Remove not needed empty RPC doc std::string
fac09f4 refactor: Remove not needed empty RPC doc std::string (MacroFake) Pull request description: Not sure why this was put there, so remove it ACKs for top commit: aureleoules: ACK fac09f4. Tree-SHA512: 7fae9c612dbb82db39e3dc6e20cc7d0c8128f4abf27e34f4854f908dc1bf3ad48ebee2dbbb864a9ce95e98c5d57119bf976793945a2084a43d137c2d95a25ea1
1 parent d167cc6 commit 4f8ff3c

File tree

1 file changed

+8
-8
lines changed

1 file changed

+8
-8
lines changed

src/wallet/rpc/spend.cpp

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -134,8 +134,8 @@ RPCHelpMan sendtoaddress()
134134
{"use_is", RPCArg::Type::BOOL, RPCArg::Default{false}, "Deprecated and ignored"},
135135
{"use_cj", RPCArg::Type::BOOL, RPCArg::Default{false}, "Use CoinJoin funds only"},
136136
{"conf_target", RPCArg::Type::NUM, RPCArg::DefaultHint{"wallet -txconfirmtarget"}, "Confirmation target in blocks"},
137-
{"estimate_mode", RPCArg::Type::STR, RPCArg::Default{"unset"}, std::string() + "The fee estimate mode, must be one of (case insensitive):\n"
138-
" \"" + FeeModes("\"\n\"") + "\""},
137+
{"estimate_mode", RPCArg::Type::STR, RPCArg::Default{"unset"}, "The fee estimate mode, must be one of (case insensitive):\n"
138+
"\"" + FeeModes("\"\n\"") + "\""},
139139
{"avoid_reuse", RPCArg::Type::BOOL, RPCArg::Default{true}, "(only available if avoid_reuse wallet flag is set) Avoid spending from dirty addresses; addresses are considered\n"
140140
"dirty if they have previously been used in a transaction."},
141141
{"fee_rate", RPCArg::Type::AMOUNT, RPCArg::DefaultHint{"not set, fall back to wallet fee estimation"}, "Specify a fee rate in " + CURRENCY_ATOM + "/B."},
@@ -246,8 +246,8 @@ RPCHelpMan sendmany()
246246
{"use_is", RPCArg::Type::BOOL, RPCArg::Default{false}, "Deprecated and ignored"},
247247
{"use_cj", RPCArg::Type::BOOL, RPCArg::Default{false}, "Use CoinJoin funds only"},
248248
{"conf_target", RPCArg::Type::NUM, RPCArg::DefaultHint{"wallet -txconfirmtarget"}, "Confirmation target in blocks"},
249-
{"estimate_mode", RPCArg::Type::STR, RPCArg::Default{"unset"}, std::string() + "The fee estimate mode, must be one of (case insensitive):\n"
250-
" \"" + FeeModes("\"\n\"") + "\""},
249+
{"estimate_mode", RPCArg::Type::STR, RPCArg::Default{"unset"}, "The fee estimate mode, must be one of (case insensitive):\n"
250+
"\"" + FeeModes("\"\n\"") + "\""},
251251
{"fee_rate", RPCArg::Type::AMOUNT, RPCArg::DefaultHint{"not set, fall back to wallet fee estimation"}, "Specify a fee rate in " + CURRENCY_ATOM + "/B."},
252252
{"verbose", RPCArg::Type::BOOL, RPCArg::Default{false}, "If true, return extra information about the transaction."},
253253
},
@@ -361,8 +361,8 @@ static std::vector<RPCArg> FundTxDoc()
361361
{
362362
return {
363363
{"conf_target", RPCArg::Type::NUM, RPCArg::DefaultHint{"wallet -txconfirmtarget"}, "Confirmation target in blocks"},
364-
{"estimate_mode", RPCArg::Type::STR, RPCArg::Default{"unset"}, std::string() + "The fee estimate mode, must be one of (case insensitive):\n"
365-
" \"" + FeeModes("\"\n\"") + "\""},
364+
{"estimate_mode", RPCArg::Type::STR, RPCArg::Default{"unset"}, "The fee estimate mode, must be one of (case insensitive):\n"
365+
"\"" + FeeModes("\"\n\"") + "\""},
366366
{"solving_data", RPCArg::Type::OBJ, RPCArg::Optional::OMITTED_NAMED_ARG, "Keys and scripts needed for producing a final transaction with a dummy signature.\n"
367367
"Used for fee estimation during coin selection.",
368368
{
@@ -820,8 +820,8 @@ RPCHelpMan send()
820820
},
821821
},
822822
{"conf_target", RPCArg::Type::NUM, RPCArg::DefaultHint{"wallet -txconfirmtarget"}, "Confirmation target in blocks"},
823-
{"estimate_mode", RPCArg::Type::STR, RPCArg::Default{"unset"}, std::string() + "The fee estimate mode, must be one of (case insensitive):\n"
824-
" \"" + FeeModes("\"\n\"") + "\""},
823+
{"estimate_mode", RPCArg::Type::STR, RPCArg::Default{"unset"}, "The fee estimate mode, must be one of (case insensitive):\n"
824+
"\"" + FeeModes("\"\n\"") + "\""},
825825
{"fee_rate", RPCArg::Type::AMOUNT, RPCArg::DefaultHint{"not set, fall back to wallet fee estimation"}, "Specify a fee rate in " + CURRENCY_ATOM + "/B."},
826826
{"options", RPCArg::Type::OBJ, RPCArg::Optional::OMITTED_NAMED_ARG, "",
827827
Cat<std::vector<RPCArg>>(

0 commit comments

Comments
 (0)