Merge #6607: feat: add id to getislocks rpc output

1107202 docs: add release notes (UdjinM6)
24d96d6 test: add test (UdjinM6)
fec75a3 feat: add `id` to `getislocks` rpc output (UdjinM6)

Pull request description:

  ## Issue being fixed or feature implemented
  `verifyislock` rpc needs request `id` as a param but `getislocks` (or any other rpc) doesn't provide one so it's hard to use

  ## What was done?

  ## How Has This Been Tested?

  ## Breaking Changes

  ## Checklist:
  - [ ] I have performed a self-review of my own code
  - [ ] I have commented my code, particularly in hard-to-understand areas
  - [ ] I have added or updated relevant unit/integration/functional/e2e tests
  - [ ] I have made corresponding changes to the documentation
  - [ ] I have assigned this pull request to a milestone _(for repository code-owners and collaborators only)_

ACKs for top commit:
  knst:
    utACK 1107202
  PastaPastaPasta:
    utACK 1107202

Tree-SHA512: e23a32bfe802496a02348eac4e9cfbfb9b062c0e21eba6f401cd40c145e7c8474ece3b01fd271ea2ac98c2350a0bdf2b50a132281bf5045c18ec22657a5d472d

Author: PastaPastaPasta

doc/release-notes-6607.md

@@ -0,0 +1,4 @@
+Updated RPCs
+------------
+
+* `getislocks` will now return request `id` for each InstantSend Lock in results

src/rpc/rawtransaction.cpp

@@ -387,6 +387,7 @@ static RPCHelpMan getislocks()
                             },
                         },
                     }},
+                    {RPCResult::Type::STR_HEX, "id", "Request ID"},
                     {RPCResult::Type::STR_HEX, "cycleHash", "The Cycle Hash"},
                     {RPCResult::Type::STR_HEX, "signature", "The InstantSend's BLS signature"},
                     {RPCResult::Type::STR_HEX, "hex", "The serialized, hex-encoded data for 'txid'"},
@@ -424,6 +425,7 @@ static RPCHelpMan getislocks()
                 inputs.push_back(outpoint);
             }
             objIS.pushKV("inputs", inputs);
+            objIS.pushKV("id", islock->GetRequestId().ToString());
             objIS.pushKV("cycleHash", islock->cycleHash.ToString());
             objIS.pushKV("signature", islock->sig.ToString());
             {

test/functional/rpc_verifyislock.py

@@ -5,7 +5,7 @@
 
 from test_framework.messages import CTransaction, from_hex, hash256, ser_compact_size, ser_string
 from test_framework.test_framework import DashTestFramework
-from test_framework.util import assert_raises_rpc_error, satoshi_round
+from test_framework.util import assert_equal, assert_raises_rpc_error, satoshi_round
 
 '''
 rpc_verifyislock.py
@@ -41,6 +41,8 @@ def run_test(self):
         self.wait_for_instantlock(txid, node)
 
         request_id = self.get_request_id(self.nodes[0].getrawtransaction(txid))
+        request_id_rpc = self.nodes[0].getislocks([txid])[0]["id"]
+        assert_equal(request_id, request_id_rpc)
         self.wait_until(lambda: node.quorum("hasrecsig", 103, request_id, txid))
 
         rec_sig = node.quorum("getrecsig", 103, request_id, txid)['sig']