Merge #6900: backport: bitcoin#25645, bitcoin#25668 fix iwyu on node/chainstate, dbwrapper.h and related fixes

79f7424 fix: some iwyu recommendations to update includes (Konstantin Akimov)
d5c8cab fix: missing iwyu from bitcoin#24974 (Konstantin Akimov)
f1ad7a6 fix: missing iwyu items from bitcoin#25694 (Konstantin Akimov)
b9a9630 fix: missing lint-tidy warnings from bitcoin#25254 (Konstantin Akimov)
bf1dd33 Merge bitcoin#25668: refactor: Fix iwyu on node/chainstate (MacroFake)
7a3f393 Merge bitcoin#25645: refactor: Remove unused includes from dbwrapper.h (fanquake)

Pull request description:

  ## Issue being fixed or feature implemented
  Some files has been missing when added to iwyu linter list.

  ## What was done?
  Backport bitcoin#25645, bitcoin#25668 missing fixes from bitcoin#24974, bitcoin#25694, bitcoin#25254 and related fixes to apply linter's messages.

  ## How Has This Been Tested?
  Revised output of CI iwuy

  ## Breaking Changes
  N/A

  ## Checklist:
    _Go over all the following points, and put an `x` in all the boxes that apply._
  - [x] I have performed a self-review of my own code
  - [ ] I have commented my code, particularly in hard-to-understand areas
  - [ ] I have added or updated relevant unit/integration/functional/e2e tests
  - [ ] I have made corresponding changes to the documentation
  - [x] I have assigned this pull request to a milestone _(for repository code-owners and collaborators only)_

ACKs for top commit:
  UdjinM6:
    utACK 79f7424
  kwvg:
    utACK 79f7424

Tree-SHA512: 0ab2b87ea561adabace3339ea8742a661818d3e6e3793a7f5ed0a5dd9169bc55ade6e365da5ac31f90540e07a09682b07c53a707894f816581dbba826e7d91d4

Author: PastaPastaPasta

ci/dash/lint-tidy.sh

@@ -21,10 +21,17 @@ fi
 cd "${BASE_ROOT_DIR}/build-ci/dashcore-${BUILD_TARGET}"
 iwyu_tool.py \
   "src/compat" \
+  "src/dbwrapper.cpp" \
   "src/init" \
+  "src/node/chainstate.cpp" \
+  "src/policy/feerate.cpp" \
+  "src/policy/packages.cpp" \
+  "src/policy/settings.cpp" \
+  "src/primitives/transaction.cpp" \
   "src/rpc/fees.cpp" \
   "src/rpc/signmessage.cpp" \
   "src/test/fuzz/txorphan.cpp" \
+  "src/threadinterrupt.cpp" \
   "src/util/bip32.cpp" \
   "src/util/bytevectorhash.cpp" \
   "src/util/check.cpp" \

src/bench/checkblock.cpp

@@ -9,6 +9,7 @@
 #include <consensus/validation.h>
 #include <stats/client.h>
 #include <streams.h>
+#include <util/system.h>
 #include <validation.h>
 
 #include <memory>

src/dbwrapper.cpp

@@ -4,15 +4,26 @@
 
 #include <dbwrapper.h>
 
-#include <memory>
+#include <fs.h>
+#include <logging.h>
 #include <random.h>
+#include <util/strencodings.h>
+#include <util/system.h>
 
+#include <algorithm>
+#include <cassert>
+#include <cstdarg>
+#include <cstdint>
+#include <cstdio>
 #include <leveldb/cache.h>
+#include <leveldb/db.h>
 #include <leveldb/env.h>
 #include <leveldb/filter_policy.h>
 #include <leveldb/helpers/memenv/memenv.h>
-#include <stdint.h>
-#include <algorithm>
+#include <leveldb/iterator.h>
+#include <leveldb/options.h>
+#include <leveldb/status.h>
+#include <memory>
 #include <optional>
 
 class CBitcoinLevelDBLogger : public leveldb::Logger {

src/dbwrapper.h

@@ -5,18 +5,38 @@
 #ifndef BITCOIN_DBWRAPPER_H
 #define BITCOIN_DBWRAPPER_H
 
+#include <assert.h>
 #include <clientversion.h>
 #include <fs.h>
+#include <logging.h>
 #include <serialize.h>
 #include <span.h>
 #include <streams.h>
-#include <util/strencodings.h>
-#include <util/system.h>
 
-#include <typeindex>
+#include <sys/types.h>
 
+#include <algorithm>
+#include <cstddef>
+#include <cstdint>
+#include <exception>
 #include <leveldb/db.h>
+#include <leveldb/iterator.h>
+#include <leveldb/options.h>
+#include <leveldb/slice.h>
+#include <leveldb/status.h>
 #include <leveldb/write_batch.h>
+#include <map>
+#include <memory>
+#include <set>
+#include <stdexcept>
+#include <string>
+#include <type_traits>
+#include <utility>
+#include <vector>
+
+namespace leveldb {
+class Env;
+}
 
 static const size_t DBWRAPPER_PREALLOC_KEY_SIZE = 64;
 static const size_t DBWRAPPER_PREALLOC_VALUE_SIZE = 1024;

src/evo/evodb.cpp

@@ -3,6 +3,7 @@
 // file COPYING or http://www.opensource.org/licenses/mit-license.php.
 
 #include <evo/evodb.h>
+#include <util/system.h>
 
 #include <uint256.h>
 

src/evo/specialtxman.cpp

@@ -11,6 +11,7 @@
 #include <hash.h>
 #include <primitives/block.h>
 #include <util/irange.h>
+#include <util/system.h>
 #include <validation.h>
 
 #include <chainlock/chainlock.h>

src/index/base.cpp

@@ -8,6 +8,7 @@
 #include <node/interface_ui.h>
 #include <shutdown.h>
 #include <tinyformat.h>
+#include <util/system.h>
 #include <util/thread.h>
 #include <util/translation.h>
 #include <validation.h>

src/index/blockfilterindex.cpp

@@ -9,6 +9,7 @@
 #include <index/blockfilterindex.h>
 #include <node/blockstorage.h>
 #include <serialize.h>
+#include <util/system.h>
 
 using node::UndoReadFromDisk;
 

src/index/coinstatsindex.cpp

@@ -10,6 +10,7 @@
 #include <serialize.h>
 #include <txdb.h>
 #include <undo.h>
+#include <util/system.h>
 #include <validation.h>
 #include <util/check.h>
 

src/init/common.cpp

@@ -16,6 +16,7 @@
 #include <node/interface_ui.h>
 #include <random.h>
 #include <tinyformat.h>
+#include <util/time.h>
 #include <util/string.h>
 #include <util/system.h>
 #include <util/translation.h>