Skip to content

Commit bac6bfa

Browse files
Merge #7058: fix: add mutable to make the captured work non-const, allowing it to be properly moved
7371f51 fix: add `mutable` to make the captured `work` non-const, allowing it to be properly moved (UdjinM6) Pull request description: ## Issue being fixed or feature implemented clang-tidy complains on develop https://github.com/dashpay/dash/actions/runs/20066954644/job/57558275807 #7004 follow-up ## What was done? Lambda captures are const by default, so `std::move(work)` inside the lambda had no effect. Add `mutable` to make the captured `work` non-const, allowing it to be properly moved. ## How Has This Been Tested? https://github.com/UdjinM6/dash/actions/runs/20079838716/job/57605752892 ## Breaking Changes n/a ## Checklist: - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have added or updated relevant unit/integration/functional/e2e tests - [ ] I have made corresponding changes to the documentation - [ ] I have assigned this pull request to a milestone _(for repository code-owners and collaborators only)_ ACKs for top commit: PastaPastaPasta: utACK 7371f51 kwvg: utACK 7371f51 Tree-SHA512: 56d3a6045e86ebbdce8cac328282c002f65a1c482a02a8cbdf87b4ac29e4bce2de3160eaca78171619771efa19b8343d4dc336ecad38b983fa02cba2793ddecb
2 parents b668f8d + 7371f51 commit bac6bfa

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

src/llmq/signing_shares.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1668,7 +1668,7 @@ void CSigSharesManager::DispatchPendingSigns()
16681668
for (auto& work : signs) {
16691669
if (workInterrupt) break;
16701670

1671-
workerPool.push([this, work = std::move(work)](int) {
1671+
workerPool.push([this, work = std::move(work)](int) mutable {
16721672
SignAndProcessSingleShare(std::move(work));
16731673
});
16741674
}

0 commit comments

Comments
 (0)