refactor: remove unused mn_sync from llmq context

Author: knst

src/instantsend/instantsend.cpp

@@ -17,11 +17,10 @@ using node::fReindex;
 
 namespace llmq {
 CInstantSendManager::CInstantSendManager(const chainlock::Chainlocks& chainlocks, CSporkManager& sporkman,
-                                         const CMasternodeSync& mn_sync, const util::DbWrapperParams& db_params) :
+                                         const util::DbWrapperParams& db_params) :
     db{db_params},
     m_chainlocks{chainlocks},
-    spork_manager{sporkman},
-    m_mn_sync{mn_sync}
+    spork_manager{sporkman}
 {
 }
 

src/instantsend/instantsend.h

@@ -22,7 +22,6 @@
 
 class CBlockIndex;
 class CDataStream;
-class CMasternodeSync;
 class CSporkManager;
 namespace Consensus {
 struct LLMQParams;
@@ -61,7 +60,6 @@ class CInstantSendManager
 
     const chainlock::Chainlocks& m_chainlocks;
     CSporkManager& spork_manager;
-    const CMasternodeSync& m_mn_sync;
 
     mutable Mutex cs_pendingLocks;
     // Incoming and not verified yet
@@ -98,7 +96,7 @@ class CInstantSendManager
     CInstantSendManager(const CInstantSendManager&) = delete;
     CInstantSendManager& operator=(const CInstantSendManager&) = delete;
     explicit CInstantSendManager(const chainlock::Chainlocks& chainlocks, CSporkManager& sporkman,
-                                 const CMasternodeSync& mn_sync, const util::DbWrapperParams& db_params);
+                                 const util::DbWrapperParams& db_params);
     ~CInstantSendManager();
 
     void AddNonLockedTx(const CTransactionRef& tx, const CBlockIndex* pindexMined)

src/llmq/context.cpp

@@ -13,7 +13,7 @@
 #include <validation.h>
 
 LLMQContext::LLMQContext(CDeterministicMNManager& dmnman, CEvoDB& evo_db, CSporkManager& sporkman,
-                         chainlock::Chainlocks& chainlocks, ChainstateManager& chainman, const CMasternodeSync& mn_sync,
+                         chainlock::Chainlocks& chainlocks, ChainstateManager& chainman,
                          const util::DbWrapperParams& db_params, int8_t bls_threads, int64_t max_recsigs_age) :
     bls_worker{std::make_shared<CBLSWorker>()},
     qsnapman{std::make_unique<llmq::CQuorumSnapshotManager>(evo_db)},
@@ -22,7 +22,7 @@ LLMQContext::LLMQContext(CDeterministicMNManager& dmnman, CEvoDB& evo_db, CSpork
     qman{std::make_unique<llmq::CQuorumManager>(*bls_worker, dmnman, evo_db, *quorum_block_processor, *qsnapman,
                                                 chainman, db_params)},
     sigman{std::make_unique<llmq::CSigningManager>(*qman, db_params, max_recsigs_age)},
-    isman{std::make_unique<llmq::CInstantSendManager>(chainlocks, sporkman, mn_sync, db_params)}
+    isman{std::make_unique<llmq::CInstantSendManager>(chainlocks, sporkman, db_params)}
 {
     // Have to start it early to let VerifyDB check ChainLock signatures in coinbase
     bls_worker->Start();

src/llmq/context.h

@@ -13,7 +13,6 @@ class CBLSWorker;
 class ChainstateManager;
 class CDeterministicMNManager;
 class CEvoDB;
-class CMasternodeSync;
 class CSporkManager;
 class PeerManager;
 
@@ -38,7 +37,7 @@ struct LLMQContext {
     LLMQContext(const LLMQContext&) = delete;
     LLMQContext& operator=(const LLMQContext&) = delete;
     explicit LLMQContext(CDeterministicMNManager& dmnman, CEvoDB& evo_db, CSporkManager& sporkman,
-                         chainlock::Chainlocks& chainlocks, ChainstateManager& chainman, const CMasternodeSync& mn_sync,
+                         chainlock::Chainlocks& chainlocks, ChainstateManager& chainman,
                          const util::DbWrapperParams& db_params, int8_t bls_threads, int64_t max_recsigs_age);
     ~LLMQContext();
 

src/node/chainstate.cpp

@@ -227,7 +227,7 @@ void DashChainstateSetup(ChainstateManager& chainman,
     dmnman = std::make_unique<CDeterministicMNManager>(evodb, mn_metaman);
 
     llmq_ctx.reset();
-    llmq_ctx = std::make_unique<LLMQContext>(*dmnman, evodb, sporkman, chainlocks, chainman, mn_sync,
+    llmq_ctx = std::make_unique<LLMQContext>(*dmnman, evodb, sporkman, chainlocks, chainman,
                                              util::DbWrapperParams{.path = data_dir, .memory = llmq_dbs_in_memory, .wipe = llmq_dbs_wipe},
                                              bls_threads, max_recsigs_age);
     mempool->ConnectManagers(dmnman.get(), llmq_ctx->isman.get());